fixing tied label get/set vs configuration page

[Michael Donohue]

I've been looking at some issues for the configurationslicing plugin, and one that came up is https://issues.jenkins-ci.org/browse/JENKINS-29547 which says the configuration slice for 'tied label' ignores the value 'master'.

It looks like this is an issue with core jenkins, as I commented in the issue.  The get/set functions enforce a representation invariant that 'master' is saved as a null label, but the job configuration page doesn't follow that invariant, and it bypasses the get/set functions.  Thus when setting 'master' via the configuration slicing plugin, the job configuration appears not to have a tied label at all.

I have what I think is a reasonable fix for jenkins core, but I am unable to get jenkins to build on Windows without errors. 

My proposed fix is here, but I've thus far been unable to test it due to Windows build issues: https://github.com/mdonohue/jenkins/commit/2cb89d3e269318644fabd1acb4861690e662aef9
    

[Oleg Nenashev]

Hi.

The best recommendation would be to create a pull-request to Jenkins.
Then PR builder will build your code and run tests. If the build passes you will be also able to download Jenkins WAR file from there and reuse results.

For local tests you can also build with -DskipTests . It will prevent Windows failures on tests. Builds are supposed to pass on Windows as well, but we don't test this flow regularly.

BR, Oleg

вторник, 20 октября 2015 г., 8:01:27 UTC+3 пользователь mdonohue написал: