[JENKINS-24876] code review needed before sending pull request?

[Verny Quartara]

Hi everybody,

I fixed the above issue on Deploy-Plugin, should I contact the mantainers for code review or should I send the pull request?

Forgive me if I'm hurrying, but I need this little improvement asap, meanwhile I install it using the .hpi file.

This is my forked branch: https://github.com/vernyquartara/deploy-plugin

Thanks

Kind regards

--
Verny Quartara

[Baptiste Mathus]

Just send the pull request if you think it is ready. Pull requests are indeed for review.
Cheers

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Verny Quartara]

Having received no feedback in a month, I've just sent a pull request that fixes the issue JENKINS-24876.

Regards

Verny

--

Verny Quartara

[Baptiste Mathus]

Well actually you had had my feedback. Are you correctly subscribed to the list?
Cheers

Le ven. 31 oct. 2014 18:20, Verny Quartara <web...@gmail.com> a écrit :

[Verny Quartara]

Ok, I saw it here, I wasn't correctly subscribed, thanks.

Well, the pull request is sent, let me know.

Cheers

--

Verny Quartara

[Verny Quartara]

Hello and Happy new year to everybody.

What about my pull request? https://github.com/jenkinsci/deploy-plugin/pull/17

Can someone review it?

--

Verny Quartara