Proposal teams: GitHub teams for active contributors without write permissions

35 views
Skip to first unread message

Oleg Nenashev

unread,
Oct 5, 2019, 8:12:02 PM10/5/19
to jenkins-advocacy...@googlegroups.com, JenkinsCI Developers
Hi all,

I would like to sign-off creating GitHub teams for active contributors who do not have write access to repositories in jenkinsci and jenkins-infra organizations.

Why? We have many contributors who help the Jenkins project a lot but not listed as organization members on GitHub... just because they do not need any special permissions for their work. For example, René Scheibe and Zbynek Konecny contributed dozens of pull requests to improve documentation and code across multiple components... but they are not members of jenkinsci. Adding such contributors to the organization is IMHO a way to recognize their contributions, and it allows contributors to put the Jenkins org badge to their GitHub profiles. It would also allow to request their reviews in the components if needed.

What do I propose?
  • Private "contributors" teams are created in jenkinsci and jenkins-infra. Teams are private so that they cannot be mentioned unintentionally. Teams have no specific access to the repositories
  • External contributors can be added to the organization if they remain active in the community for 1 month or above and create 5+ pull requests (feel free to propose different numbers, I am just trying to set some criteria)
  • Jenkins GitHub admins can add people to the teams upon request
  • ChatOps bot command may be implemented later to enable other maintainers to add contributors
 What do you think?

Thanks in advance,
Oleg

Marky Jackson

unread,
Oct 5, 2019, 8:14:42 PM10/5/19
to Oleg Nenashev, jenkins-advocacy...@googlegroups.com, JenkinsCI Developers
I am +1 for this 

{     
    "regards" : {
         "name" : “marky”,
         "phone" : "+1 (408) 464 2965”,
         "email" : “marky.r...@gmail.com",
         "team" : “jackson5“,
 “role” : “software engineer"
     }
 }

On Oct 5, 2019, at 5:11 PM, Oleg Nenashev <o.v.ne...@gmail.com> wrote:


--
You received this message because you are subscribed to the Google Groups "Jenkins Advocacy and Outreach SIG" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkins-advocacy-and-o...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkins-advocacy-and-outreach-sig/CAPfivLDPu77BovhUiGamx1t5FewLgq-Xu0hcQwjBk07D39Z99w%40mail.gmail.com.

Mark Waite

unread,
Oct 5, 2019, 8:19:03 PM10/5/19
to Marky Jackson, Oleg Nenashev, jenkins-advocacy...@googlegroups.com, JenkinsCI Developers
+1 from me.  Thresholds seem reasonable and I really like it as a way to request reviews from them.



--
Thanks!
Mark Waite

Rick

unread,
Oct 5, 2019, 9:10:51 PM10/5/19
to Developers Jenkins, Marky Jackson, Oleg Nenashev, 宣传与推广SIG Jenkins
+1 from me

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHRk-5D2qWx0sPUAn7Z8CO2wkgMZQiJ0V2XmgYzyzGbxg%40mail.gmail.com.


--

Matt Sicker

unread,
Oct 7, 2019, 12:21:06 PM10/7/19
to jenkin...@googlegroups.com, Marky Jackson, Oleg Nenashev, 宣传与推广SIG Jenkins
I like this idea, too. +1



--
Matt Sicker
Senior Software Engineer, CloudBees

Tim Jacomb

unread,
Oct 7, 2019, 2:35:25 PM10/7/19
to jenkin...@googlegroups.com, jenkins-advocacy...@googlegroups.com
What benefit does the team have? Over just adding the person to the org

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

Oleg Nenashev

unread,
Oct 7, 2019, 3:22:30 PM10/7/19
to Tim Jacomb, JenkinsCI Developers, jenkins-advocacy...@googlegroups.com
No other real benefits unfortunately. It would be great to send some swag in parallel, but we do not have any confirmed policy for it. Maybe we could discuss it later once the board/officer elections are over

You received this message because you are subscribed to the Google Groups "Jenkins Advocacy and Outreach SIG" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkins-advocacy-and-o...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkins-advocacy-and-outreach-sig/CAH-3BidgBQ8F8CeJCj-ZLB2K6Q-Syp90pb4ubSBp%2BtD%3DCL7MZQ%40mail.gmail.com.

Oleg Nenashev

unread,
Oct 7, 2019, 6:48:44 PM10/7/19
to Jenkins Developers
Thanks all for the feedback! I went ahead and implemented it inside the jenkinsci GitHub org.
Please feel free to nominate members if you see that any active contributor is missing


On Monday, October 7, 2019 at 9:22:30 PM UTC+2, Oleg Nenashev wrote:
No other real benefits unfortunately. It would be great to send some swag in parallel, but we do not have any confirmed policy for it. Maybe we could discuss it later once the board/officer elections are over

On Mon, Oct 7, 2019, 20:35 Tim Jacomb <timja...@gmail.com> wrote:
What benefit does the team have? Over just adding the person to the org
On Sun, 6 Oct 2019 at 01:12, Oleg Nenashev <o.v.ne...@gmail.com> wrote:
Hi all,

I would like to sign-off creating GitHub teams for active contributors who do not have write access to repositories in jenkinsci and jenkins-infra organizations.

Why? We have many contributors who help the Jenkins project a lot but not listed as organization members on GitHub... just because they do not need any special permissions for their work. For example, René Scheibe and Zbynek Konecny contributed dozens of pull requests to improve documentation and code across multiple components... but they are not members of jenkinsci. Adding such contributors to the organization is IMHO a way to recognize their contributions, and it allows contributors to put the Jenkins org badge to their GitHub profiles. It would also allow to request their reviews in the components if needed.

What do I propose?
  • Private "contributors" teams are created in jenkinsci and jenkins-infra. Teams are private so that they cannot be mentioned unintentionally. Teams have no specific access to the repositories
  • External contributors can be added to the organization if they remain active in the community for 1 month or above and create 5+ pull requests (feel free to propose different numbers, I am just trying to set some criteria)
  • Jenkins GitHub admins can add people to the teams upon request
  • ChatOps bot command may be implemented later to enable other maintainers to add contributors
 What do you think?

Thanks in advance,
Oleg

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Advocacy and Outreach SIG" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkins-advocacy-and-outreach-sig+unsubscribe@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages