Automerge of safe dependency updates merges too quickly?

[Mark Waite]

I have enabled automated merging of safe dependency updates with 

https://github.com/jenkinsci/jackson-annotations2-api-plugin/blob/main/.github/workflows/auto-merge-safe-deps.yml

However, the system appears to merge the dependencies while the CI job is still running.

Am I missing a branch protection configuration or something else that would cause the action to wait for the checks to complete before it merges the pull request?

Mark Waite

[Tim Jacomb]

You need to enable "Require status checks to pass before merging" in branch protection adding the "Jenkins" check.

(Or configure a ruleset)

Its generally expected the repositories using CD have that configured.

It's left off on MRP ones as it needs to push commits directly to the main branch.

(We could probably set this up by default on new hosted plugins that use CD)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtE%2BT1N2g4tauCKaA%2B9__4hYLzgPLp1bvR7E%3DP3pjwxkmA%40mail.gmail.com.