Proposal: Excluding JRebel support from the Jenkins core (JENKINS-64037)

37 views
Skip to first unread message

Oleg Nenashev

unread,
Oct 27, 2020, 12:40:24 PM10/27/20
to JenkinsCI Developers
Hi all,

At some point there was a JRebel model added to Stapler and the Jenkins core. It was used to support hot reloading of classes when developing Jenkins in some conditions: https://wiki.jenkins.io/display/JENKINS/Developing+with+JRebel .

This flow has not been used for a long time. It is unlikely that it can operate properly anymore, especially with Java 11. I suggest removing the dependency on JRebel to reduce the Jenkins core size and to prevent potential transitive dependency issues and to slightly reduce the jenkins core's footprint. What do you think?

P.S: If someone wants to recover the JRebel support and demonstrate it, it might be even better than just removing the component.

Thanks in advance,
Oleg



Mark Waite

unread,
Oct 27, 2020, 1:07:23 PM10/27/20
to jenkinsci-dev
That seems reasonable to me.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCVODHF54xk-nV29QZ8npMzmLZe6Y14HznvW9yTR7aqLw%40mail.gmail.com.

Jesse Glick

unread,
Oct 27, 2020, 3:28:11 PM10/27/20
to Jenkins Dev
Makes sense. If and when somebody wants to use this, they can figure
out how to freshen it up.

Oleg Nenashev

unread,
Nov 2, 2020, 11:44:23 AM11/2/20
to Jenkins Developers
Same question about https://github.com/stapler/stapler-adjunct-zeroclipboard . It is a part of the Jenkins core API and it "provides an easy way to copy text to the clipboard using an invisible Adobe Flash movie and a JavaScript interface". Yes, with flash...  Last release of this Stapler module was in 2014, last release of the upstream https://github.com/zeroclipboard/zeroclipboard was in 2017. 


With Adobe Flash being deprecated and EoLed, maybe we should also remove this library from the core

Daniel Beck

unread,
Nov 2, 2020, 11:47:58 AM11/2/20
to JenkinsCI Developers
On Mon, Nov 2, 2020 at 5:44 PM Oleg Nenashev <o.v.ne...@gmail.com> wrote:
Same question about https://github.com/stapler/stapler-adjunct-zeroclipboard . It is a part of the Jenkins core API and it "provides an easy way to copy text to the clipboard using an invisible Adobe Flash movie and a JavaScript interface". Yes, with flash...  Last release of this Stapler module was in 2014, last release of the upstream https://github.com/zeroclipboard/zeroclipboard was in 2017. 


With Adobe Flash being deprecated and EoLed, maybe we should also remove this library from the core


Tim Jacomb

unread,
Nov 2, 2020, 1:32:21 PM11/2/20
to jenkin...@googlegroups.com
Bin it

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
Reply all
Reply to author
Forward
0 new messages