new plugin, attention-plugin

[Marcus Jacobsson]

Hi

We've are working on releasing a plugin we've used internally and making it public. We've committed it to my github account but would like to move it to the jenkinci github instead. Could someone help us setup an repository.

It's a plugin we use internally to help tracking red builds.

The current project URL:

https://github.com/hanabishi/attention-plugin

Github IDs:

hanabishi

patrikha

olofek

miphip 

/Marcus

[Baptiste Mathus]

Hi,

Trying to understand what your plugin does (a README could be added to give basic info + link to wiki ?)

IIUC, it is designed to let people tell they volunteer to fix a build? If so, how does it compare to the Claim Plugin? Or Warnings maybe? 

Cheers

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAArNws1K%2BfzBAyZmmp%3DzxABFbtVfEozHJ8J0VgntaqQS1XHKGA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

Baptiste <Batmat> MATHUS - http://batmat.net
Sauvez un arbre,
Mangez un castor !

[Christopher Orr]

Yeah, this sounds like it should be an extension of the Claim plugin.

But it seems that getting a jenkinsci repo and following the regular
procedure has been ignored, and a version of the plugin has already been
released, and a wiki page created...

https://twitter.com/jenkins_release/status/652525957207592960

On 09/10/15 13:43, Baptiste Mathus wrote:
> Hi,
>
> Trying to understand what your plugin does (a README could be added to
> give basic info + link to wiki ?)
>
> IIUC, it is designed to let people tell they volunteer to fix a build?
> If so, how does it compare to the Claim Plugin? Or Warnings maybe?
>
> Cheers
>
> 2015-10-09 13:25 GMT+02:00 Marcus Jacobsson <m...@hanabi.se

> <mailto:m...@hanabi.se>>:

[Baptiste Mathus]

Yup, agreed, saw the tweet this morning. I don't think that's cool.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5618BA21.2060504%40orr.me.uk.

For more options, visit https://groups.google.com/d/optout.

[Richard Bywater]

I guess that is what happens when you have permissions so open :(  Given the size of the project now is it time to also review permission systems as part of "Jenkins 2.0"?

Richard.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4Fwpa%2Bh%3D1r9CD8YhjbWhQUaU0%2BBhv32STgOtNh%3DL_S_A%40mail.gmail.com.

[Victor Martinez]

That's bad!! Is there any wiki of how to proceed in case a new plugin has been released without being part of the standard release? I didn't know people could release directly without agreeing. Any chance to somehow rollback that plugin from the update center and talk again whether it should be part of the claim plugin or an independent plugin as now?

Cheers

[Daniel Beck]

Plugin IDs (or plugin IDs + version number) can be blacklisted in the update center.
https://github.com/orrc/backend-update-center2/blob/master/src/main/resources/artifact-ignores.properties

Not sure whether this particular plugin warrants that step though -- any further opinions? Would be great if the plugin developers could chime in as well on why they decided to go ahead and release rather than address the concerns expressed in this thread (and which are well documented, e.g. on https://wiki.jenkins-ci.org/display/JENKINS/Before+starting+a+new+plugin).

On 10.10.2015, at 23:58, Victor Martinez <victormar...@gmail.com> wrote:

> That's bad!! Is there any wiki of how to proceed in case a new plugin has been released without being part of the standard release? I didn't know people could release directly without agreeing. Any chance to somehow rollback that plugin from the update center and talk again whether it should be part of the claim plugin or an independent plugin as now?
>
> Cheers
>

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c1b620c1-8be8-44a3-af6f-c2c79c654176%40googlegroups.com.

[Marcus Jacobsson]

Hi

Seems like I moved a bit too fast on the release button. Sorry about that. The plugin is something we worked on when the claim plugin stoped working a few years ago and then we just decided to continue adding more features to this plugin. We use this internally and thought it would be good to share it with others. I also asked before releasing if I could store it at the Jenkinsci repo like I do with the Lucene plugin.

[Marcus Jacobsson]

There will be a link and a readme from the Github just forgot it when I pushed the code and been away from the Internet since Friday.

[Marcus Jacobsson]

Also the idea with this is not just a volunteer, as that is just a simple part of this plugin. We wanted to create something more to handle the red builds. There are still bugs I need to fix but I was about to update our production server so I wanted to update this at the same time so I got a bit trigger happy.

I started looking at adding new features for the claim plugin in 2011-2012 (think this was when we migrated to Jenkins) but as I found that it was easier for us to just start over as it was not much done back then (I checked it out from SVN and could not even build it). The plugin did not do much back then and we wanted to make a few changes so I started from scratch. Back then it took me less time then to try to get the claim plugin to compile and work. Also this gave me the freedom to build it from ground up as I wanted it. We've changed a few things along the way and we are now looking at expanding the plugin even more and see what we can do to make it easier to handle the red builds internally. As I developed it in house I could also break capability a few times without affecting anyone else but now I feel that I don't need to do that anymore so I was hoping to push it out to the community.

Some things that we wanted to as part of a red build process (bad word, I know)

* exposing data to the API so it can be used to create reports outside of Jenkins

* Add the possibility to push issues from other plugins so people could volunteer to fix specific issues instead of entire builds

* We also found it useful to volunteer teams as well as people as most of the time this gets problems solved faster and people don't feel so targeted.

* Build failure report for less technical persons to get a better view of the big picture (and yes, noticed that I broke it just before release)

For me I just thought it would be nice to give back a little more to the community but we can continue to use this as an in house plugin. Even if I would prefer to not continue to keep it in house only. We have made some stuff that could (or could not) be useful to others and I thought this was a place to start as this was something we had made standalone from the rest of the code that I can not share.

[Baptiste Mathus]

Well... All this is cool, but this is a pity you didn't really try to contribute to the Claim plugin.

And the fact you released from your repo without waiting for feedback is not great. It's taking advantages on current permission system openness (or flaw...)...

We use the claim plugin here and it suits our needs pretty well (~750 jobs). It's even integrated with some "wall" plugins like Radiator... 

And it currently has 4000+ installs, which somehow means it works at least for some people.

Since a few version, the Claim plugin also lets you choose someone else as "claimer".  Last release is not so old, from 05/2015.

Sure, it's sometimes "easier to start over" but in the end it can also lead to more complexity for users... Many plugins that do things, close, but one has A, and another has A' + B, and you want A + B... 

For the current case, I'm not seeing clearly why the features you're talking about could not have been tried to be integrated into the Claim one.

IMO that would have been cool to try and merge those so that users have one clearly identified plugin to "take responsibility for failed builds". 

-- Baptiste

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/046abe80-ba10-483a-acbc-0770c076bb6d%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Marcus Jacobsson]

I agree i general with what you say, but for me now it comes down to time and I don't have so much time to spend on this issue. If you feel that the attention-plugin is so extremely bad (yes I agree on the violation) then remove it. We can still use it in house and I'll see if I ever have time to merge it over to claim or if someone else does it. 

Was thinking more a major security flaw of the plugins and I'm starting to think that perhaps we need to stop using the official plugin repository all together. Going to see if there is a post about it or I will write something to KK and hope I'm wrong in my findings :/

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/bMXeWrOyEN4/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4HbiYYf3qXEP3bW9xzFOq%3DQvrB%3Dp-NG7%3DDPWE6QGjo0w%40mail.gmail.com.