Renaming credentials classes

[Carlos Sanchez]

Hi 

Trying to get this PR to work on upgrades 

https://github.com/jenkinsci/kubernetes-plugin/pull/268/files#diff-14316beac1f1489a56a52e21cf8e0ee6R506 

but none of the XSTREAM2.addCompatibilityAlias options listed in https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility seem to work, the credentials are never deserialized

Any suggestions?

[Robert Sandell]

System credentials seems to be using Jenkins.XSTREAM2 at least

https://github.com/jenkinsci/credentials-plugin/blob/master/src/main/java/com/cloudbees/plugins/credentials/SystemCredentialsProvider.java#L126 

User credentials is "just" stored in a user's properties

https://github.com/jenkinsci/credentials-plugin/blob/master/src/main/java/com/cloudbees/plugins/credentials/UserCredentialsProvider.java#L463

The default store implementation delegates to the store's context

https://github.com/jenkinsci/credentials-plugin/blob/master/src/main/java/com/cloudbees/plugins/credentials/CredentialsStore.java#L573

So you seem to be using the correct XStream instances.

/B

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALHFn6Mo4zFSfMTi%2Bt%2BQQssS4%2B3Zd6Bstk3qtbvcBAQoq-7OOA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

Robert Sandell

Software Engineer

CloudBees, Inc.

E: rsan...@cloudbees.com

Twitter: robert_sandell

[Carlos Sanchez]

It's all good now, had to upgrade the credentials plugin to a version that actually used Jenkins.XSTREAM2

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALzHZS3PP_v7Q9sZC1JPZOR%2B2N%3D-jet293vD6ACb_rh0ob6ZFA%40mail.gmail.com.