default container in Kubernetes plugin

[Rick]

When I configure a pod template with java container. Then run a shell script in pipeline, it will cause an error that can't find command java. So I must specify the container as java first.

I suggest that the java container should be the default container instead of jnlp. Any feedback is thankful, welcome to discuss.

[Carlos Sanchez]

the problem is how to know when you want a container be a default, you would need to pass it as an option in the pod template definition

On Tue, Aug 21, 2018 at 12:59 AM Rick <linux...@gmail.com> wrote:

When I configure a pod template with java container. Then run a shell script in pipeline, it will cause an error that can't find command java. So I must specify the container as java first.

I suggest that the java container should be the default container instead of jnlp. Any feedback is thankful, welcome to discuss.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/15e65662-377e-41d3-8ee9-9177c8a044e1%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[arch]

Yes, I get your point. So I suggest offer a UI option, and let end users make choice.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALHFn6PcDHb6mD5S8PE069z141h_MFi1ncLdhWrdxb73okLMsQ%40mail.gmail.com.

[Carlos Sanchez]

sounds good to me

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMM7nTGws%2Bjh%2BZVuxEY4rU4sY8q%3DW41nTWcxUJnBq9CuTM3G3Q%40mail.gmail.com.

[arch]

ok, do I need create a ticket in https://issues.jenkins-ci.org/secure/Dashboard.jspa first?

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CALHFn6NncdK-%3DNUXQmbNb4CJ6UVu%2BquBb%2B20XoFLBTUiACAbJQ%40mail.gmail.com.

[Carlos Sanchez]

You can submit a PR. Opening a ticket won't help much as I won't have time to implement it

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMM7nTG%2BtupG5mWpJ%2Bme%2BNECx0s%3DO%2BKaj9Se-5v2dxipru-Y6Q%40mail.gmail.com.

[Daniel Ferreira]

Hello, the ticket is already created here: https://issues.jenkins.io/browse/JENKINS-64778

I want to implement it, but need some guidance and ideas ... please :)

After some debugging and reading the code, I found that, when calling

the plugin using label like "agent { label 'ubuntu-18-04' } ", I cannot reuse

the existing "defaultContainer" feature that is available when calling

"agent { kubernetes { ... } } " -- because the implementation fully depends on that
"kubernetes agent" being called.

Instead I was thinking that maybe I need to catch the "steps" calls on
each stage and wrap them in a "ContainerStep" call. But, first, I don't
know if that's possible or how to do it. And, second, this seems like a
huge amount of changes for such a, theoretical, simple feature.

Does anyone has a good idea on how to implement this?

Thanks

[Carlos Sanchez]

Hi, as Jesse mentioned in jira it is not possible because the plugin is not called unless the pipeline explicitly uses a kubernetes agent

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c3fe4168-4ece-4648-810a-2b57b2e52732n%40googlegroups.com.

[Daniel Ferreira]

Ok, sorry to hear that :/

Thank you!