Modernize device-watcher-plugin

97 views
Skip to first unread message

Srikanth Jana

unread,
Apr 7, 2024, 3:58:27 AM4/7/24
to jenkin...@googlegroups.com
Hi,
Iam trying modernize device-watcher-plugin. I added Jenkinsfile to it and raise PR but seems the build is not triggered.
Can some suggest what could be wrong?


Thanks,
Jana

Gavin Mogan

unread,
Apr 7, 2024, 4:38:31 AM4/7/24
to Jenkins Developers
You need write access to the repository to affect the build. Its mostly done for security to prevent builds from doing random things on the public infra...ish

I believe someone with write access can kick off a build for your pr, but I can't remember.

If the plugin is up for adoption you could take over.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAJxAiNBXFy%2BpJTxhjiL6iUGQvuAq7B0n%2BG0QS_XrJ_gXad6umg%40mail.gmail.com.

Bruno Verachten

unread,
Apr 7, 2024, 4:46:06 AM4/7/24
to jenkin...@googlegroups.com
Hi Jana,

Thank you for your pull request.
At the moment, there isn't a Jenkinsfile in the main branch, so a build won't be triggered automatically.
However, a maintainer could manually use your Jenkinsfile to run some initial checks.
The main concern here is security.
We need to ensure that any commands executed are safe and won't cause any harm.

Thanks again for your contribution.

Bruno 

--

Alexander Brandes

unread,
Apr 7, 2024, 4:48:56 AM4/7/24
to jenkin...@googlegroups.com
Given the plugin is up for adoption and there is no active maintainer left, I can only recommend adopting the plugin, to move on with your PR.

~ Alex

Srikanth Jana

unread,
Apr 7, 2024, 9:18:35 AM4/7/24
to jenkin...@googlegroups.com
Thank you all for your suggestions.
I would like to adopt device-watcher-plugin in order to keep it updated.

plugin pull request: https://github.com/jenkinsci/device-watcher-plugin/pull/2
RPU pull request: https://github.com/jenkins-infra/repository-permissions-updater/pull/3871
GitHub username: janasrikanth
Jenkins username: janasrikanth

Thanks,
Jana

Bruno Verachten

unread,
Apr 7, 2024, 9:21:22 AM4/7/24
to jenkin...@googlegroups.com
Fantastic news!
Welcome, Jana.


Srikanth Jana

unread,
Apr 7, 2024, 10:52:00 PM4/7/24
to jenkin...@googlegroups.com
I have added cd yml. can someone please check. 

Thanks,
Jana
Reply all
Reply to author
Forward
0 new messages