PR review request for view column definition updates

6 views
Skip to first unread message

John Patrick

unread,
Feb 25, 2021, 8:18:45 AM2/25/21
to jenkin...@googlegroups.com
Hi,

I've raised two PR's, could some give them a once over to see if they
are on the right lines to add code coverage and total issues for a
project onto a view, without needing to use the configure option.

https://github.com/jenkinsci/job-dsl-plugin/pull/1236
https://github.com/jenkinsci/job-dsl-plugin/pull/1237

If they roughly look correct I'll spend more time looking into fixing
the failing checks/builds/tests.

The bit I can't work out is how to pass optional parameters into
ListViewSpec.groovy but I think I've done ColumnsContext.groovy
correct.

Also I've just put requireMinimumPluginVersion as 1.0.0 as not 100%
sure how to check what min I do need.

Cheers,
John
Reply all
Reply to author
Forward
0 new messages