Revert of breadcrumb bar accessibility change

[Basil Crow]

The Jenkins core maintainers aspire to deliver First Customer Ship (FCS) quality all the time on the main branch. The integration of jenkinsci/jenkins#6912 has destabilized the main branch, resulting in approximately a dozen pull requests to correct issues with the initial integration. When the main branch is not in a stable state, new problems are far more likely to be introduced, a timeless phenomenon described by Jeff Bonwick as the Quality Death Spiral. The overall quality of the delivered software, not any one project, is what matters; therefore, I am proposing a revert of jenkinsci/jenkins#6912.

There is past precedent for this: when the Jetty 10 upgrade was integrated, it destabilized the main branch. It was quickly reverted, then reintegrated later when all known issues had been addressed. The revert of jenkinsci/jenkins#6912 is also intended to be temporary: once the issues caused by the original change are addressed (including JENKINS-70169 and jenkinsci/design-library-plugin#182), we fully hope and expect for it to be reintegrated and delivered in its final form.

[wfoll...@cloudbees.com]

Thanks Basil for the message (I especially liked the references).

I can only +1 your proposal as I was thinking about that in https://github.com/jenkinsci/jenkins/pull/6912#issuecomment-1331141923. Compared to you, I didn't take the time to move the idea further, thanks for the effort.

The change itself is good, it's more about the number of related issues that could be adjusted before, i.e. just a matter of time.

[Tim Jacomb]

Jan has offered a partial reversion instead of a full one 

https://github.com/jenkinsci/jenkins/pull/6912#issuecomment-1331319966

I think that would be more appropriate here given the issue is only with one particular part of it

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8a1ad83d-9216-468e-9f10-a1d2aeb72d14n%40googlegroups.com.

[Basil Crow]

On Fri, Dec 9, 2022 at 9:21 AM Tim Jacomb <timja...@gmail.com> wrote:
> Jan has offered a partial reversion instead of a full one
> https://github.com/jenkinsci/jenkins/pull/6912#issuecomment-1331319966

It is unclear to me whether the partial revert would address both JENKINS-70169 and jenkinsci/design-library-plugin#182. If it addresses both issues and is completed prior to the release of 2.383, this would address my concerns. If a partial revert does not address both issues or if it is not completed prior to the release of 2.383, I would like to proceed with a full revert for 2.383.