Configuration Slicing plugin adoption

[Guy Sheffer]

Hey, here is the information as requested in https://wiki.jenkins.io/pages/viewpage.action?pageId=103088172

• Link to a plugin you want to adopt: https://plugins.jenkins.io/configurationslicing/

• Link(s) to pull requests you want to deliver, if applicable: https://github.com/jenkinsci/configurationslicing-plugin/pull/21
  Note: this is not my code, however I want to build, fix and manage the plugin
  

• Your GitHub username/id (e.g. oleg-nenashev for https://github.com/oleg-nenashev/)
  guysoft
  

• Your Jenkins infrastructure account id. Create your account if you don’t have one: guysoft

Also, I tried to build the plugin and the build fails (test plugin fro the tutorial works fine).

So I want to fix that first.

Build output here if anyone can tell me what is going on: https://pastebin.com/reU1DbAt

Thanks,

[Guy Sheffer]

Hey,
It has been three weeks, and I have a PR ready to get this plugin working again with pipelie.
Should I do anything for the adoption request to be approved?

[Marky Jackson]

This will most likely get handled this week. With the World issues everyone is a little behind.

> On Apr 5, 2020, at 9:02 AM, Guy Sheffer <guy...@gmail.com> wrote:
>

[Oleg Nenashev]

Hi,

My apologies, I totally missed the original request. Yes, World issues were especially tough a few weeks ago :( So thanks a lot for the ping.

There was an ownership transfer request in 2017 by Mikael Gaunin (thread), but there was no activity by Mikael in the repository since that, the `adopt-this-plugin` flag was not removed. Mikael also did not request release permissions here. So I consider this plugin as open for adoption, and I have added Guy Sheffer to the organization and the plugin team. Welcome aboard!

It would definitely great to get the Pipeline support story over the line. I pinged the Code Reviewers team and requested review from myself though my review might take a while and should not be considered as a blocker. I know that Michal Slusarczyk is no longer interested in this area after switching to another job, so I believe this ownerhsip transfer is the way to go. Thanks a lot for stepping up!

Best regards,

Oleg

[Guy Sheffer]

Hey Oleg, thanks for your help!
Its crazy times for all and perfectly understandable. Glad to do some FOSS help meanwhile.

Question - assuming that PR passes review I presume now that I should make sure this repo is also built and published - is there some doc on how to do that? I built it and tested here locally, but I assume you have some kind of CI?

On Sunday, March 15, 2020 at 3:14:58 PM UTC+2, Guy Sheffer wrote:

[Oleg Nenashev]

yes, we have a standard Pipeline for Plugin in Jenkins. I have submitted a pull request for CI here: https://github.com/jenkinsci/configurationslicing-plugin/pull/26. Plugin POM is pretty old, and update to recent versions is needed for advanced checks in our Pipeline

.Also, I would recommend to migrate documentation to GitHub: https://jenkins.io/blog/2019/10/21/plugin-docs-on-github/. Wiki is currently read-only, but it is quite trivial to move the docs with help of tools we provide.

Hopefully it helps,

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7fd5d567-c915-4e22-a1c6-30c2f575279f%40googlegroups.com.

[Guy Sheffer]

Ok,

1. I merged your PR and the reviewed one. Locally it builds for me, but should take a look at where its building in the CI, so I can monitor errors - is there a url?

2. Imported the README in to the git repo, thanks for the link. WIll try clear it up once the code is building and breathing.
3. I guess I am missing still a LICENSE file, there a standard one for Jenkins plugins? Or do I need to go by the original developer?

To unsubscribe from this group and all its topics, send an email to jenkin...@googlegroups.com.

[Gavin Mogan]

> https://wiki.jenkins.io/plugins/servlet/mobile?contentId=57181016#content/view/57181016

(3) Fill the <licenses> section of your POM.
If nothing is defined, your code will be assumed to fall under the MIT license terms.

So I think you can safely continue to make it MIT.

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/170c2c4c-8588-4170-b13b-af22d6561b9d%40googlegroups.com.

[Guy Sheffer]

Thanks Oleg,

To anyone that could help,

I have got as far as updating all the versions by hand, but I am getting some RequireUpperBoundDeps errors. I am not sure what is the methodology to fix this, assuming now all the versions are up to date (which they might not be because I did this manually).

I am really close to making a new release that supports pipeline build and would really appreciate figuring out this hopefully last step, will note that it does build on my local machine.

Thanks,

Guy

https://issues.jenkins-ci.org/browse/JENKINS-61827?filter=21951

On Sunday, March 15, 2020 at 3:14:58 PM UTC+2, Guy Sheffer wrote:

[Tim Jacomb]

Normally you use the Jenkins bom 

https://github.com/jenkinsci/bom

Which includes the common plugins that are depended on, it saves a lot of time when updating versions.

Thanks

Tim

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1afbeb77-9f02-4e44-a8e4-38070deb864b%40googlegroups.com.

[Guy Sheffer]

Hey Tim,
That bom (pom.xml) does not seem to hold most of the plugins used in Configuration Slicing plugin. This is because the plugin slices settings of many plugins. Each plugin is included as a dependency.

You can grasp the size of the list here: https://github.com/jenkinsci/configurationslicing-plugin/blob/devel/pom.xml

Just to make sure, I went over the plugins and made sure, indeed quite a lot, including email-ext, ant, groovy and others are not in that POM.
I am fairly sure I managed to get all the dependencies under gorup-id org.jenkins-ci.plugins up to date. That was easy because the pages are for the plugins are documented. However I cam not sure about other settings. Such as timestamper in org.jvnet.hudson.plugins or plexus-utils in org.codehaus.plexus .

This is the final step to get this plugin to build with the new support for pipeline, so if someone with more experience than me could take a look its likely something simple I overlooked.

Thanks for helping out,

Guy

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Tim Jacomb]

Hi Guy

Timestamper and the two workflow plugins are in bom, I would still recommend adding it,

It looks like timestamper changed its group id at some point

Thanks

Tim

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/adeb4ba8-4c56-47d9-99b5-f499e5a1dc5d%40googlegroups.com.

[Guy Sheffer]

Hey,
Thanks that got me on the right track.
Documented what I was doing here:
https://issues.jenkins-ci.org/browse/JENKINS-61827?focusedCommentId=390808&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-390808

Now mvn validate says the build is successful.

However, it seems not the CI on Jenkins isn't working, the nodes are stuck on AWS with a connection problem.

For Example: https://ci.jenkins.io/computer/EC2%20(aws)%20-%20High%20memory%20ubuntu%2018.04%20%20(i-0785c260cbb2a05fa)/

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/adeb4ba8-4c56-47d9-99b5-f499e5a1dc5d%40googlegroups.com.

[Guy Sheffer]

Ok, now it fails on PrioritySorterSlicer.java:[5,26] package hudson.queueSorter does not exist

How do I import the new org.jenkins-ci.plugins:PrioritySorter?

[Guy Sheffer]

Also, tried reverting back to hudson.queueSorter.

Seems like there are broken methods now:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project configurationslicing: Compilation failure: Compilation failure:
[ERROR] /home/guy/workspace/configurationslicing-plugin/src/main/java/configurationslicing/tools/GradleSlicer.java:[52,52] cannot find symbol
[ERROR]   symbol:   method getDescription()
[ERROR]   location: variable oldGradle of type hudson.plugins.gradle.Gradle
[ERROR] /home/guy/workspace/configurationslicing-plugin/src/main/java/configurationslicing/tools/GradleSlicer.java:[57,50] cannot find symbol
[ERROR]   symbol:   method isFromRootBuildScriptDir()
[ERROR]   location: variable oldGradle of type hudson.plugins.gradle.Gradle
[ERROR] /home/guy/workspace/configurationslicing-plugin/src/main/java/configurationslicing/tools/GroovySlicer.java:[57,20] cannot find symbol
[ERROR]   symbol:   variable DESCRIPTOR
[ERROR]   location: class hudson.plugins.groovy.Groovy
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

[Guy Sheffer]

Ok, compiles now, but I am getting errors on tests on the CI that don't run when I use mvn package:

------------------------------------------------------------------------
12:51:38  [ERROR] Failed to execute goal com.github.spotbugs:spotbugs-maven-plugin:4.0.0:check (spotbugs) on project configurationslicing: failed with 13 bugs and 0 errors

Build: https://ci.jenkins.io/job/Plugins/job/configurationslicing-plugin/job/fix-ci/7/console

[Oleg Nenashev]

So you get static analysis errors from SpotBugs.

It is important to review and clean up them eventually, but for the time being you can set a "spotbugs.failOnError" property to "false" in your pom.xml. In such case SpotBugs will not be failing the build

Hopefully it helps,

Oleg

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/74627f0e-d8c7-4b5d-b653-ad76730fb466%40googlegroups.com.

[Guy Sheffer]

Ok, looks like it finally builds successfully in the CI. Should I tag it and release? Or do we need to do more testing first?

To unsubscribe from this group and all its topics, send an email to jenkin...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/74627f0e-d8c7-4b5d-b653-ad76730fb466%40googlegroups.com.

[Gavin Mogan]

a standard `mvn release:prepare release:perform` will do all the tagging and releasing for you

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0c474f09-ff79-4d93-88e2-b8cde2fac531%40googlegroups.com.

[Guy Sheffer]

Ran that and got this:

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  25.037 s
[INFO] Finished at: 2020-05-22T03:17:54+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on project configurationslicing: You don't have a SNAPSHOT project in the reactor projects list. -> [Help 1]

[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

Am I doing something wrong?

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0c474f09-ff79-4d93-88e2-b8cde2fac531%40googlegroups.com.

[Gavin Mogan]

I suspect you tried to release a snapshot somehow but I don't know enough maven to know from the last message.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7728bf67-24fe-4414-8b91-d15758dc4180%40googlegroups.com.

[Richard Bywater]

(I sent a reply to 5 hours ago but for some reason it hasn't made the list so not sure what's happening - apologies in advance for any future duplication :/)

Your current pom.xml file has a non-SNAPSHOT version in it. When doing a release the process expects (as far as I know) to find a SNAPSHOT version there, and the process then changes that to a non-SNAPSHOT, releases, and then ups the version number to the next SNAPSHOT number.

Richard.

[Guy Sheffer]

Thanks Richard.

Stuck now at:     [ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on project configurationslicing: Failed to deploy artifacts: Could not transfer artifact org.jenkins-ci.plugins:configurationslicing:hpi:1.50 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases/): Transfer failed for https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/configurationslicing/1.50/configurationslicing-1.50.hpi 401 Unauthorized -> [Help 1]

    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:

    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

[INFO] Total time:  01:17 min
[INFO] Finished at: 2020-05-22T14:51:00+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:2.5.3:perform (default-cli) on project configurationslicing: Maven execution failed, exit code: '1' -> [Help 1]

Note1: Also had to set JAVA_HOME because even though javadoc is in my path mvn could not find it.

Note2: Had to set github to use ssh key because https can't be used neither.

[Gavin Mogan]

https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-configurationslicing.yml hasn't been updated since 2018, so I suspect your not listed in there. You need to add your jenkins/ldap account to that list.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/bb238a22-82ec-43ff-836a-ae073ab35c95%40googlegroups.com.

[Richard Bywater]

Your current pom.xml file has a non-SNAPSHOT version in it. When doing a release the process expects (as far as I know) to find a SNAPSHOT version there, and the process then changes that to a non-SNAPSHOT, releases, and then ups the version number to the next SNAPSHOT number.

Richard.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7728bf67-24fe-4414-8b91-d15758dc4180%40googlegroups.com.

[Guy Sheffer]

Ok, think I done that right, logged in to artifactory and all:
https://github.com/jenkins-infra/repository-permissions-updater/pull/1536

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/bb238a22-82ec-43ff-836a-ae073ab35c95%40googlegroups.com.

[Guy Sheffer]

Ok, waiting for someone with permissions to approve this:

https://github.com/jenkins-infra/repository-permissions-updater/pull/1536


On Friday, May 22, 2020 at 8:20:04 PM UTC+3, Gavin Mogan wrote:

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/bb238a22-82ec-43ff-836a-ae073ab35c95%40googlegroups.com.

[Guy Sheffer]

Ok, waiting for someone with permissions to approve this:
https://github.com/jenkins-infra/repository-permissions-updater/pull/1536

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7728bf67-24fe-4414-8b91-d15758dc4180%40googlegroups.com.

[Gavin Mogan]

There's only a couple people that can approve, and its a volunteer organization, its especially slow on weekends because people have family. It'll get done

Gavin

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2a829511-af0c-4e50-a71b-d16f24e90119%40googlegroups.com.

[Oleg Nenashev]

I will review it once I get to the computer. 

BR, Oleg

To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Dus6f31ubRSOge1ao7U1yxEN6OuAYv4JOX8Qtv7PbAnjYw%40mail.gmail.com.

[Guy Sheffer]

Thanks guys, hopefully this would let me fully adopt and maintain the plugin, joining you.

Seems like its approved but I still get an unauthorised message. Do I need to put my artifactory permissions somewhere so mvn picks them up?
Command for reference:

mvn release:prepare release:perform

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2a829511-af0c-4e50-a71b-d16f24e90119%40googlegroups.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jenkin...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Dus6f31ubRSOge1ao7U1yxEN6OuAYv4JOX8Qtv7PbAnjYw%40mail.gmail.com.

[Oleg Nenashev]

https://wiki.jenkins.io/display/JENKINS/Hosting+Plugins#HostingPlugins-Releasingtojenkins-ci.org  provides Maven settings.xml configuration guidelines 

To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1d9712e3-a777-47bb-893e-bea648af6cb4%40googlegroups.com.

[Tim Jacomb]

Also:

https://www.jenkins.io/doc/developer/publishing/releasing/

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLB%3DnVo2TGBw3vwasAexD9Zm1zgoqLTRvznwto-TaFba7Q%40mail.gmail.com.

[Guy Sheffer]

Thanks, the url that tim gave me the right settings to put in to ~/.m2/settings.xml
(Also figuring out that you need to click on your username and NOT on the word "welcome" to reach the profile in artifactory was a little hidden)

I have made the release on Github, and it seems to appear there.
However the Jenkins page seems to still have the old version of the plugin.
How do I update this?: https://plugins.jenkins.io/configurationslicing/

For comparison, new version is here: https://github.com/jenkinsci/configurationslicing-plugin/releases

On Monday, May 25, 2020 at 10:47:48 AM UTC+3, Tim Jacomb wrote:

Also:

https://www.jenkins.io/doc/developer/publishing/releasing/

To unsubscribe from this group and all its topics, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1d9712e3-a777-47bb-893e-bea648af6cb4%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLB%3DnVo2TGBw3vwasAexD9Zm1zgoqLTRvznwto-TaFba7Q%40mail.gmail.com.

[Guy Sheffer]

Note.
I can also see the release in Artifactory:

https://repo.jenkins-ci.org/webapp/#/artifacts/browse/tree/General/releases/org/jenkins-ci/plugins/configurationslicing/1.50

Also its not available on Jenkins plugin manager.

And to recap, can't see it in: https://plugins.jenkins.io/configurationslicing/

Also:

https://www.jenkins.io/doc/developer/publishing/releasing/

To unsubscribe from this topic, visit <a href="https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe" rel="nofollow" target="_blank" onmousedown="this.href='https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe';return true;" onclick="this.href='https://groups.google.com/d/topic/jenkinsci-dev/O2cO3zXuDi0/unsubscribe&#

[Guy Sheffer]

Ok, seems like it took over 24 hours. But the plugin has been released!
So now I can maintain it.

Thanks all for your help an explanations. It takes a while to understand how the CI works.

PRs are welcome now ;)