Proposal: Jenkins Core PR reviewers team

[Oleg Nenashev]

Hi all,

I would like to make a proposal w.r.t the Jenkins Core review process. 

As you may see from the pull requests, currently we have a pretty heavy process which includes multiple reviews, labeling PRs for automatic changelog drafts, and so on. This process helps us to maintain high quality of weekly releases. Over the last year we have had many contributors who helped to review core pull requests on a regular basis. These contributors do not have WRITE permission in the repo, and they had no way no assign labels, request reviews, re-trigger CI, and so on. Only jenkinsci/Core members have permission to do that, and it is a serious overhead since we do not have many active core maintainers in jenkinsci/Core looking at PRs.

Few months ago GitHub introduced a new TRIAGE permission for the repository which basically gives permissions to manage issues/pull requests without being actually able to merge them. IMO it gives us a great opportunity to expand the core reviewers bandwidth and at the same time to offer a path for onboarding new core maintainers (contributor => Triage => Write permissions).

What I suggest to do:

• Introduce a new jenkinsci/core-pr-reviewers team
• Grant the team TRIAGE permission in  https://github.com/jenkinsci/jenkins
• Maybe?: Add CODEOWNERS to GitHub to automatically request reviews from the new team for new pull requests
• Invite contributors who regularly review Jenkins core pull requests: alecharp, varyvol, MarkEWaite, res0nance, jvz, MRamonLeon, halkeye (sorry if I missed anyone!)

If the approach works well, later we can expand it to components which are a part of the Jenkins core (libraries, modules, etc.).

What do you think?

Best regards,

Oleg

[Marky Jackson]

+1 from me

{     
    "regards" : {
         "name" : “marky”,
         "phone" : "+1 (408) 464 2965”,
         "email" : “marky.r...@gmail.com",
         "team" : “jackson5“,

 “role” : “software engineer"
     }
 }

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLAypnU_vnh3GB3_DVDD5R2vZePjzvsuGtpvXEQTsyOrjQ%40mail.gmail.com.

[Tim Jacomb]

Sounds good to me

[Mark Waite]

I like the idea very much.  GitHub triage looks like a really nice addition without granting more permissions than necessary.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifMF%2B8X%3D8wG4Pbh4Q8cguSzx2j-RmtUmORmw10MsB7aLw%40mail.gmail.com.

--

Thanks!

Mark Waite

[Matt Sicker]

I like this idea, too.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtHVQq%2BdciSsHU0w5jVhrJ%3DYemzUqeERV7-6sCRYASfyuQ%40mail.gmail.com.



--
Matt Sicker
Senior Software Engineer, CloudBees

[Daniel Beck]

+1

[Oleg Nenashev]

Looks like we have a consensus here. I will proceed with the change tomorrow if no negative feedback

[Baptiste Mathus]

+1 great idea, and feature indeed.

Thanks a lot Oleg

Le jeu. 19 sept. 2019 à 23:14, Oleg Nenashev <o.v.ne...@gmail.com> a écrit :

Looks like we have a consensus here. I will proceed with the change tomorrow if no negative feedback

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a5fe6214-7fb5-44a2-8ec2-9b53c6dd629c%40googlegroups.com.

[Tim Jacomb]

I would be interested in joining this team

[Oleg Nenashev]

Thanks to all for the feedback!

I have created the team: https://github.com/orgs/jenkinsci/teams/core-pr-reviewers

Please let me know if it works for you.

Best regards,

Oleg

[Raihaan Shouhell]

I'd be keen on this +1

[Olblak]

\o/

---

-> gpg --keyserver keys.gnupg.net --recv-key 52210D3D

---

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com.

[Gavin]

Doesnt look like I'm on the team afterall

I think this is a great idea.

I'm taking night school so I don't know how much I can help, but I will at least be up.gor helping reviewing during hacktober at the very least.

Gavin

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3f07d55f-dc0e-4c1d-8fee-3a8016ef7d03%40www.fastmail.com.

[Oleg Nenashev]

Thanks Raihaan and Gavin!

I did not add people to the group without explicit consent, but I have added you taking the feedback here.

So we have officially added 9 more reviewers to the Core, and it at least doubles our review capacity there.

Thanks all!

P.S: We also have https://github.com/orgs/jenkinsci/teams/code-reviewers/ for general review pings and https://github.com/orgs/jenkinsci/teams/hacktoberfest/ for the Hacktoberfest reviews.

If someone is interested, please feel free to send a join request to these teams.

Best regards,

Oleg

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/191d48e2-1898-4266-8c39-0b2465bef2d9%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Marky Jackson]

Hello all!

I would like to be added to this team if possible.

[Oleg Nenashev]

Hi Marky,

Thanks for the interest! I am definitely +1 taking all your contributions in other areas.

One potential concern is that you have not contributed much to the Jenkins core yet, and for a reviewer.it would be useful to have some experience with the review process from another side.

We do not have it in the requirements defined above, would be nice to hear what others say about it.

BR, Oleg

[Daniel Beck]

Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

Right now, https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93&q=is%3Apr+involves%3Amarkyjackson-taulia looks a little empty.

[Marky Jackson]

I love a good challenge.

Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date.

Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck <db...@cloudbees.com> wrote:



Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

Right now, https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93&q=is%3Apr+involves%3Amarkyjackson-taulia looks a little empty.

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

[Gavin Mogan]

Sorry ya'll, with the new approved core developers, I'm going to step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable with core/java, but i'm still up for helping out randomly where i can, especially for plugins, and web/javascript stuff. I'll lurk randomly elsewhere.

(this leaves room for Marky though)

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.

[Marky Jackson]

I am happy to be included and thank you Gavin

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.

[Marky Jackson]

I wanted to circle back around on this

On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:

I am happy to be included and thank you Gavin

On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <jenkinsci-dev@googlegroups.com> wrote:

Sorry ya'll, with the new approved core developers, I'm going to step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable with core/java, but i'm still up for helping out randomly where i can, especially for plugins, and web/javascript stuff. I'll lurk randomly elsewhere.

(this leaves room for Marky though)

On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson <marky.r...@gmail.com> wrote:

I love a good challenge.

Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date.

Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck <db...@cloudbees.com> wrote:



Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

Right now, https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93&q=is%3Apr+involves%3Amarkyjackson-taulia looks a little empty.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

[Oleg Nenashev]

Hi Marky. As we discussed in PM, I have an action item to follow-up on that. Sorry that I cannot provide the response time you expect, but I was mostly off over past days (sick leave). I will do my best to propose formal criteria for newcomer core PR reviewers next week. The informal criteria before was several months of activities in the core and a number of substantial contributions.

If others vote in favor of adding Marky to the Core PR Reviewers, I am +1 w.r.t that.

BR, Oleg

On Sun, Feb 16, 2020, 19:10 Marky Jackson <marky.r...@gmail.com> wrote:

I wanted to circle back around on this

On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:

I am happy to be included and thank you Gavin

On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <jenkin...@googlegroups.com> wrote:

Sorry ya'll, with the new approved core developers, I'm going to step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable with core/java, but i'm still up for helping out randomly where i can, especially for plugins, and web/javascript stuff. I'll lurk randomly elsewhere.

(this leaves room for Marky though)

On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson <marky.r...@gmail.com> wrote:

I love a good challenge.

Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date.

Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck <db...@cloudbees.com> wrote:



Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

Right now, https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93&q=is%3Apr+involves%3Amarkyjackson-taulia looks a little empty.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com.

[Marky Jackson]

Thank you kindly Oleg, please do get well. Sending healing thoughts.

On Feb 16, 2020, at 10:30 AM, Oleg Nenashev <o.v.ne...@gmail.com> wrote:



To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDFMapzJLRGneO1M7aD1ontMYFF-fUDH93Gspp5VfnzBA%40mail.gmail.com.

[Francisco Javier Fernandez]

Oleg, Marky, +1 from my side. Any help is always more than welcome!

El domingo, 16 de febrero de 2020, 19:59:06 (UTC+1), Marky Jackson escribió:

Thank you kindly Oleg, please do get well. Sending healing thoughts.

On Feb 16, 2020, at 10:30 AM, Oleg Nenashev <o.v.n...@gmail.com> wrote:



Hi Marky. As we discussed in PM, I have an action item to follow-up on that. Sorry that I cannot provide the response time you expect, but I was mostly off over past days (sick leave). I will do my best to propose formal criteria for newcomer core PR reviewers next week. The informal criteria before was several months of activities in the core and a number of substantial contributions.

If others vote in favor of adding Marky to the Core PR Reviewers, I am +1 w.r.t that.

BR, Oleg

On Sun, Feb 16, 2020, 19:10 Marky Jackson <marky....@gmail.com> wrote:

I wanted to circle back around on this

On Thursday, February 13, 2020 at 4:48:44 PM UTC-8, Marky Jackson wrote:

I am happy to be included and thank you Gavin

On Feb 13, 2020, at 4:46 PM, 'Gavin Mogan' via Jenkins Developers <jenkin...@googlegroups.com> wrote:

Sorry ya'll, with the new approved core developers, I'm going to step down as a core-pr-reviewer. Its a little overwhelming to me, and I'm not comfortable with core/java, but i'm still up for helping out randomly where i can, especially for plugins, and web/javascript stuff. I'll lurk randomly elsewhere.

(this leaves room for Marky though)

On Sun, Feb 2, 2020 at 1:04 AM Marky Jackson <marky....@gmail.com> wrote:

I love a good challenge.

Let’s hold off on this request and I will get some general reviews under my belt for some time and reapply at a later date.

Thanks kindly for the consideration.

On Feb 1, 2020, at 11:53 PM, Daniel Beck <db...@cloudbees.com> wrote:



Extrapolating from the introduction of this team would mean people should first be regular core PR reviewers. There's no process barrier to just start doing that.

Right now, https://github.com/jenkinsci/jenkins/pulls?utf8=%E2%9C%93&q=is%3Apr+involves%3Amarkyjackson-taulia looks a little empty.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLNMKCiby_hamQ%2BpUBZyVZBzyTphw8LiTE1Y1xsbz9EOw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/6001CF17-C6EB-4F86-ABF0-3754580C0BE3%40gmail.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DusuUMUQuMqXYwbQ6vf%2BqaXgNzT9cg_5M9QYJzh7c%3DVbWg%40mail.gmail.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/46d147a4-3f81-4eea-93ad-3a355329eb28%40googlegroups.com.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Tim Jacomb]

+1 from my side

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/b2d59f93-4eb5-44fa-a22f-887bbd4b4fff%40googlegroups.com.

[Baptiste Mathus]

+1 to add Marky too.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidZpfjF4z6XTF7wEkmGZ%2BnU_%2BZ68FFMwtGnjbcmBieeJA%40mail.gmail.com.

[Matt Sicker]

+1 from me as well!

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3gQggh9Xuq7meBPtwhcWQnJ-xx3AN7%2BzsjHKTpn%3DEYhA%40mail.gmail.com.

[Oleg Nenashev]

I will add Marky to the reviewers team on Monday if there is no negative feedback provided in this thread. I have an action item to document the processes, but I am behind the schedule on that (and pretty much everything else, sorry).

One of the major TODO items for me is to clarify what "substantial contributions" mean in the Core PR previewer prerequisites, but I believe that we should focus on contributors, not on bureaucracy.

>>> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/b2d59f93-4eb5-44fa-a22f-887bbd4b4fff%40googlegroups.com.
>>
>> --
>> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

>> To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

>> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BidZpfjF4z6XTF7wEkmGZ%2BnU_%2BZ68FFMwtGnjbcmBieeJA%40mail.gmail.com.
>
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Marky Jackson]

Thank you Oleg and everyone else for the +1

{     
    "regards" : {
         "name" : “marky”,
         "phone" : "+1 (408) 464 2965”,
         "email" : “marky.r...@gmail.com",
         "team" : “jackson5“,

 “role” : “software engineer"
     }
 }

On Feb 22, 2020, at 11:26 AM, Oleg Nenashev <o.v.ne...@gmail.com> wrote:



To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/81bf32c9-ed19-4cd9-a8a9-1ce6a48d3d1e%40googlegroups.com.

[Oleg Nenashev]

Done, welcome Marky aboard!

On Monday, February 24, 2020 at 4:39:30 AM UTC+1, Marky Jackson wrote:

Thank you Oleg and everyone else for the +1

{     
    "regards" : {
         "name" : “marky”,
         "phone" : "+1 (408) 464 2965”,

         "email" : “marky....@gmail.com",
         "team" : “jackson5“,

 “role” : “software engineer"
     }
 }

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/81bf32c9-ed19-4cd9-a8a9-1ce6a48d3d1e%40googlegroups.com.

[Basil Crow]

I'm interested in joining the Core PR reviewers team as well.

[Mark Waite]

+1 from me that Basil becomes part of the core PR reviewers team.

On Thu, Apr 15, 2021 at 11:54 AM Basil Crow <m...@basilcrow.com> wrote:

I'm interested in joining the Core PR reviewers team as well.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjrnHZmDg-JmtP%2B3fO%3Df1w_uNRFevrOy9dHfsq29n0xDnA%40mail.gmail.com.

[Tim Jacomb]

+1

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtFoN%3DsiPzRHcLHJyJbs1xBqnFVAkfQONGcwcE4a90hGhw%40mail.gmail.com.

[Oleg Nenashev]

+1. I will grant Basil permissions tomorrow if no negative feedback. And again, thanks to Basil for all the contributions to Jenkins!

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/0sdrcSOQW64/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BifbZ_nDppzESg7VQSzM3-HKzk96V%2B7WYDP5-LFwoHZhRg%40mail.gmail.com.

[Oleg Nenashev]

Welcome aboard Basil! I have updated the permissions and added you to the Jenkins Core PR reviewers team.

Just for the record, the Pull request review guidelines and other maintainer docs are available here. We are always interested in onboarding more core maintainers, and everyone is welcome to participate.

Best regards,

Oleg Nenashev

[Alexander Brandes]

Hey everyone,

late reply but I would be interested in joining as well.

Since I joined the release team a few months ago to take care of the last point release and the upcoming 2.346 LTS release, I moderate a bunch of core PRs by applying labels, fixing up changelog entries, PR titles or spinning up ATH and bom runs, if needed; granted by the permissions as release team member, besides the typical reviews for PRs.
Aside the LTS PRs, I merged a few minor ones in the past fulfilling the requirements to be eligible for a merge too, to facilitate a backport into LTS or to unblock and prevent a delay of a weekly release e.g.

Kind regards
Alex

[Tim Jacomb]

+1 although I'd also be +1 on core maintainer status as well for Alex.

He's helped out a lot recently

Cheers

Tim

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/b3c16811-4f63-4550-99ed-02179c2e1b5en%40googlegroups.com.

[Mark Waite]

+1 from me as well.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bidk-comtFzXQA4o640QaSL2kd0gTEXqr%3DD8Su76UoERbg%40mail.gmail.com.

[Alexander Brandes]

Follow up to my initial message, I would like to join both teams, the core maintainer and reviewer one, where the latter would only be for review requests, as I'm already inheriting these permissions as release team member.

Cheers

[Damien Duportal]

+1 for me as well (with the hat of infra officer)

[Basil Crow]

On Mon, Jun 20, 2022 at 2:19 AM Alexander Brandes <mc.ca...@gmail.com> wrote:
> where the latter would only be for review requests

+1 from me that Alex becomes part of the "core PR reviewers" team.

> I'm already inheriting these permissions as release team member.

Yes, for "release activities, e.g. backporting, build fixes" (per this message).

[Tim Jacomb]

Taking the 4 +1s, I've added Alex to the Core PR reviewers team.

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpP1hWXbf%2BksiOZWffwKe_BWDrF9k4DWd_krfDffrBfGA%40mail.gmail.com.