Newest base pom with really old plugin

22 views
Skip to first unread message

Gavin Mogan

unread,
Dec 19, 2019, 4:17:37 AM12/19/19
to jenkin...@googlegroups.com
Hey all,

I wanted to do some cleanup, do a few fixes, and release a new version of a really old plugin of mine, so I could move the docs from wiki to github.

I thought it would be a good idea to update to latest base pom cause ... its better.

So it was originally targeting 1.455 with java 5 (which i now think should have been 7). Updating it to use 7, I still fail to build due to enforcer errors

[INFO] Restricted to JDK 1.7 yet org.codehaus.mojo:animal-sniffer-annotations:jar:1.18:provided contains org/codehaus/mojo/animal_sniffer/IgnoreJRERequirement.class targeted to JDK 8
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
Found Banned Dependency: org.codehaus.mojo:animal-sniffer-annotations:jar:1.18

[WARNING] Rule 3: org.apache.maven.plugins.enforcer.BannedDependencies failed with message:
Found Banned Dependency: org.sonatype.sisu:sisu-guice:jar:3.1.0


Both of these come from the super early jenkins core. Is there a way to ignore this, or a good recommended core version to use? or can I just bump things?

Gavin

Ullrich Hafner

unread,
Dec 19, 2019, 4:22:15 AM12/19/19
to Jenkins Developers
We are „already“ targeting Java 8 now. I am using 2.138.4 for all my plugins but this is already very conservative but might be a good choice for your plugin as well. I think it is simpler to bump the version, trying to fix the errors will be more cumbersome. 

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_Dutr1LxFDugY1vKwGCE_m5chB60QU1oeWgwVr4byFmx4bA%40mail.gmail.com.

Mark Waite

unread,
Dec 19, 2019, 4:26:58 AM12/19/19
to jenkinsci-dev
I think you'll have better results if you switch to java 8 and Jenkins 2.60 or newer as base version. That is the first LTS that required Java 8, if I recall correctly. 

Switch the major version of the plugin at release and call it good. 

--

Gavin Mogan

unread,
Dec 19, 2019, 4:32:11 AM12/19/19
to jenkin...@googlegroups.com
Awesome, 2.60 builds though tests fail in good ways I need to fix

Can 2.60 support pipeline symbols? I'm thinking I might want to expand it a bit so you can trigger browser notifications inside of pipelines.

Gavin


To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtEjjSWuXnYOZS0HUdDDVm79sZXqN0DpVRDKgFUhNLz%3DPQ%40mail.gmail.com.

Baptiste Mathus

unread,
Dec 19, 2019, 5:05:37 AM12/19/19
to jenkin...@googlegroups.com
Bump bump bump, yes.

Yes, AFAIR for the Symbol annotation, but in some cases you may depend on recent versions of plugins.

_Anyway_ then, the build will automatically fail if any plugin version necessitate a more recent of the Core. 
In such case, I would strongly recommend you simply bump to the request recent version instead of playing around and fighting plugin version compatibility.
Life is too short to keep plugins on very old Jenkins versions IMO. Even 2.60.x is quite old now (August 2017 already)
Anyway again, many times we have discussed that companies averse to updating Jenkins Core also are very likely averse to upgrading plugin themselves...

Many of us have done plugin parent pom updates a few times, so do not hesitate to ask for help/review as needed Gavin.

Hope this helps.


To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAG%3D_DutxUTtdP-G36ug9jQy3yD6scw7BhqgYZjLdK%2B1TY6kgoQ%40mail.gmail.com.

Mark Waite

unread,
Dec 19, 2019, 5:33:11 AM12/19/19
to jenkinsci-dev
On Thu, Dec 19, 2019 at 2:32 AM 'Gavin Mogan' via Jenkins Developers <jenkin...@googlegroups.com> wrote:
Awesome, 2.60 builds though tests fail in good ways I need to fix

Can 2.60 support pipeline symbols? I'm thinking I might want to expand it a bit so you can trigger browser notifications inside of pipelines.


I'm confident it can, since that was the version that git plugin 4.0.0 required for a large portion of its 18 month beta cycle.

I'd take Uli's recommendation of 2.138 as an even better recommendation.  It brings you into the set of releases that have even more helpful things available.  That is the base version for the git plugin 4.0.0 and feels like a nice stable point until the next major "leap".  I expect the next major leap after 2.138 will be either 2.190 or 2.204.  That next major leap is probably a year or two away for things that I maintain.

I also agree with Baptiste that administrators running very old Jenkins versions are much less likely to update to a new plugin release.
 

Tim Jacomb

unread,
Dec 19, 2019, 6:13:29 AM12/19/19
to jenkin...@googlegroups.com
I would highly recommend just picking a version that the plugin bom supports, it makes dependency management far easier

Tim Jacomb

unread,
Dec 19, 2019, 6:37:08 AM12/19/19
to jenkin...@googlegroups.com
The minimum recommended version in the docs is 2.138.x 
Reply all
Reply to author
Forward
0 new messages