Regarding allowing groovy build step to change the promotion icon during promotion process.

[vimil saju]

Hi,

Currently the promoted builds plugin allows you to configure the promotion icon in the configuration section of the promotion process.

However once configured, it cannot be modified programmatically by a groovy promotion build step for a specific promotion. This is because the promotion icon is stored at the promotion process level instead of the promotion level.

I would like to enhance the promoted builds plugin so as to store the promotion icon at the promotion level and expose a method in the promotion class to change the icon. This way I can add a groovy step to the promotion process that can change the icon programmatically for that specific promotion without affecting other promotions.

Let me know if there are any objections to this enhancement, otherwise I can provide a patch for this.

Thanks
Vimil

[Oleg Nenashev]

Hi Vimil,

If you create a thread about a plugin, please provide the background and CC plugin maintainers. Otherwise the thread may confuse people.

Background (my vision)...

• Vimil has already created a patch for it: https://github.com/jenkinsci/promoted-builds-plugin/pull/58
• This patch has been merged into the master branch without waiting for review
  
• When Damien Nozay transferred the ownership to me, I've reviewed the master branch and discovered this patch
• In the patch I've discovered there were serious issues IMHO
• Since the patch has not been released yet & has not been reviewed by anyone, I decided to revert it
• I proposed to update the implementation according to comments and to create a new PR
  
• After a short discussion, Vimil dissapeared 

I'd be happy to continue the discussion of this improvement. If I understand correctly, the ball is on your side.

Best regards,

Oleg Nenashev

вторник, 6 октября 2015 г., 7:37:04 UTC+3 пользователь vimil написал:

[vimil saju]

Oleg,

I had to work on other work related issues. which is why I could not respond earlier.

I understand that you would like to have a separate demotion process similar to the promotion process.

I was thinking that demotion process is not necessary since the plugin already allows to define more than one process, and it is already possible to give custom names to the promotion processes. I could add another promotion process and name it 'demote build' or something similar. (As an aside I think the 'approval' would have been a better term to use than 'promotion', because then we can have approval process to 'promote builds' and another approval process to 'demote builds')

What I'd like to have is the ability for a groovy build step of a promotion process to be able to change the promotion icon of the currently running promotion programmatically.

This is why I suggested that the icon value should be stored at the promotion level instead of promotion process level.

Let me know if you have a different idea about this.

Thanks

Vimil

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/feb01a92-8525-4f67-887e-823777f2b8af%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.