ec2-plugin commit rights request

[Mateusz Zając]

Dear Jenkins Developers,

I am observing for the last month how much life is left in ec2-plugin. And I can say that probably beside interested parties for some PRs there is none left. I did not see any activity on the bug I posted in Jira and I did not see any activity on pull requests for a month now.

I am currently waiting for a PR to get reviewed and merged (https://github.com/jenkinsci/ec2-plugin/pull/186). Everything is written there and link to Jira is also submitted there.

I want to get involved more seriously in developing EC2-plugin as I can invest time in it. Besides that being a maintainer active supporter of Jenkins Open Source project would be a cherry on a great pie of my software engineering experience which I would be very proud of.

Also I want to ask you to for review of the PR I have created. Currently I think that I did not set new version in pom.xml for the plugin and I am supposed to so one note from me to take a look on that subject. There also couple of other notes I would like to discuss actively with some Jenkins veterans like changing documentation showed in pop ups for configuration fields which I think should be in place. Currently PR is fixing the issue in most minimal amendment possible.

My Details:

Github Credentials: zajacmp3

Name: Mateusz Zając

Pull Request: https://github.com/jenkinsci/ec2-plugin/pull/186

Repository of the plugin: https://github.com/jenkinsci/ec2-plugin

Regards,

Mateusz Zając

[Francis Upton]

I have just reviewed the pull request and found some minor issues. I will merge it when they are corrected. Sorry for my delay in reviewing it. I'm very part time with this however I have been consistently working one it for some years now. 

Sent from my iPhone

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3655330a-c3a6-4966-8966-9dd950e52dc5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Francis Upton]

Let me elaborate in my reply just a bit, see my embedded comments.

tl;dr - I don't support giving Mateusz commit rights.

On Thu, Mar 31, 2016 at 2:26 PM, Francis Upton <fran...@gmail.com> wrote:

I have just reviewed the pull request and found some minor issues. I will merge it when they are corrected. Sorry for my delay in reviewing it. I'm very part time with this however I have been consistently working one it for some years now. 

Sent from my iPhone

On Mar 31, 2016, at 01:06, Mateusz Zając <deejay...@gmail.com> wrote:

Dear Jenkins Developers,

I am observing for the last month how much life is left in ec2-plugin. And I can say that probably beside interested parties for some PRs there is none left. I did not see any activity on the bug I posted in Jira and I did not see any activity on pull requests for a month now.

I would have appreciated a direct email rather than posting this on the list. There have been times where I have been away from the work for periods of a month of longer, but since 2013 I have been consistently maintaining this plugin. If you review the logs you will find that I tend to spend a few days at a time going through everything and then leaving it for a long time. I do note in this case I should have been more proactive in resolving the provisioning change caused by release 1.31, and will take care of that very soon.

I am currently waiting for a PR to get reviewed and merged (https://github.com/jenkinsci/ec2-plugin/pull/186). Everything is written there and link to Jira is also submitted there.

I have reviewed this pull request, which you submitted 9 days ago, and found a few obvious problems with it in terms of clean coding (which I mentioned in the pull request). At this point, given the quality of what you have submitted, I don't think you are ready to be a committer in this project. I know Jenkins has a very low standard for allowing committers, feeling that other committers can clean up mistakes, but for this plugin, I would prefer that you demonstrate contributions with high quality before having the right to commit code. I don't have the time to clean up people's poor quality contributions.

I want to get involved more seriously in developing EC2-plugin as I can invest time in it. Besides that being a maintainer active supporter of Jenkins Open Source project would be a cherry on a great pie of my software engineering experience which I would be very proud of.

Also I want to ask you to for review of the PR I have created. Currently I think that I did not set new version in pom.xml for the plugin and I am supposed to so one note from me to take a look on that subject. There also couple of other notes I would like to discuss actively with some Jenkins veterans like changing documentation showed in pop ups for configuration fields which I think should be in place. Currently PR is fixing the issue in most minimal amendment possible.

I would be happy to discuss any issues with you, feel free to email me offline. As far as the version in the pom.xml; this is described in the plugin release process on the Jenkins Wiki. 

My Details:

Github Credentials: zajacmp3

Name: Mateusz Zając

Pull Request: https://github.com/jenkinsci/ec2-plugin/pull/186

Repository of the plugin: https://github.com/jenkinsci/ec2-plugin

Regards,

Mateusz Zając

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3655330a-c3a6-4966-8966-9dd950e52dc5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Cell +1 510 432 1589 (when in US)

Cell +33 7 83 72 48 66 (when in Europe)