Plugin Hosting Request - build-flow-json-parser-extension

[Jonathan Niesen]

Plugin Repo: https://github.com/jniesen/build-flow-json-parser-extension

Plugin Name: build-flow-json-parser-extension-plugin

Jenkins-Ci.org User: jniesen

Description: A Jenkins plugin that extends the BuildFlow DSL. It gives you the abilit to parse JSON objects in your build script.

[James Nord]

I think it would it make more sense to add this to the build flow extensions plugin rather than create a new plugin
--
Sent from my phone.
Please excuse my brevity and any auto correct issues.

[Jonathan Niesen]

I'll have to reread the info about that plugin. I was under the impression that individual build flow extensions would be packaged in their own plugins.

[Jonathan Niesen]

If I'm understanding correctly, the instruction under the Implementing Extension heading on the build flow plugin page mentions defining the extension in your own plugin.

https://wiki.jenkins-ci.org/display/JENKINS/Build+Flow+Plugin

I re-read your initial comment, are you saying this should be part of the actual Build Flow plugin itself rather than an extension? I hadn't thought about that.

[James Nord]

basically the build flow plugin is just concerned with the build flow.  If you want to define custom extensions they should not be in the build flow repository.

I was referring instead to adding them to the build flow extensions plugin[1]

A plugin can define more than one extension - you do not need a 1:1 mapping of plugin <-> extension.

/James

[1] https://wiki.jenkins-ci.org/display/JENKINS/Build+Flow+Extensions+Plugin

[Daniel Beck]

On 08.07.2015, at 14:10, James Nord <james...@gmail.com> wrote:

> I was referring instead to adding them to the build flow extensions plugin[1]
>
> A plugin can define more than one extension - you do not need a 1:1 mapping of plugin <-> extension.
>

Some parts of the doc call it the 'concurrent extensions plugin', so it doesn't look like it's for any new BF extensions.

[James Nord]

> I was referring instead to adding them to the build flow extensions plugin[1]
>
> A plugin can define more than one extension - you do not need a 1:1 mapping of plugin <-> extension.
>

Some parts of the doc call it the 'concurrent extensions plugin', so it doesn't look like it's for any new BF extensions.

Legacy.  I first implemented the concurrent part.  Then I added an extra bit that had nothing to do with concurrency (get latest stable build of X)..

I then forgot about it and released an update of the plugin and was stuck...

But that the extension is not tied 1:! to a plugin - you can have multiple extensions inside a plugin.

you can either add a test to this block or just create a new @Extension class within the plugin

It was always my intention that this would contain more than 2 keywords, but along came workflow with the 'James Nord' operator..

What I don't think benefits users is N plugins all contain a single buildflow extension.  I will grant you that a kitchen sink approach isn't super useful either, but there should be some happy medium don't you think?

  

[Daniel Beck]

On 08.07.2015, at 23:17, James Nord <james...@gmail.com> wrote:

> I will grant you that a kitchen sink approach isn't super useful either, but there should be some happy medium don't you think?

Right. I didn't object to your suggestion, I just pointed out the limiting name. If the plugin is not actually supposed to be this limited, then that's fine.

[Daniel Beck]

Jonathan,

would contributing these extensions (both HTTP and JSON) to the Buildflow Extensions Plugin as suggested by James work for you?

Daniel

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c01bd848-d298-40e0-84de-864daa591ea7%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Jonathan Niesen]

Yea. That works. I'll look into doing that in the next few days.