bitbucket plugin - JENKINS-65697 - How to inject environment variable into WorkflowMultiBranchProject (buildEnvironment isn't called...)

[tzach solomon]

Hi All,

Sorry for the long title but I'm really at lost here... 

I'm the maintainer of the bitbucket plugin and I would like to solve JENKINS-65697.
I've checked the code and it looks like the triggered job is of class WorkflowMultiBranchProject. The future job I'm getting once scheduled OK is jenkins.branch.MultiBranchProject$BranchIndexing.

I've tried to inject environment variables into it by using the already existing class BitBucketPayload which looks like this BitBucketPayload extends InvisibleAction implements EnvironmentContributingAction

My problem is that the buildEnvironment method isn't called.

What am I doing wrong?

Thanks in advance,

Tzach

[Jesse Glick]

On Mon, Jul 24, 2023 at 1:58 AM tzach solomon <tzach....@gmail.com> wrote:

I've checked the code and it looks like the triggered job is of class WorkflowMultiBranchProject. The future job I'm getting once scheduled OK is jenkins.branch.MultiBranchProject$BranchIndexing.

I've tried to inject environment variables into it by using the already existing class BitBucketPayload which looks like this BitBucketPayload extends InvisibleAction implements EnvironmentContributingAction

My problem is that the buildEnvironment method isn't called.

Nor should it be. That is an extension point for builds. You are discussing branch indexing. Maybe you are looking in the wrong place.

[tzach solomon]

Thanks Jesse for the quick response.

Is there a guide to understand how I can get build from the Queue Item I have?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1d4PqcO4LGmFrOhw%2B73DypfCvJE65QeMt9OMr4rKQ2ow%40mail.gmail.com.

[Jesse Glick]

On Tue, Jul 25, 2023 at 2:24 AM tzach solomon <tzach....@gmail.com> wrote:

get build from the Queue Item

I am not sure what that means. You are going to need to be more specific, preferably with code references, ideally a JenkinsRule-based test failing in the “right” way.

[tzach solomon]

Reviving this old thread as I got a bit of time to try to fix this bug... (Can you please help approve/disapprove my comment below?)

I've tried to figure out why `buildEnvironment` is not called and it's because when scheduling a `WorkflowMultiBranchProject` (using schedule2) with my Actions, those actions will be ignored since the branch will always be triggered with 

source.fetch(new SCMHeadObserverImpl(source, observer, listener, _factory, new IndexingCauseFactory(), null), listener);

And that is why the console always has 'Branch indexing' and not my cause.

Is that correct?

Thanks,

Tzach

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr1%2B6wVKuRED8CmKXwp6aoj-UZnwiyohoSUce%3Dcr0ymJMg%40mail.gmail.com.

[tzach....@gmail.com]

I think I've got it.
I should have used EnvironmentContributor.java as used in https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/BranchNameContributor.java#L56

An I right?

if so, what is the difference between 'EnvironmentContributor.java' and 'EnvironmentContributingAction.java'?
When should I use  EnvironmentContributor and when should I use EnvironmentContributingAction?

Thanks in advance,

Tzach

[tzach solomon]

Is https://stackoverflow.com/a/31542008/1866870 my answer?

Thanks,

Tzach

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/3018edfd-d498-4b1e-9961-c638c48f6762n%40googlegroups.com.

[Jesse Glick]

On Sat, Aug 10, 2024 at 8:32 AM tzach solomon <tzach....@gmail.com> wrote:

I've tried to figure out why `buildEnvironment` is not called and it's because when scheduling a `WorkflowMultiBranchProject` (using schedule2) with my Actions, those actions will be ignored since the branch will always be triggered with 

source.fetch(new SCMHeadObserverImpl(source, observer, listener, _factory, new IndexingCauseFactory(), null), listener);

And that is why the console always has 'Branch indexing' and not my cause.

There is little context here, but the queue item for a computed folder (like `WorkflowMultiBranchProject`) is unrelated to the queue item for a branch project child (`WorkflowJob`). If you wish to affect the latter, `EnvironmentContributor` is one option.

[tzach solomon]

Thanks Jesse! :) 
What is another option? Just so I'll know for next time :) 

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr07vCv3XLCkh6RobBMne41n1gq9EDDUzTnFWRJBo5oXaQ%40mail.gmail.com.

[Jesse Glick]

On Mon, Aug 12, 2024 at 7:45 AM tzach solomon <tzach....@gmail.com> wrote:

What is another option?

There is no other option if you simply wish to inject some environment variables at top level in a build, knowing nothing about the Pipeline being run.