Looking to contribute to Enhanced Old Build Discarder github repo (@taksan)

[Benjamin Beggs]

Hi,

I'm looking to make some pull requests to this plugin: https://github.com/jenkinsci/enhanced-old-build-discarder (author Gabriel Takeuchi @taksan). To do so, I need to either need be given sufficient privileges or the permissions on the repository have to be changed. The spec for the feature I am implementing is given below:

"Allows a user to request both quantity and age conditions be met prior to build discard. This means that if N max builds are set with M max age, builds will only be cleared if they exceed the given age <i>and</i> if their quantity exceed the N max build quantity. The feature will thus never allow build deletion to leave less builds than the N max builds set, or allow build deletion of builds under the M max age <i>regardless</i> of N max builds set."

This is a simple extension of BuildDiscarder.java that replicates the structure of LogRotator.java with the needed conditional modifications. It may make sense to merge these features with this existing plugin, rather than create a new one with this purpose.

Best,

Benjamin

[Gavin Mogan]

Why do you need privileges? You should be able to fork the repo, commit the new code to your repo and branch, then submit a pull request?

if taksan isn't available to review, thats a different matter, but i'd do the development, submit a PR. If no response, then maybe make a request to take over.

Gavin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/125f65be-9d3b-453b-9a49-5c5ba2b53a7f%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Benjamin Beggs]

You are correct here, I was receiving an error message because I was using something incorrectly. I will do things this way.

Thanks,

Benjamin

On Wednesday, June 26, 2019 at 2:29:33 PM UTC-4, Gavin Mogan wrote:

Why do you need privileges? You should be able to fork the repo, commit the new code to your repo and branch, then submit a pull request?

if taksan isn't available to review, thats a different matter, but i'd do the development, submit a PR. If no response, then maybe make a request to take over.

Gavin

On Wed, Jun 26, 2019 at 11:24 AM 'Benjamin Beggs' via Jenkins Developers <jenkin...@googlegroups.com> wrote:

Hi,

I'm looking to make some pull requests to this plugin: https://github.com/jenkinsci/enhanced-old-build-discarder (author Gabriel Takeuchi @taksan). To do so, I need to either need be given sufficient privileges or the permissions on the repository have to be changed. The spec for the feature I am implementing is given below:

"Allows a user to request both quantity and age conditions be met prior to build discard. This means that if N max builds are set with M max age, builds will only be cleared if they exceed the given age <i>and</i> if their quantity exceed the N max build quantity. The feature will thus never allow build deletion to leave less builds than the N max builds set, or allow build deletion of builds under the M max age <i>regardless</i> of N max builds set."

This is a simple extension of BuildDiscarder.java that replicates the structure of LogRotator.java with the needed conditional modifications. It may make sense to merge these features with this existing plugin, rather than create a new one with this purpose.

Best,

Benjamin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.