(replies inline)
On Tue, 10 Apr 2018, Jesse Glick wrote:
> I for one would find it easier to comment on a PR, but IIRC JEP
> editors have discouraged this for some reason????
>
>
> ???Healthness??? is not a word???it is just ???health???.
>
>
> I would suggest `/metrics/evergreen/healthcheck` just return an empty
> JSON document, or a simple ???OK??? marker by default???only listing things
> that are _not_ healthy.
It was my understanding that this format was simply the Dropwizard healthcheck
format.
Do you have some reasoning for this you could share? Otherwise this seems like
a bit of personal preference to me, but I'm sure there's some logic I could be
missing here.
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20180410143346.discdbodxgiudmfz%40grape.lasagna.io.
For more options, visit https://groups.google.com/d/optout.
2018-04-10 16:33 GMT+02:00 R. Tyler Croy <ty...@monkeypox.org>:(replies inline)
On Tue, 10 Apr 2018, Jesse Glick wrote:
> I for one would find it easier to comment on a PR, but IIRC JEP
> editors have discouraged this for some reason????
>
>
> ???Healthness??? is not a word???it is just ???health???.
>
>
> I would suggest `/metrics/evergreen/healthcheck` just return an empty
> JSON document, or a simple ???OK??? marker by default???only listing things
> that are _not_ healthy.
It was my understanding that this format was simply the Dropwizard healthcheck
format.Yes. Exactly. Also, though TBH I didn't test it myself yet, I expect one can contribute healthchecks, and they'd appear there.That "OK" idea is already somehow available if one enables the `canPing` configuration field. Then `curl`ing the URL will reply with just PONG and http-200 IIRC. But I felt this was unnecessary to enable that too.
Do you have some reasoning for this you could share? Otherwise this seems like
a bit of personal preference to me, but I'm sure there's some logic I could be
missing here.
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20180410143346.discdbodxgiudmfz%40grape.lasagna.io.
For more options, visit https://groups.google.com/d/optout.
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS6FcSp_faJL5C26-xESdUrSQvw%3D40%2BGVxf-SkWM5TOvQQ%40mail.gmail.com.
Login URL
We check that:
it is reachable,
and returns a 200 HTTP status code.
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3iufgV6J5eSf72tYk87ZXE%3DfBWk-d3WTfuME_0jmrBTA%40mail.gmail.com.