Warning during multi-branch Indexing

[pallen]

Hi Guys,

The p4-plugin shows a warning during multi-branch indexing when an old branch is being removed:


Oct 04, 2017 10:19:46 AM hudson.model.listeners.ItemListener forAll
WARNING: failed to send event to listener of class org.jenkinsci.plugins.pipeline.milestone.MilestoneStepExecution$CleanupJobsOnDelete
java.lang.NullPointerException
at org.jenkinsci.plugins.pipeline.milestone.MilestoneStepExecution$CleanupJobsOnDelete.onDeleted(MilestoneStepExecution.java:348)
at hudson.model.listeners.ItemListener$4.apply(ItemListener.java:205)
at hudson.model.listeners.ItemListener$4.apply(ItemListener.java:203)
at hudson.model.listeners.ItemListener.forAll(ItemListener.java:167)
at hudson.model.listeners.ItemListener.fireOnDeleted(ItemListener.java:203)
at com.cloudbees.hudson.plugins.folder.AbstractFolder.onDeleted(AbstractFolder.java:949)
at com.cloudbees.hudson.plugins.folder.AbstractFolder.onDeleted(AbstractFolder.java:135)
at hudson.model.AbstractItem.delete(AbstractItem.java:583)
at hudson.model.Job.delete(Job.java:687)
at com.cloudbees.hudson.plugins.folder.computed.ComputedFolder.updateChildren(ComputedFolder.java:198)
at com.cloudbees.hudson.plugins.folder.computed.FolderComputation.run(FolderComputation.java:139)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:410)


I'm not sure if this is just due to me testing on an old Jenkins (1.642.3) or if I have not implemented a cleanup method?

Kind regards,

Paul

[Stephen Connolly]

I think that is an issue in cloudbees-folders plugin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/e2717b91-0803-4621-b1da-80e327381218%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Stephen Connolly]

Nope Nope Nope... it's https://github.com/jenkinsci/pipeline-milestone-step-plugin/commit/7ecb946d1c54ed15a8f4bb9848cfaa9da7c6086f#diff-1918a0bfc343fead0364ffbc8e42b847 you just need pipeline-milestone-step 1.3.1 or newer

[Paul Allen]

Thank you.

I'm still using workflow-aggregator:jar:2.5 and that was using pipeline-milestone-step 1.3.

During development I tend the run up the plugin with 'hpi:run' rather than installing it in a running Jenkins.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMyOxffjSkhsMOspMb2tSZOp9TtuzDkbzhn8tZy4ABcxBw%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

--------------------------------------------------------------------------------
Perforce Software UK Ltd is registered in England and Wales as company no.
3816019 at the following address: West Forest Gate,
Wellington Road, Wokingham,
RG40 2AT, UK
--------------------------------------------------------------------------------

[Jesse Glick]

On Wed, Oct 4, 2017 at 7:06 AM, Paul Allen <pal...@perforce.com> wrote:
> I'm still using workflow-aggregator:jar:2.5

I strongly advise against using `workflow-aggregator` as a
`test`-scoped dependency.

[Paul Allen]

I have removed the workflow-aggregator and added the few test dependancies to the POM.  All seems ok, although the version mix was tricky to satisfy and needed a few excludes...

https://github.com/jenkinsci/p4-plugin/commit/fb48f85b0dbcf817efa6e74e236268eaf3043ebb

I had to use a VERY OLD version of 'pipeline-model-definition' to satisfy the 'pipeline' DSL tests, it seems that a lot of dependancies were added after that release.

Thanks for the help.

Kind regards,

Paul

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr33sTWB%2B-t-U3PDwHL1Jdj%3DPxok-AYgAovrtr7us_aDcg%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

[Jesse Glick]

On Thu, Oct 5, 2017 at 6:50 AM, Paul Allen <pal...@perforce.com> wrote:
> the version mix was tricky to satisfy
> and needed a few excludes...
>
> https://github.com/jenkinsci/p4-plugin/commit/fb48f85b0dbcf817efa6e74e236268eaf3043ebb

I added some comments.