Keep Build Forever interface listing disappears with plugin on legacy Jenkins

Benjamin Beggs

unread,

Jul 16, 2019, 4:53:51 PM7/16/19

to Jenkins Developers

I'm developing an update to the enhanced-old-build-discarder-plugin which adds a dropdown listing in the Discard old builds setting Strategy called Enhanced Log Rotator allowing for some additional conditional specifications with build discards. In modern Jenkins (at least 2.7.3 and up, though I expect this is true for many earlier versions as well) this Strategy can be selected and builds will continue to show their "Keep Build Forever" option. Running some tests with a legacy Jenkins instance at 1.651.3, this option disappears.

Does anyone have an idea why? The plugin functions as desired, and the plugin is written as a basic extension of the BuildDiscarder.java from the Jenkins core. I don't see why anything in the plugin code should affect this interface listing, regardless of Jenkins version.

If anyone wants to test this, the relevant PR to build is: https://github.com/jenkinsci/enhanced-old-build-discarder-plugin/pull/3

Jesse Glick

unread,

Jul 16, 2019, 5:06:14 PM7/16/19

to Jenkins Dev

On Tue, Jul 16, 2019 at 4:53 PM 'Benjamin Beggs' via Jenkins
Developers <jenkin...@googlegroups.com> wrote:
> In modern Jenkins (at least 2.7.3 and up, though I expect this is true for many earlier versions as well) this Strategy can be selected and builds will continue to show their "Keep Build Forever" option. Running some tests with a legacy Jenkins instance at 1.651.3, this option disappears.

Why even pay attention to such an old version? 2.7.1 was released
three years ago. The _oldest_ recommended baseline these days is
2.138.x.

Benjamin Beggs

unread,

Jul 17, 2019, 1:22:24 PM7/17/19

to Jenkins Developers

The plugin is set to be used on some Legacy Jenkins instances running at 1.651.3 and up, it performs as expected sans this interface difference. It's possible that debugging this compatibility issue is a rabbit hole not worth pursuing, we'll see.

Daniel Beck

unread,

Jul 17, 2019, 1:52:01 PM7/17/19

to jenkin...@googlegroups.com

> On 16. Jul 2019, at 22:53, 'Benjamin Beggs' via Jenkins Developers <jenkin...@googlegroups.com> wrote:
>
> Does anyone have an idea why?

Why not just check the changelog?

> What's new in 2.14 (2016/07/17)
>
> • Allow keeping builds forever with custom build retention strategies. (issue 26438)

Benjamin Beggs

unread,

Jul 17, 2019, 3:03:06 PM7/17/19

to Jenkins Developers

Terrific, thank you. I didn't search the change logs well enough.

Reply all

Reply to author

Forward