Updating NodeJS plugin for grunt (and getting commit access)

[o.hanetz]

Hi, 

I would like to use the NodeJS plugin (https://wiki.jenkins-ci.org/display/JENKINS/NodeJS+Plugin) to run grunt tasks.

Since currently grunt is only supported through the command-line in the plugin, I thought I might update the plugin with another build step dedicated for grunt, instead of creating my own plugin from scratch. It will be very helpful for me, and maybe for others in the future.

Please let me know if I can edit this plugin.

Thanks,

Omer

[James Nord]

I Omer

Yes well written changes to plugins are welcome.

See https://wiki.jenkins-ci.org/display/JENKINS/Governance+Document#GovernanceDocument-Makingchangestoexistingplugins for the process/details

/James

--
Sent from my Android phone with K-9 Mail. Please excuse my brevity.

[o.hanetz]

Thanks James,

Can you please provide me commit access?

My github username is ohanetz.

Thanks,

Omer

[James Nord]

Hi Omer,

You don't need commit access to create pull requests with changes for a plugin - this is documented in the link I original sent.

Normally you would submit a several pull requests to the plugin and then approach the maintainer and ask to become a co-maintainer if you wish be co-responsible for it.

/James

[o.hanetz]

Hi James,

I created a pull request with my changes to the plugin.

However, the plugin maintainer suggested that the changes are better to be included in a new plugin, because they are specific for gruntjs package (and perhaps more packages in the future), and they meant the plugin to be nodejs generic.

Therefore, can you please use my repository to start a new plugin hosted under jenkinsci?

My github username is ohanetz.

My forked repository is at https://github.com/ohanetz/nodejs-plugin

The new plugin might be called nodejs-plugin-extended

Thanks,

Omer

[o.hanetz]

Hi James,

Any update regarding my request?

Thanks,

Omer