Two waiting pull requests - please review or consider granting commit access

Łukasz Jąder

unread,

Jul 17, 2013, 1:48:41 PM7/17/13

to jenkin...@googlegroups.com

Hi, I've made 2 pull requests which provide usefull features for me:
https://github.com/jenkinsci/buildtriggerbadge-plugin/pull/3
https://github.com/jenkinsci/redmine-plugin/pull/8

Some time ago for my previous pull I've requested for commit access, which wasn't nessesary since my PR was merged by plugin maintainer.
My next PR again waits for review/merge - which I described in https://groups.google.com/forum/#!topic/jenkinsci-dev/uw6nPyWnQw8

Should I continue to wait with my both PR for response?

Baptiste MATHUS

unread,

Jul 21, 2013, 5:27:04 AM7/21/13

to jenkin...@googlegroups.com

Hi,
Sorry for the delay, currently on vacation, will review the PR for buildtriggerbadge in abt 10 days if Michaël, the other maintainer, doesn't do it before me :).

Cannot speak for redmine though.

Cheers
PS: is it possible to configure github to send an email when a new PR is submitted?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Kannan Manickam

unread,

Jul 21, 2013, 5:34:16 AM7/21/13

to jenkin...@googlegroups.com

Regarding email for pull requests, if you "watch" the repository you should receive email for all discussions in that repository. Make sure you have a valid email address in the Github notifications setting.

Message has been deleted

Kohsuke Kawaguchi

unread,

Jul 22, 2013, 9:11:23 PM7/22/13

to jenkin...@googlegroups.com, Łukasz Jąder

In the mean time I added you as a committer.

> --
> You received this message because you are subscribed to the Google
> Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jenkinsci-de...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

--

Kohsuke Kawaguchi | CloudBees, Inc. | http://cloudbees.com/
Try Jenkins Enterprise, our professional version of Jenkins

Łukasz Jąder

unread,

Jul 23, 2013, 12:55:02 PM7/23/13

to jenkin...@googlegroups.com, Łukasz Jąder

Thanks Kohsuke, I hope my improvements will make some people happy :).

Łukasz Jąder

unread,

Oct 24, 2016, 5:47:07 PM10/24/16

to Jenkins Developers

Just as a reference I've got write-access to redmine-plugin - the screenshot from chat:

Reply all

Reply to author

Forward