Continue the thread: Request to release/publish Jenkins auth plugin for Google Container Registry

[Wei Zheng]

Hi,

Don't know why but I am not able to post/reply to my original thread: 

"Request to release/publish Jenkins auth plugin for Google Container Registry".

My post/reply never showed up after I posted them. I have tried almost a dozen times starting from last Friday. So I am starting a new thread. Sorry for the inconvenience. 

I have made changes regarding its artifactId and a few other places related to its name.

Here is my answer to Stephen and Jesse's questions after some investigation:

1. This proposed plugin is compatible with docker-commons-plugin, i.e. when docker-commons-plugin looks for credentials by asking credentials providers to provide one, this proposed plugin will be evoked and provides credentials accordingly.
2. docker-build-step-plugin need to be modified to integrate with docker-commons-plugin. This plugin needs docker-build-step-plugin to work. docker-build-step-plugin (after modification) will invoke docker-commons-plugin, which will in turn trigger this proposed plugin.
3. This proposed plugin (with its current implementation) works with docker-build-step-plugin with its current implementation (i.e. when it is not integrated with docker-commons-plugin), and without any modification, it will work with docker-build-step-plugin after its integration with docker-commons-plugin. I have integrated docker-build-step-plugin with docker-commons-plugin locally and verified this.
4. I will submit a pull request to docker-build-step-plugin for integration with docker-commons-plugin. I have contributed to its auth related part before, so I think my pull request should have no problem being approved by them.

Note:

I also renamed my repo's name due to the plugin's artificateId change, the new link to my repo is:

https://github.com/wzheng2310/gcr-auth-plugin

Please reply/comment, or approve. 

Thank you very much.

Wei

[Stephen Connolly]

@James/Oleg did the build-step get re-positioned as something else during the "great experiment"?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
Sent from my phone

[Wei Zheng]

Hi, Stephen:

I am not sure why you asked whether build-step get re-positioned. The plugin I am proposing is simply a credential provider when authentication against Google Container Registry is needed. It does not perform any docker actions, so it needs to work with a plugin like docker-build-step.

Thanks.

Wei

On Sunday, June 7, 2015 at 12:12:24 PM UTC-7, Stephen Connolly wrote:

@James/Oleg did the build-step get re-positioned as something else during the "great experiment"?

On Sunday, June 7, 2015, 'Wei Zheng' via Jenkins Developers <jenkin...@googlegroups.com> wrote:

Hi,

Don't know why but I am not able to post/reply to my original thread: 

"Request to release/publish Jenkins auth plugin for Google Container Registry".

My post/reply never showed up after I posted them. I have tried almost a dozen times starting from last Friday. So I am starting a new thread. Sorry for the inconvenience. 

I have made changes regarding its artifactId and a few other places related to its name.

Here is my answer to Stephen and Jesse's questions after some investigation:

1. This proposed plugin is compatible with docker-commons-plugin, i.e. when docker-commons-plugin looks for credentials by asking credentials providers to provide one, this proposed plugin will be evoked and provides credentials accordingly.
2. docker-build-step-plugin need to be modified to integrate with docker-commons-plugin. This plugin needs docker-build-step-plugin to work. docker-build-step-plugin (after modification) will invoke docker-commons-plugin, which will in turn trigger this proposed plugin.
3. This proposed plugin (with its current implementation) works with docker-build-step-plugin with its current implementation (i.e. when it is not integrated with docker-commons-plugin), and without any modification, it will work with docker-build-step-plugin after its integration with docker-commons-plugin. I have integrated docker-build-step-plugin with docker-commons-plugin locally and verified this.
4. I will submit a pull request to docker-build-step-plugin for integration with docker-commons-plugin. I have contributed to its auth related part before, so I think my pull request should have no problem being approved by them.

Note:

I also renamed my repo's name due to the plugin's artificateId change, the new link to my repo is:

https://github.com/wzheng2310/gcr-auth-plugin

Please reply/comment, or approve. 

Thank you very much.

Wei

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Wei Zheng]

Hi, Stephen:

I do not have all the context to understand your question to James/Oleg. But I cold clarify a bit on the plugin I am proposing:

This plugin is a credential provider that provides credentials that can be used to authenticate against Google Container Registry, and nothing more. So this plugin itself doesn't not do any docker stuff, it needs a plugin like docker-build-step to actually do any docker related work.

Thanks.

Wei

On Sunday, June 7, 2015 at 12:12:24 PM UTC-7, Stephen Connolly wrote:

@James/Oleg did the build-step get re-positioned as something else during the "great experiment"?

On Sunday, June 7, 2015, 'Wei Zheng' via Jenkins Developers <jenkin...@googlegroups.com> wrote:

Hi,

Don't know why but I am not able to post/reply to my original thread: 

"Request to release/publish Jenkins auth plugin for Google Container Registry".

My post/reply never showed up after I posted them. I have tried almost a dozen times starting from last Friday. So I am starting a new thread. Sorry for the inconvenience. 

I have made changes regarding its artifactId and a few other places related to its name.

Here is my answer to Stephen and Jesse's questions after some investigation:

1. This proposed plugin is compatible with docker-commons-plugin, i.e. when docker-commons-plugin looks for credentials by asking credentials providers to provide one, this proposed plugin will be evoked and provides credentials accordingly.
2. docker-build-step-plugin need to be modified to integrate with docker-commons-plugin. This plugin needs docker-build-step-plugin to work. docker-build-step-plugin (after modification) will invoke docker-commons-plugin, which will in turn trigger this proposed plugin.
3. This proposed plugin (with its current implementation) works with docker-build-step-plugin with its current implementation (i.e. when it is not integrated with docker-commons-plugin), and without any modification, it will work with docker-build-step-plugin after its integration with docker-commons-plugin. I have integrated docker-build-step-plugin with docker-commons-plugin locally and verified this.
4. I will submit a pull request to docker-build-step-plugin for integration with docker-commons-plugin. I have contributed to its auth related part before, so I think my pull request should have no problem being approved by them.

Note:

I also renamed my repo's name due to the plugin's artificateId change, the new link to my repo is:

https://github.com/wzheng2310/gcr-auth-plugin

Please reply/comment, or approve. 

Thank you very much.

Wei

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Wei Zheng]

Hi, Stephen:

I do not have all the context to understand your question below about the "re-position", but here is a little more I want to say about the plugin I want to propose:

This plugin is a credential provider (which provides credentials when authentication against Google Container Registry is needed), it does not do any docker work, so it needs to work with a plugin like docker-build-step.

Thanks.

Wei

On Sunday, June 7, 2015 at 12:12:24 PM UTC-7, Stephen Connolly wrote:

@James/Oleg did the build-step get re-positioned as something else during the "great experiment"?

On Sunday, June 7, 2015, 'Wei Zheng' via Jenkins Developers <jenkin...@googlegroups.com> wrote:

Hi,

Don't know why but I am not able to post/reply to my original thread: 

"Request to release/publish Jenkins auth plugin for Google Container Registry".

My post/reply never showed up after I posted them. I have tried almost a dozen times starting from last Friday. So I am starting a new thread. Sorry for the inconvenience. 

I have made changes regarding its artifactId and a few other places related to its name.

Here is my answer to Stephen and Jesse's questions after some investigation:

1. This proposed plugin is compatible with docker-commons-plugin, i.e. when docker-commons-plugin looks for credentials by asking credentials providers to provide one, this proposed plugin will be evoked and provides credentials accordingly.
2. docker-build-step-plugin need to be modified to integrate with docker-commons-plugin. This plugin needs docker-build-step-plugin to work. docker-build-step-plugin (after modification) will invoke docker-commons-plugin, which will in turn trigger this proposed plugin.
3. This proposed plugin (with its current implementation) works with docker-build-step-plugin with its current implementation (i.e. when it is not integrated with docker-commons-plugin), and without any modification, it will work with docker-build-step-plugin after its integration with docker-commons-plugin. I have integrated docker-build-step-plugin with docker-commons-plugin locally and verified this.
4. I will submit a pull request to docker-build-step-plugin for integration with docker-commons-plugin. I have contributed to its auth related part before, so I think my pull request should have no problem being approved by them.

Note:

I also renamed my repo's name due to the plugin's artificateId change, the new link to my repo is:

https://github.com/wzheng2310/gcr-auth-plugin

Please reply/comment, or approve. 

Thank you very much.

Wei

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

[Stephen Connolly]

So there was some grand experiment with docker plugins that we did internally at CloudBees. There were some plugins moved refactored a bit and I was just asking if part of the result of that affected the docker-build-step plugin.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
Sent from my phone

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8ad7e73b-e805-4e3c-b7c7-b118391da8e4%40googlegroups.com.

[Wei Zheng]

First sorry for posting the same/similar content multiple times in this thread. That was because for some reason my post didn't show up so I reposted several times. Now all the repeated posts show up.

I am not sure whether docker-build-step plugin is affected by that. Is docker-build-step plugin created/owned by CloudBees?

I am the first one that added authentication into docker-build-step plugin, using DockerCredConfig , whose implementation is very similar to DockerRegistryEndpoint which is provided by docker-commons-plugin. I have modified it now to use DockerRegistryEndpoint and verify that it works, and the plugin I am asking for hosting (Google Container Registry Auth plugin) works with this modification as well, no change is needed in Google Container Registry Auth plugin.

So please approve my plugin if you think everything is fine, or give more comment/advices and I will address them accordingly.

Thank you very much.

Wei

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnSbNsKM5y0J%2BxF6vtUXy1oEQ2Dh%3DN%3D3Q6d4vViDVXpO%3Db3Tg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
Sent from my phone

[Jesse Glick]

On Thu, Jun 11, 2015 at 1:19 AM, Wei Zheng <weiz...@google.com> wrote:
> I have modified it now to use DockerRegistryEndpoint and verify that it works, and
> the plugin I am asking for hosting (Google Container Registry Auth plugin)
> works with this modification as well, no change is needed in Google
> Container Registry Auth plugin.

Sounds good to me, though I do not understand all the technicalities
here. Anyway bugs or RFEs can always be handled later; I did not mean
to hijack your original thread asking for hosting, merely to alert you
to possibilities you might have missed.

> So please approve my plugin if you think everything is fine

Was about to fork to jenkinsci but one thing caught my eye:

https://github.com/wzheng2310/gcr-auth-plugin/blob/master/CONTRIBUTING.md

I am not sure if it is legitimate for a plugin hosted on @jenkinsci to
require a non-Jenkins CLA. However artifactory-plugin already does
(JFrog CLA), and

https://wiki.jenkins-ci.org/display/JENKINS/Copyright+on+source+code

does not seem to forbid this. So I created

https://github.com/jenkinsci/google-container-registry-auth-plugin

and

https://issues.jenkins-ci.org/issues/?jql=project%20%3D%20JENKINS%20AND%20component%20%3D%20google-container-registry-auth-plugin

Do not forget to create

https://wiki.jenkins-ci.org/display/JENKINS/Google+Container+Registry+Auth+Plugin

under

https://wiki.jenkins-ci.org/display/JENKINS/Plugins

with appropriate tags, and the {excerpt} etc. Welcome!

[Christopher Orr]

On 11/06/15 15:31, Jesse Glick wrote:
> On Thu, Jun 11, 2015 at 1:19 AM, Wei Zheng <weiz...@google.com> wrote:
>> I have modified it now to use DockerRegistryEndpoint and verify that it works, and
>> the plugin I am asking for hosting (Google Container Registry Auth plugin)
>> works with this modification as well, no change is needed in Google
>> Container Registry Auth plugin.
>
> Sounds good to me, though I do not understand all the technicalities
> here. Anyway bugs or RFEs can always be handled later; I did not mean
> to hijack your original thread asking for hosting, merely to alert you
> to possibilities you might have missed.
>
>> So please approve my plugin if you think everything is fine
>
> Was about to fork to jenkinsci but one thing caught my eye:
>
> https://github.com/wzheng2310/gcr-auth-plugin/blob/master/CONTRIBUTING.md
>
> I am not sure if it is legitimate for a plugin hosted on @jenkinsci to
> require a non-Jenkins CLA. However artifactory-plugin already does
> (JFrog CLA)

Wei, you can probably remove the CLA requirement; your colleagues who
have released other Jenkins plugins have managed to do so without
requiring a CLA, e.g.:

https://github.com/jenkinsci/google-oauth-plugin
https://github.com/jenkinsci/google-storage-plugin

Regards,
Chris

[Wei Zheng]

Removed it.

Thanks.