Proposal: Moving the plugin adoption labels from Wiki to GitHub topics

[Oleg Nenashev]

Hi all,

Currently the Adoption labels are on Wiki, and hence it is no longer a way to mark plugins for adoption or unmark them for common contributors. I suggest moving the process to GitHub and to use a more-or-less common "adopt-me" GitHub topic. 

Suggested changes:

• "adopt-me" label is added to plugins which are currently marked for adoption
• As a bonus, only people with Write permissions in a repo will be able to mark plugins for adoption
• https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin is moved to GitHub. There are pending JEPs to change the process, but we can move it as is for now
• "This plugin is up for adoption. "  is removed from Jenkins from Jenkins Wiki macros. Later we can add an integration with GitHub topics to the plugin site (https://issues.jenkins-ci.org/browse/INFRA-2240)

Would everyone be fine with such suggestion?

Thanks in advance,

Oleg

[Tim Jacomb]

+1

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a7ec8008-c0e2-45c3-87e4-932df3af28ba%40googlegroups.com.

[Oleg Nenashev]

First pull request which moves the guidelines without updating them too much

https://github.com/jenkins-infra/jenkins.io/pull/2635

On Monday, November 11, 2019 at 3:41:55 PM UTC+1, Tim Jacomb wrote:

+1

On Mon, 11 Nov 2019 at 14:23, Oleg Nenashev <o.v.n...@gmail.com> wrote:

Hi all,

Currently the Adoption labels are on Wiki, and hence it is no longer a way to mark plugins for adoption or unmark them for common contributors. I suggest moving the process to GitHub and to use a more-or-less common "adopt-me" GitHub topic. 

Suggested changes:

• "adopt-me" label is added to plugins which are currently marked for adoption
• As a bonus, only people with Write permissions in a repo will be able to mark plugins for adoption
• https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin is moved to GitHub. There are pending JEPs to change the process, but we can move it as is for now
• "This plugin is up for adoption. "  is removed from Jenkins from Jenkins Wiki macros. Later we can add an integration with GitHub topics to the plugin site (https://issues.jenkins-ci.org/browse/INFRA-2240)

Would everyone be fine with such suggestion?

Thanks in advance,

Oleg

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Oleg Nenashev]

Update here. After https://github.com/jenkins-infra/update-center2/pull/316 by Gavin Mogan I think it makes sense to permit using the `adopt-this-plugin` label like in Wiki.

Later we can add some logic to support merging the labels

BR, Oleg

[Gavin Mogan]

My PR will pull any github labels it has access to, then merge in the wiki ones (from the https://github.com/jenkins-infra/update-center2/blob/master/src/main/resources/label-definitions.properties i believe), then filter them through the whitelist we setup.

So i think merging is taken care of, its just eventually deprecating wiki/label-definitions.

Next steps could easily be writing a bot that adds all the existing labels to github

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8a5550bd-8006-4ab5-b076-3072da309ccc%40googlegroups.com.

[Oleg Nenashev]

The pull request from Gavin has been merged yesterday.

Now it is possible to query adoption and deprecation statuses from the plugin site:

• https://plugins.jenkins.io/ui/search/?labels=adopt-me and https://plugins.jenkins.io/ui/search/?labels=adopt-this-plugin . The latter one is now empty
  
• https://plugins.jenkins.io/ui/search/?labels=deprecated

Now we just need to build some frontend on the plugin site around these labels.

I will update the documentation accordingly and then create follow-up tasks for the plugin site: https://jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/

BR, Oleg

On Monday, November 25, 2019 at 10:44:45 AM UTC+1, Gavin Mogan wrote:

My PR will pull any github labels it has access to, then merge in the wiki ones (from the https://github.com/jenkins-infra/update-center2/blob/master/src/main/resources/label-definitions.properties i believe), then filter them through the whitelist we setup.

So i think merging is taken care of, its just eventually deprecating wiki/label-definitions.

Next steps could easily be writing a bot that adds all the existing labels to github

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8a5550bd-8006-4ab5-b076-3072da309ccc%40googlegroups.com.

[Ullrich Hafner]

Am 17.02.2020 um 10:51 schrieb Oleg Nenashev <o.v.ne...@gmail.com>:

The pull request from Gavin has been merged yesterday.

Now it is possible to query adoption and deprecation statuses from the plugin site:

• https://plugins.jenkins.io/ui/search/?labels=adopt-me and https://plugins.jenkins.io/ui/search/?labels=adopt-this-plugin . The latter one is now empty
  

Why do we have 2 labels for the same thing? 

[Oleg Nenashev]

Why do we have 2 labels for the same thing? 

"adopt-me" was recommended by GitHub devrels as a common label for such cases.

At the moment it has a whopping 10 usages (see https://github.com/topics/adopt-me), so I am not sure about it.

I am perfectly fine with using a single label or with setting up synonyms.

Maybe https://github.com/topics/unmaintained could be better

BR, Oleg

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UoEqG5AaWJU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/30E28128-526D-419D-8955-4B55C2571F58%40gmail.com.

[Ivan Fernandez Calvo]

What about to add also a badge to the GitHub readme?
Something like the following badge

https://img.shields.io/badge/Adopt%20me-Adopt%20this%20plugin-red

[Gavin Mogan]

It doesn't have to be either or, but I prefer the GitHub topic since they are searchable and don't require committing to mark it as ready to be adopted.

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/72b2ffe5-ef29-4411-9b17-c1fc421171f5%40googlegroups.com.

[Ivan Fernandez Calvo]

Sure, the badge is something additional,
something that users can see when they go to the documentation, then they can decide
if they want to use a plugin in adoption.

[Tim Jacomb]

The badge could be automatically added on the plugin site if one of the adopt topics is added to the GitHub repo?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7e802140-b00c-4ccc-adcf-c84be95ab610%40googlegroups.com.

[Oleg Nenashev]

Yes, plugin site is something I will be doing (see the comments above).

The problem is rather with GitHub repositories and direct access to them. In this case a badge could improve visibility of the adoption status.

We could serve a badge from the plugin site for that, but IMHO it is a separate topic.

BR, Oleg

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UoEqG5AaWJU/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BicYmYzqjqo7TbOogb5LhuNBNtgmWcgd2Ld8C65aJduzbQ%40mail.gmail.com.

[Oleg Nenashev]

https://github.com/jenkins-infra/plugin-site/pull/130 for the plugin site update

On Tuesday, February 18, 2020 at 10:05:40 AM UTC+1, Oleg Nenashev wrote:

Yes, plugin site is something I will be doing (see the comments above).

The problem is rather with GitHub repositories and direct access to them. In this case a badge could improve visibility of the adoption status.

We could serve a badge from the plugin site for that, but IMHO it is a separate topic.

BR, Oleg

On Tue, Feb 18, 2020 at 10:02 AM Tim Jacomb <timja...@gmail.com> wrote:

The badge could be automatically added on the plugin site if one of the adopt topics is added to the GitHub repo?

On Tue, 18 Feb 2020 at 08:01, Ivan Fernandez Calvo <kuisat...@gmail.com> wrote:

Sure, the badge is something additional,
 something that users can see when they go to the documentation, then they can decide
if they want to use a plugin in adoption.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7e802140-b00c-4ccc-adcf-c84be95ab610%40googlegroups.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UoEqG5AaWJU/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

[Oleg Nenashev]

I have also submitted the new plugin adoption process here: https://github.com/jenkins-infra/jenkins.io/pull/2875

While I was there, I also documented a similar plugin deprecation process which should help to unblock other stories.

P.S: "adopt-me" label is removed for good so we will have a single label

BR, Oleg

[Oleg Nenashev]

TL;DR: The process is up and running!

• All foundation pull requests have been merged, including the policy updates. IMHO policy PR merge was a bit premature, but the change provides a working process at least
• Documentation is updated:
• Plugin adoption: https://jenkins.io/doc/developer/plugin-governance/adopt-a-plugin/
  
• Plugin deprecation and removal: https://jenkins.io/doc/developer/plugin-governance/deprecating-or-removing-plugin/
• Adoption labels were moved to GitHub. I applied new topics only to those plugin which have not been updated or adopted since Oct 2019 when the Wiki became read-only
• 77 plugins are marked for adoption at the moment: https://github.com/topics/adopt-this-plugin
• Plugin site links (sync is in progress):
• Plugins for adoption: https://plugins.jenkins.io/ui/search/?labels=adopt-this-plugin
• Deprecated plugins: https://plugins.jenkins.io/ui/search/?labels=deprecated

BR, Oleg

[Tony Noble]

So just to clarify - if I remove the 'adpot-this-plugin' topic from a plugin's GitHub project, that will automatically sync to the plugin page?

Tony

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/7e802140-b00c-4ccc-adcf-c84be95ab610%40googlegroups.com.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/UoEqG5AaWJU/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3BicYmYzqjqo7TbOogb5LhuNBNtgmWcgd2Ld8C65aJduzbQ%40mail.gmail.com.

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9fadc186-5e69-48b2-81c8-84b99e919100%40googlegroups.com.

[Oleg Nenashev]

Yes, it will. Unfortunately there are some significant delays due to eventual consistency. Extra fixes may be needed.

FTR  https://github.com/jenkins-infra/plugin-site/issues/132

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEWqh9EdCQ6cJ%3DGWLAW6MKhn78kB0gQTxO5WfaS3MzU43cZP%2BQ%40mail.gmail.com.