R. Tyler Croy
unread,Apr 5, 2016, 1:43:57 PM4/5/16Sign in to reply to author
Sign in to forward
You do not have permission to delete messages in this group
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to Arshad Khan, Jenkins Developers, Gus Reiber, Andrew Bayer, bat...@batmat.net, Oleg Nenashev, Tom Fennelly, Daniel Beck, james....@gmail.com
(replies inline)
Interesting work Arshad, like Oleg I'm not fond of the "hiding" of the Jenkins
logo as a watermark either, but here's some (hopefully) more constructive
criticisms:
* The text capitalization on the button in the top-nav and the main carousel
don't make sense to me. It looks to me like everything .btn has a
capitalization. Why? All capitalized letters always looks aggressive to me,
because this style is applied to all the buttons there are multiple
"aggressive" buttons jumping out at me.
* Return of dropshadows. I explicitly removed drop shadows around the feature
list and the "Getting Started" cards because they're not buttons. To me the
visual cues are totally backwards here, buttons which are clickable are
flat, but cards which are not clickable are "raised" visually through drop
shadows. There's also a hover shadow change I noticed on the blog entries on
the homepage which is unnecessary since the whole area isn't clickable.
* Colors: I don't know if this is the screencast or not, but it appears that
all colors have a 25-50% opacity black layer above them. As in, everything
appears darker than what is currently on
jenkins.io. If this was
intentional, I don't see what benefit it provides. In some places, like the
Getting Started cards, background colors disappeared removing any visual
distinction between sections (feature list verus getting started).
So those things I don't like, but the footer improvements and the popover
improvements I would love to see as standalone pull requests so they can be
merged.
Cheers
- R. Tyler Croy
------------------------------------------------------
Code: <
https://github.com/rtyler>
Chatter: <
https://twitter.com/agentdero>
% gpg --keyserver
keys.gnupg.net --recv-key 3F51E16F
------------------------------------------------------