Code review for making Managed-Scripts plugin pipeline compatible

16 views
Skip to first unread message

Michael Fowler

unread,
Aug 15, 2018, 5:42:14 PM8/15/18
to Jenkins Developers
Hi All,
 I have made the managed windows batch step of the managed scripts plugin pipeline compatible, but I don't like the way I did. I have posted the change to my repo here: https://github.com/mdkf/managed-scripts-plugin . My concerns are that the code I added to support pipeline is 90% copy-pasted and I feel there must be a more eloquent way. ManagedBatchScript.java is mostly copied from WindowsBatchScript from the DurableTask plugin. ManagedBatchScriptStep is mostly copied from the WinBatchBuilStep already in the plugin. Finally, ManagedBatchScriptStep\config-details.jelly is a verbatim copy of WinBatchBuildStep\config-details.jelly already in the plugin. Can someone find a way to reduce the amount of copy pasted code? Thanks,
-Michael
Reply all
Reply to author
Forward
0 new messages