How to avoid using prebuild() in a pipeline plugin?

[steadyonabix]

Hi

 

I’m completely new to plugin development for Jenkins, so please forgive my ignorance while I get up to speed.

 

I’m trying to refactor the OWASPZAP Jenkins plugin to support the “pipeline” or “workflow” syntax.

This plugin currently uses the prebuild() method to configure and start a standalone Java application, the OWASPZAP scanner.

 

I watched the Youtube video on refactoring for pipeline and it highlighted the need to avoid using prebuild() as it presupposes a specific run order.

 

My question is, if I don’t use prebuild() to configure and kick off this application, how do I do it?

Is the convention to create a separate stage in the pipeline or something?

 

Thanks in advance

 

steady

[Jesse Glick]

On Tue, Sep 11, 2018 at 9:01 AM steadyonabix <bradley...@gmail.com> wrote:
> This plugin currently uses the prebuild() method to configure and start a standalone Java application, the OWASPZAP scanner.

Probably this should simply be folded into your `SimpleBuildStep.perform`.

(If you really need to have something that runs before and after the
build as a whole for some reason, you can create a
`[Simple]BuildWrapper`. But I cannot see how that would be the case
here.)

> I watched the Youtube video on refactoring for pipeline and it highlighted the need to avoid using prebuild() as it presupposes a specific run order.

Noted in: https://javadoc.jenkins.io/jenkins/tasks/SimpleBuildStep.html

[steadyonabix]

Thanks Jesse,

With hindsight, an obvious solution. :)

I think the simple build step wouldn't help, as I would then have to ensure that it was run first, thereby reintroducing the specific run order.

Thanks again

[Jesse Glick]

On Wed, Sep 12, 2018 at 4:18 AM steadyonabix <bradley...@gmail.com> wrote:
> I think the simple build step wouldn't help, as I would then have to ensure that it was run first, thereby reintroducing the specific run order.

You cannot have a step which configures and starts the scanner, runs
it on whatever, and then shuts it down? Why does this need to be
complicated?

[steadyonabix]

Sorry, I thought that was what I was saying. I should have been clearer.