Proposal: Official Docker Image maintenance team (Jenkins and Agents)

[Oleg Nenashev]

Hi all,

Right now we have a number of official packages for Docker:

• https://github.com/jenkinsci/docker  
  
• https://github.com/jenkinsci/docker-slave  
  
• https://github.com/jenkinsci/docker-ssh-slave 
• https://github.com/jenkinsci/docker-jnlp-slave 
• https://github.com/jenkinsci/jnlp-agents  
  

All these repositories have different teams which define permissions/. In addition to that we have jenkinsci/docker and jenkinsci/docker-packaging-team team which also grant permissions. It is quite difficult to manage the repositories in the current state, and it is difficult to request reviews.

I suggest to keep things simple and just proceed with a single team for the official packaging:

• Introduce an official "docker-packaging-team" under umbrella of Platform Special Interest group which currently manages Docker packaging
• Cleanup existing teams, leave just one for all official Jenkins master and agent mages. Plugin Docker packaging (e.g. Remoting over Apache Kafka, Swarm plugin) will not be affected
• Update GitHub and DockerHub teams to reflect the changes (mostly jenkins4eval which grants write permissions)  
  
• Add new team to CODEOWNERS in all repos

WDYT?

Thanks in advance,

Oleg

[Mark Waite]

I would like that very much

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLCPBvAvsqC4nqpr2e%2BqBOo2BdMqa%3DY5%3Dx%2BhVO735YzX_w%40mail.gmail.com.

[Oleg Nenashev]

BTW, I suggest the following list of maintainers based on the recent activity:

• Mark Waite
• Alex Earl
• Carlos Sanchez
• Oleg Nenashev
• Baptiste Mathus
• Olivier Vernin

Alternative is to just keep all members of https://github.com/orgs/jenkinsci/teams/docker/members though some contributors are not active at the moment

BR, Oleg

On Tuesday, December 10, 2019 at 11:42:49 AM UTC+1, Mark Waite wrote:

I would like that very much

On Tue, Dec 10, 2019, 11:19 AM Oleg Nenashev <o.v.n...@gmail.com> wrote:

Hi all,

Right now we have a number of official packages for Docker:

• https://github.com/jenkinsci/docker  
  
• https://github.com/jenkinsci/docker-slave  
  
• https://github.com/jenkinsci/docker-ssh-slave 
• https://github.com/jenkinsci/docker-jnlp-slave 
• https://github.com/jenkinsci/jnlp-agents  
  

All these repositories have different teams which define permissions/. In addition to that we have jenkinsci/docker and jenkinsci/docker-packaging-team team which also grant permissions. It is quite difficult to manage the repositories in the current state, and it is difficult to request reviews.

I suggest to keep things simple and just proceed with a single team for the official packaging:

• Introduce an official "docker-packaging-team" under umbrella of Platform Special Interest group which currently manages Docker packaging
• Cleanup existing teams, leave just one for all official Jenkins master and agent mages. Plugin Docker packaging (e.g. Remoting over Apache Kafka, Swarm plugin) will not be affected
• Update GitHub and DockerHub teams to reflect the changes (mostly jenkins4eval which grants write permissions)  
  
• Add new team to CODEOWNERS in all repos

WDYT?

Thanks in advance,

Oleg

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Marky Jackson]

I like this idea

On Dec 10, 2019, at 2:19 AM, Oleg Nenashev <o.v.ne...@gmail.com> wrote:



--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

[Marky Jackson]

I have not been as active as I would like but I would also like to be a maintainer based on our previous conversation

On Dec 10, 2019, at 3:34 AM, Oleg Nenashev <o.v.ne...@gmail.com> wrote:



To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d333d077-28bb-431f-9f5a-950440970429%40googlegroups.com.

[Matt Sicker]

+1 to this idea and initial maintainers. This would go a long way
toward unblocking changes in this area! :)

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/11566D48-9955-40F5-B5EA-75CAEB228589%40gmail.com.



--
Matt Sicker
Senior Software Engineer, CloudBees

[Slide]

+1 looks like a great idea!

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4oxKYCkyCgnqxkxR0A%2BaDk%3Dbj0krcd-xAteAE-r1z-QK%3Dg%40mail.gmail.com.

--

Website: http://earl-of-code.com

[Carlos Sanchez]

LGTM

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVd7387jgmh5tEe9zfWa2pz99TSSGp%2BNCUC%3DarBfJpW7gg%40mail.gmail.com.

[Oleg Nenashev]

Thanks to all for the feedback

https://github.com/orgs/jenkinsci/teams/team-docker-packaging was created (actually I renamed @jenkinsci/docker), and there are CODEOWNERS PRs to all repositories.

Will also cleanup DockerHub later

BR, Oleg 

On Tuesday, December 10, 2019 at 8:47:50 PM UTC+1, Carlos Sanchez wrote:

LGTM

On Tue, Dec 10, 2019 at 7:51 PM Slide <slid...@gmail.com> wrote:

+1 looks like a great idea!

On Tue, Dec 10, 2019 at 8:38 AM Matt Sicker <msi...@cloudbees.com> wrote:

+1 to this idea and initial maintainers. This would go a long way
toward unblocking changes in this area! :)

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d333d077-28bb-431f-9f5a-950440970429%40googlegroups.com.
>
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/11566D48-9955-40F5-B5EA-75CAEB228589%40gmail.com.



--
Matt Sicker
Senior Software Engineer, CloudBees

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAEot4oxKYCkyCgnqxkxR0A%2BaDk%3Dbj0krcd-xAteAE-r1z-QK%3Dg%40mail.gmail.com.

--

Website: http://earl-of-code.com

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPiUgVd7387jgmh5tEe9zfWa2pz99TSSGp%2BNCUC%3DarBfJpW7gg%40mail.gmail.com.

[Tim Jacomb]

I would recommend dropping team from the name.

It’s a GitHub team, the word is implied

Tim

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5c5c5483-8486-44f0-a73e-005b9d047800%40googlegroups.com.

[Ivan Fernandez Calvo]

I'd like to be involved also at least on the testing part

[Oleg Nenashev]

The reason of the "team-" suffix was to follow the same convention as for SIGs in JEP-4 (sig-...). But I have no strong opinion, happy to remove it

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/DR9nZMRgyu8/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a2eb969d-f874-47a0-9fcc-51ed874f2128%40googlegroups.com.

[Baptiste Mathus]

I think it's actually quite useful when pinging people? Also when reading such mentions on PRs and the likes, we immediately know it's a team. Also a bit useful for auto-completion easiness I believe.

I will not fight for this though :). Either way is still ok for me.

My 2 cents

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLA-NJzBxVC3MMa95EcRCxDC0HUtZW93x89WsDR10Q9CJw%40mail.gmail.com.

[Mark Waite]

I don't seem to be able to merge pull requests or apply labels to repositories like https://github.com/jenkinsci/docker.  Is there something more that I need to do?

[Oleg Nenashev]

Fixed

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/DR9nZMRgyu8/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/cc27189f-df58-4780-ab2e-1f52d66b617e%40googlegroups.com.