Adding Workflow support for JaCoCo publisher

33 views
Skip to first unread message

Alex Soto Bueno

unread,
Jan 5, 2016, 12:06:39 PM1/5/16
to Jenkins Developers
Hi, some time ago I sent a PR to JaCoCo plugin which adds support for Jenkins Workflow plugin. You can see the PR here https://github.com/jenkinsci/jacoco-plugin/pull/63
It has been discussed vastly with other members and it seems that everything is ok except that we have added some backward incompatibility. It seems that it can be solved by using BCT but it is something we would like to avoid. We think that this backward incompatibility is not going to affect any other project, but it would be perfect to have any other review from author.

Thank you so much,
Alex

Jesse Glick

unread,
Jan 5, 2016, 12:59:49 PM1/5/16
to Jenkins Dev
On Tue, Jan 5, 2016 at 12:06 PM, Alex Soto Bueno
<asoto...@cloudbees.com> wrote:
> We think that this backward incompatibility is not going to affect any other project

Most likely true, but at least grep @jenkinsci in GitHub to see if
there are any known OSS plugins using the classes you are modifying.

Alex Soto Bueno

unread,
Jan 7, 2016, 8:32:05 AM1/7/16
to Jenkins Developers
It seems that two changes (https://github.com/search?utf8=%E2%9C%93&q=JacocoBuildAction+getOwner+user%3Ajenkinsci&type=Code&ref=searchresults) and (https://github.com/search?utf8=%E2%9C%93&q=JacocoBuildAction+owner+user%3Ajenkinsci&type=Code&ref=searchresults) related to owner 

So I would say that nobody outside JaCoCo plugin is using these changes.

PR was sent 16 days ago. I don't know if we can wait a bit more or if there is any way to merge the change and release a new version of JaCoCo with Workflow support.

Alex.
Reply all
Reply to author
Forward
0 new messages