Request ownership/action for a plugin (klocwork)

[Jacob Larfors]

Hi guys,

Maybe someone can help me out, but a few weeks back I posted about commit access to the Klocwork plugin, following a pull request for a colleague, and neither have been answered... We really want to push some great features out there but our hands our tied :)

If anyone knows how who to contact to get some action or even to apply for a transferral of ownership for a plugin that would be great.

This is the plugin in question: https://github.com/cittools/klocwork-plugin

My github account: jlarfors

Thanks for the help!

Jacob

[Daniel Beck]

We cannot grant access to repositories outside the jenkinsci GitHub organization. Which is one of the reasons why we strongly recommend that plugins be maintained in that organization.

We can only grant access to https://github.com/jenkinsci/klocwork-plugin and you'd need to sync the existing commits over. This however will not transfer existing issues and PRs in the cittools repo. IOW, it's a giant clusterfuck thanks to maintainers maintaining elsewhere.

I recommend you contact cittools and coordinate what to do with them. I can then transfer the repo as needed, and delete the one in jenkinsci that appears to have never been used.

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/973c8a41-aac1-4c5f-a76e-5091bb8f3cee%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Jacob Larfors]

Hi Daniel, appreciate the quick feedback and thanks for the info - that answered another question I had about why the jenkinsci repo even existed.

I would prefer to use the jenkinsci repo to avoid any future issues/bottlenecks. I have made one last attempt at contacting cittools because we tried contacting the owner of the repository for some time now (gboissinot) with no luck.

Should this not work, is there some way we can push our commits to the jenkinsci repository and make this the one linked in Jenkins (i.e. make the cittools repo redundant)? I assume that can be done without needing cittools, but I will await a response from them out of courtesy.

Thanks,

Jacob

[Jacob Larfors]

Ok I tried contacting the other maintainer/user at cittools and his email address for Thales does not work, so I suspect he has left Thales. As there has also been an outstanding pull request since July, and our attempts to contact the people at cittools has failed, I would assume this repository is no longer taken care of...

What options do we have? Can we make the jenkinsci repository the "main" one and we will get our commits there? There arent really any valid PRs/FRs in Jira, and the few that are we could look to transfer or fix, as we quite actively work on this plugin and have been shipping hpi files for the past few years to avoid this mess and bottleneck of waiting for cittools.

Thanks for the help.

Jacob

[Oleg Nenashev]

Any revival of this plugin will be appreciated.

Unfortunately, we cannot just fork the repository and start releasing from it. It may be considered as a highjacking of the plugin. Plugin maintainers commonly do not sign Jenkins CLA, hence we have no formal permission to do so.

I think we should fork the plugin to jenkinsci and start preparing it to the release with patches (including stuff like CI, parent POM update, etc.). If the maintainer does not respond, likely the only valid option will be to rename plugin and to change packages to avoid data conflicts. But it will require much work to implement the proper migration code.

I've added Gregory Boissinot to Cc. Maybe he could suggest the proper contact.

BR, Oleg

вторник, 15 ноября 2016 г., 14:13:29 UTC+1 пользователь Jacob Larfors написал:

[Oleg Nenashev]

In addition to this thread, I have tried to reach out Gregory directly without success. Since he has left his original company as well as his companion from citools org, it is a low chance we can proceed in the common way.

I had an f2f discussion with Jacob at Embedded Conference Scandinavia. We discussed the current state and agreed on the following:

1. Oleg will grant him an access to the klocwork repository within the jenkinsci organization (an existing repo)
2. Jacob will push the current changes in citools org and then proceed with preparing the release in pull requests (he can use jenkinsci/code-reviewers in order to get help with onboarding)
3. Oleg will try to reach out Thales directly on behalf of the Jenkins core team (in order to propose the ownership handover)
   
4. If we do not get a response from Thales, we will submit a topic to the Governance meeting with 2 options:
• Fork of a plugin with renaming/package name changes
• Just a takeover of the plugin by the Jenkins community (with temporary revokation of upload permissions for original maintainers to avoid mess if they come back and do not notice this thread)
  

WDYT?

Best regards,

Oleg

среда, 16 ноября 2016 г., 16:11:58 UTC+1 пользователь Oleg Nenashev написал:

[Oleg Nenashev]

I have added the the topic to the agenda of the tomorrow's governance meeting: https://wiki.jenkins-ci.org/display/JENKINS/Governance+Meeting+Agenda#GovernanceMeetingAgenda-Nov23meeting

Jacob, could you please provide your Jenkinsci account?

Thanks in advance,
Oleg

вторник, 22 ноября 2016 г., 17:44:02 UTC+1 пользователь Oleg Nenashev написал:

[Baptiste Mathus]

I'm personally fine with that plan.

For step "4.1", as the plugin is MIT licensed, are we really required to do such non backward compatible change? It's a really good thing to try to reach out, don't get me wrong, totally for it, but it does not work out, then not that a big deal IMO. 

I guess 4.2 will indeed be the most logical path (with no answer).

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a63d2d26-f248-403a-8ba1-c32d3a02e16d%40googlegroups.com.

[Jacob Larfors]

Many thanks for helping so much with this. The plan sounds good to me.

My Jenkinsci account is: jlarfors

Thanks again,
Jacob

[Oleg Nenashev]

Hi Jacob,

On Wednesday we agreed with the proposed plan. Here is the meeting summary: http://meetings.jenkins-ci.org/jenkins-meeting/2016/jenkins-meeting.2016-11-23-18.00.html

We agreed that I and Daniel will make the last attempt to reach out the original plugin maintainers with a final 2-week timeout. If we do not get a response, we will grant you the release permissions, no need in plugin renaming, etc.

I have granted you push permissions to https://github.com/jenkinsci/klocwork-plugin, hence you can start integrating changes there. I kindly recommend to consider using Pull requests and CCing jenkinsci/code-reviewers at the first steps (just to get some knowledge transfer). It is also recommended to update Jenkins core dependency to something newer and to use the new parent POM.

Best regards,
Oleg Nenashev



среда, 23 ноября 2016 г., 11:19:27 UTC+3 пользователь Jacob Larfors написал:

[Jacob Larfors]

Hi Oleg,

That's great - I saw the meeting summary so thanks for bringing this to light. I spoke with our plugin developer on Friday and we will get the plugin updated and ready for release whilst we wait for a reply from gboissinot and prepare a branch on the jenkinsci project ready for a pull request.

Hopefully see you at the CoDe Conf tomorrow so we can talk about this a bit more.

Safe travels with Lufthansa.

Best Regards,

Jacob

[Oleg Nenashev]

Hi,

Just FYI, we have got a reply from Gregory in the separate thread. Now you have an authorization from the original maintainer, hence you can proceed with the release once you are ready.

See you tomorrow!

Best regards,

Oleg

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/U7SFVsjsHHQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8ceb6a62-dd8f-48e0-9c9b-ce6c60cc3aa4%40googlegroups.com.

[Jacob Larfors]

Hi Oleg,

Awesome, and thanks Daniel & Gregory.

See you tomorrow.

Best Regards,

Jacob

To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPfivLDf4anAg_a4XNCNtP1xNmMoUqvN5JEiNnCmpp7%2BbqUU_Q%40mail.gmail.com.

[Daniel Beck]

> On 28.11.2016, at 17:44, Jacob Larfors <ja...@larfors.com> wrote:
>
> Awesome, and thanks Daniel & Gregory.

We have control over the klocwork plugin. It currently resides in

https://github.com/jenkinsci-transfer/klocwork-plugin

I'll rename the existing repo and move this one into jenkinsci as soon as you acknowledge; as it'll be the same remote URL in Git and could cause confusion when I do this unexpectedly.

[Jacob Larfors]

Great, I acknowledge and sounds like a good idea - so please go ahead.

Thanks,

Jacob

[Daniel Beck]

> On 01.12.2016, at 11:17, Jacob Larfors <ja...@larfors.com> wrote:
>
> Great, I acknowledge and sounds like a good idea - so please go ahead.

Hmmm that didn't work…

"jenkinsci already has a repository in the jenkinsci-transfer/klocwork-plugin network"

It looks like I'll have to delete the repo we already have (now named klocwork-plugin-fork) first. It doesn't look like it contains anything that the original we're transferring doesn't, but can you please confirm?

[Jacob Larfors]

All good to delete the jenkinsci/klocwork-plugin-fork repo as it was never used.

[Daniel Beck]

> On 01.12.2016, at 11:34, Jacob Larfors <ja...@larfors.com> wrote:
>
> All good to delete the jenkinsci/klocwork-plugin-fork repo as it was never used.

Done, and transferred the one with issues and PRs:

https://github.com/jenkinsci/klocwork-plugin

[Jacob Larfors]

Awesome - looks good. Can I also have commit access to this one, or how do we plan to do this?

My plan was to create an update branch on this repo and then file a pull request to get this into master and include the Jenkins reviewers as Oleg suggested.

GitHub user: jlarfors

Sent from my iPhone

> --
> You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/U7SFVsjsHHQ/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/FE1A646F-3671-4635-B1C0-480BB9E91F60%40beckweb.net.

[Daniel Beck]

> On 01.12.2016, at 12:13, Jacob Larfors <ja...@larfors.com> wrote:
>
> Awesome - looks good. Can I also have commit access to this one, or how do we plan to do this?
>
> My plan was to create an update branch on this repo and then file a pull request to get this into master and include the Jenkins reviewers as Oleg suggested.
>
> GitHub user: jlarfors

Granted you commit access.

Plan sounds reasonable if it's supposed to be a branch that multiple people would work on (or if you're opposed to maintaining your own fork), but most probably develop in their own fork first and base PRs on that. It also won't confuse the JIRA bot as it thinks everything in the jenkinsci repos is on master, and even resolves issues based on that :-)

[Jacob Larfors]

Thanks for commit access and the information.

Nothing opposed to a fork so lets go with that route to simplify things. The people whom I will be sharing work with are colleagues so we can share a fork and keep things separate.

Really appreciate all the help.

> --
> You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/U7SFVsjsHHQ/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/503C9858-35E9-4770-9913-2BCA949CF01C%40beckweb.net.