Maintainer request violations-plugin

156 views
Skip to first unread message

Tomas Bjerre

unread,
Nov 5, 2016, 4:12:03 AM11/5/16
to Jenkins Developers

github id: tomasbjerre
jenkins id: tomasbjerre

Tomas Bjerre

unread,
Nov 13, 2016, 11:12:05 AM11/13/16
to Jenkins Developers
Is anyone looking into this?

Daniel Beck

unread,
Nov 13, 2016, 1:30:00 PM11/13/16
to jenkin...@googlegroups.com
Hi Tomas,

It's unclear what you're asking for. You should already have commit access to this repo.

Daniel
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/daedcd22-5254-4ea8-bc8e-e4cc04b98cdd%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Tomas Bjerre

unread,
Nov 13, 2016, 1:45:55 PM11/13/16
to Jenkins Developers, m...@beckweb.net
I'm asking to become the maintainer of the repo. Be automatically assigned jira issues and make releases.

Last release was sep 8 2012 and I hear nothing from the current maintainer and the code is in terrible shape.

I rewrote the plugin using analysis-core. Added support for Job DSL, pipeline and also 4 new formats.

Baptiste Mathus

unread,
Nov 13, 2016, 2:41:00 PM11/13/16
to Jenkins Developers
Hi Tomas,

As a general rule, to get requests more quickly processed, it's better to give/remind context. The more the better...
It's definitely probably applicable to some other requests here from time to time.

To remind the general requirements: to become maintainer (and you're warmly welcome to it, thanks again), one has to show that:
  • the plugin seems indeed to be lacking an active maintainer ;
  • [s]he's tried to contact existing/previous maintainers. 
    • And that the time has already been long enough to give room for those people to answer.
  • if applicable, reminding the plugin is already marked with the "adopt-this-plugin". For example to clarify why there would be nobody in CC, see the next line.
  • provide as much as possible explanation *upfront* for any weirdness that the people like me are going to ask themselves about, see below.

As one of the people processing those emails on my free time, here's why I didn't immediately do it and went to my next pressing thing when I saw your email, because yes I saw it previously: here's what I thought and hadn't time to check the link:
"OK, he's asking to become the maintainer of some plugin, but there's nobody in CC. No explanation at all, I'll see it later"

Then, I saw it again, and clicked on the link, where I saw you seemed to be the last active maintainer. So I thought:

"WAT?!" :-)

And now I've got a bit more time to send that email for your request and in general, I can ask those questions.

If you had upfront clarified that you *were already* the last maintainer, and you somehow managed to lost access, and would like to get granted that and so on. We would most probably have all saved time :-). Add the link to the previous apparently only partly done request, and so on. If it's 'just' that you're unable to release, say it so too. You told apparently a bit more things in the last email.

So, I just re-set you as committer on that GH repo just in case. I also made you the lead of that plugin. 

If you don't know how to release, please refer to the documentation. If something is missing, please tell us or enrich the wiki page yourself. 

Thank you

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
 To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/41cce829-f360-4d22-8be6-4364497ccd99%40googlegroups.com.

Tomas Bjerre

unread,
Nov 13, 2016, 3:00:34 PM11/13/16
to jenkin...@googlegroups.com
Actually. I'd like to be completely honest here. I tried to contact Peter Reilly about a year ago. No response so I merged some PR:s and made alpha-releases. So that I could use the code as a dependency in another plugin. So no I was actually never accepted as a maintainer, my bad.
What I'd like to do now is a complete rewrite. So I'd like to be sure I am trusted to do that.

There is an issue on Github about it here: https://github.com/jenkinsci/violations-plugin/issues/88
And here is the rewrite that I'd like to release: https://github.com/jenkinsci/violations-plugin/tree/violations-lib

Thanks for your time =)

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/KjyIOtg0wWs/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
 To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4hobWJFZY6dd1v-UZ0uJSB_z4v-qLcgnQ8sCgE%2B7CJ4A%40mail.gmail.com.

Ullrich Hafner

unread,
Nov 14, 2016, 4:52:38 AM11/14/16
to Jenkins Developers
I have a question not related to the hosting request but to the architectural design of the refactoring:

Can you please explain in more detail the reason behind the switch to analysis-core *inside* of the violations plug-in? Wouldn’t it make more sense to move any parsers not yet supported by the warnings plug-in to the warnings plug-in? Then the violations plug-in would be obsolete. Otherwise we basically have two plug-ins with the same UI but a different set of parsers. This will confuse users ...

Tomas Bjerre

unread,
Nov 14, 2016, 9:32:16 AM11/14/16
to jenkin...@googlegroups.com
I made the choice to use analysis core to avoid having to implement the presentation of the findings. That is the only reason.

And yes, I think I agree with you. I did not know about the warnings plugin but I will have a closer look later.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/KjyIOtg0wWs/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1E8318EE-8CBF-421B-BC57-F9330799D9FB%40gmail.com.
Reply all
Reply to author
Forward
0 new messages