Jelly headache, page that include other page

[Nikolas Falco]

Hi, I have an issue in NodeJS plugin with feature https://issues.jenkins.io/browse/JENKINS-64646

Everytime I try to fix an issue for that feature in develop mode (hpi:run) all works like a charm, but when I release and install the hpi in a jenkins I have different behaviors.

The feature ask to propose a new Installer tool.

Actually I have a NodeJSInstaller that extends DownloadFromUrlInstaller and include its jelly page. It works great.

The feature add a MirrorJSInstaller that extends NodeJSInstaller.

This installer add two new fields and include the NodeJSInstaller jelly page.

What not does not work is that the additional fields in Mirror....Descriptor call method in superclass (that do not exists) instead of itself.

For example:

this is the request

http.../descriptorByName/hudson.plugins.nodejs.tools.NodeJSInstaller/fillCredentialsIdItems

but the expected is

http.../descriptorByName/hudson.plugins.nodejs.tools.MirrorNodeJSInstaller/fillCredentialsIdItems

In a real installation the request return 404 but in develop (hpi:run) it works and the method in MirrorJSInstaller is called.

Jelly at https://github.com/jenkinsci/nodejs-plugin/blob/master/src/main/resources/jenkins/plugins/nodejs/tools/MirrorNodeJSInstaller/config.jelly

Class at https://github.com/jenkinsci/nodejs-plugin/blob/master/src/main/java/jenkins/plugins/nodejs/tools/MirrorNodeJSInstaller.java

Someone could point me to the direction where I have to look. JELLY is a big horrible animal that hides too much (also the documentation in most of cases)

Thanks in advance to all

[Jesse Glick]

Whatever https://github.com/jenkinsci/nodejs-plugin/blob/6d9d6348f1a2fffddc4b9d711a5aef3557ffa21e/src/main/java/jenkins/plugins/nodejs/tools/MirrorNodeJSInstaller.java#L276-L280 was intended for, it looks wrong. Try deleting that as well as https://github.com/jenkinsci/nodejs-plugin/blob/6d9d6348f1a2fffddc4b9d711a5aef3557ffa21e/src/main/java/jenkins/plugins/nodejs/tools/NodeJSInstaller.java#L366-L370. If you intended to convert an installation of one type to another during upgrade, use `readResolve` (and test with `@LocalData`).

[Nikolas Falco]

THANKS!!!!

It seems was the cause why the url did change (but not the reason why in develop mode works).

Copy/Paste from NodeJSInstaller descriptor to the new one, I did not see that method.

The reason of that getId method is because of

> Obtained the updated data file for hudson.plugins.nodejs.tools.NodeJSInstaller

while the class is "jenkins.plugins.nodejs.tools.NodeJSInstaller". That is the file where load all available version of NodeJS