Upgrade guava to at least 18.0

[tamal]

Hi,

We are writing some custom Jenkins plugin that uses auto generated gRPC java client. The issue is Jenkins by default bundles Guava 15.0. But gRPC client needs 18.0, otherwise we are getting Method Not Found exceptions. So, we have modified Jenkins to use Guava 18.0. But the issue is between 15.0 and 18.0, Guava renamed method Iterators.skip() to Iterators.advance(). You can see our commit here: 

https://github.com/appscode-ci/jenkins/commit/3d67efe7b1020945a71245ffaf94438829775f8e

My question is will it be possible to upgrade Jenkins to use at least Guava 18.0 ?

Thanks.

[tamal]

I meant to say Jenkins uses Guava 11.x.

[Oliver Gondža]

I have struggled with this for a long time and (except for a distaste to
google developed libraries i have developed) it was a waste of time.
Changing the guava version in core is a challenge as there likely are
many plugins that depend on that particular version and updating it
would break binary compatibility for those plugins. What worked for me
here was instructing maven-hpi-plugin to use pluginFirstClassLoader so
your plugin will prefer the version of guava it bundles rather than the
one core happens to use. Both shading and class masking had subtle problems.

HTH
--
oliver

[Stephen Connolly]

Friends don't let friends use guava

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1ae5e6a7-f031-5d72-36ed-8249ea32f68e%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

[tamal]

Oliver,

"What worked for me 

here was instructing maven-hpi-plugin to use pluginFirstClassLoader so 
your plugin will prefer the version of guava it bundles rather than the 

one core happens to use. Both shading and class masking had subtle problems. "

Do you have any example or docs that you can point me to? Thank you,

-Tamal

[Oliver Gondža]

On 2017-02-23 02:36, tamal wrote:
> Oliver,
> "What worked for me
> here was instructing maven-hpi-plugin to use pluginFirstClassLoader so
> your plugin will prefer the version of guava it bundles rather than the
> one core happens to use. Both shading and class masking had subtle
> problems. "
>
> Do you have any example or docs that you can point me to? Thank you,

https://jenkinsci.github.io/maven-hpi-plugin/plugin-info.html
https://jenkinsci.github.io/maven-hpi-plugin/hpl-mojo.html#pluginFirstClassLoader
https://github.com/jenkinsci/openstack-cloud-plugin/blob/de02466d84f00eac7260345cc6784f354aabf76a/pom.xml#L117-L123

--
oliver

[tamal]

Thanks Oliver.

[Andrew Bayer]

fwiw, that seems to only work for certain Guava version differences - over in the jclouds plugin, I eventually ran into problems going to anything past Guava 13, I think, and ended up needing to shade Guava.

A.

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ac0d8ab2-35be-4e1f-b6db-daf521042e1b%40googlegroups.com.

[Oliver Gondža]

On 2017-02-23 21:40, Andrew Bayer wrote:
> fwiw, that seems to only work for certain Guava version differences -
> over in the jclouds plugin, I eventually ran into problems going to
> anything past Guava 13, I think, and ended up needing to shade Guava.

The openstack plugin is a fork of jclouds so I ended up fighting the
same beast. IIUC, shading (or rather class relocation) help if your
plugin code needs newer guava, which is rarely the case. It is usually
some dependency that needs that but it is not referring to your shaded
classes of course so it gets the original ones.

--
oliver

[Stephen Connolly]

Then you need to shade that dependency...

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/f3a35d24-186a-5b42-934a-58983d6fca2f%40gmail.com.

For more options, visit https://groups.google.com/d/optout.

--

Sent from my phone

[Andrew Bayer]

Yyyyup. See https://github.com/jenkinsci/pipeline-model-definition-plugin/blob/master/pipeline-model-json-shaded/pom.xml in Declarative for an example of that. And for that matter, the jclouds/OpenStack plugins are the same thing - they need to create a shaded uberjar of jclouds and Guava, with Guava relocated.

A.

On Thu, Feb 23, 2017 at 1:17 PM, Stephen Connolly <stephen.al...@gmail.com> wrote:

Then you need to shade that dependency...

On Thu 23 Feb 2017 at 20:53, Oliver Gondža <ogo...@gmail.com> wrote:

On 2017-02-23 21:40, Andrew Bayer wrote:
> fwiw, that seems to only work for certain Guava version differences -
> over in the jclouds plugin, I eventually ran into problems going to
> anything past Guava 13, I think, and ended up needing to shade Guava.

The openstack plugin is a fork of jclouds so I ended up fighting the
same beast. IIUC, shading (or rather class relocation) help if your
plugin code needs newer guava, which is rarely the case. It is usually
some dependency that needs that but it is not referring to your shaded
classes of course so it gets the original ones.

--
oliver

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/f3a35d24-186a-5b42-934a-58983d6fca2f%40gmail.com.
For more options, visit https://groups.google.com/d/optout.

--

Sent from my phone

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CA%2BnPnMzuGtrxmAK5YVPfm3R9-31hqepZG2vxVf5R4%2BnnXmjAyg%40mail.gmail.com.