Someone to take over GHPRB

[David Tanner]

Hello,

I no longer have the time to dedicate to code reviews for this project, can someone else take over?  

https://github.com/jenkinsci/ghprb-plugin

Thanks,

David Tanner

[Daniel Beck]

I marked the plugin as 'up for adoption' in the wiki:
https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/a62ad508-242a-4b0e-90e7-d18519e8bdce%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

[Ben Patterson]

Hi Daniel and David -

I can help out with this plugin if you'd like someone to guide home the pull requests and such. I have some cycles.

Care to give me contributor access?

Ben

[Ben Patterson]

Och I should have mentioned my github id: benpatterson

sent via Android

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/iHBzu1sBOmI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/32e9c050-4bf3-49a7-8fed-29391a784b9e%40googlegroups.com.

[James Dumay]

I know this plugin is extensively in use for ci.swift.org (Yeah, Apple's Swift Language team use Jenkins!) and they are running into some issues (https://github.com/janinko/ghprb/issues/150 and https://github.com/janinko/ghprb/issues/284 specifically) so it would be great to see someone pick up maintainership.

To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

[Baptiste Mathus]

Hey,
Great you're interested.
Can you give us your Jenkins id too?

Thanks

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAT-2mXtK5TXEfH0xv1vo6tdvfL-e1JL8Vh7oC3iuMHM916rfw%40mail.gmail.com.

[Ben Patterson]

Hi Baptiste -

By Jenkins ID you mean JIRA ID, right? That's bpatterson.

Let me know if you need anything else....

Ben

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4HA5svcvqQxKBS_cFNs5gs4CUXZDzF5h4gE7hfSXL20g%40mail.gmail.com.

[Baptiste Mathus]

Hi Ben,

Just made you the new maintainer of that plugin. 

Many things:

* you must accept the GitHub invitation to make that effective

* you will have to file a PR to https://github.com/jenkins-infra/repository-permissions-updater/ to be able to release

* Please beware about the backward compat. You probably want to start small, file PRs even if you think you're alone (you can ping @jenkinsci/code-reviewers if you like). Then progressively unfold sails as you go :)

Thank you and welcome!

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAT-2mWAr-Du8rWn-nhCbM0FWJNaQcwtOvVjqJyNKkeFWdGFog%40mail.gmail.com.

[David Tanner]

If you need clarification on anything I can respond to emails, I just don't have time for PR reviews/new features.

To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/32e9c050-4bf3-49a7-8fed-29391a784b9e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAT-2mXtK5TXEfH0xv1vo6tdvfL-e1JL8Vh7oC3iuMHM916rfw%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/iHBzu1sBOmI/unsubscribe.

To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4HA5svcvqQxKBS_cFNs5gs4CUXZDzF5h4gE7hfSXL20g%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

[Ben Patterson]

James - Since the plugin is maintained on jenkinsci and not janinko, is it fair enough to call the problem you're referencing https://github.com/jenkinsci/ghprb-plugin/issues/414

To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/fa7d8796-3193-4f6a-a48f-f75d4a769c03%40googlegroups.com.

[Baptiste Mathus]

@Ben, if you can indeed also work on improving that state, that would be great. Maybe breaking the fork link to make the jenkinsci repo not appear as a fork anymore, move issues to JIRA and so on... That would be probably beneficial to users to not have 2 or 3 places to look at to look for and file issues on that plugin :-/.

Thanks!

To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAAT-2mUm5u2bnR8j2uSqC6TiBCzdmQ0gAM1apsLn5%2BAir_Co2Q%40mail.gmail.com.

[Ben Patterson]

Yeah breaking the fork link would be under the control of the other repo fwiw so I couldn't promise that. But I'll give it as try. At the least, I'll play some catch up to understand where mr tanner left off, and then get things rolling again.

sent via Android

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANWgJS4EnG7XWQV3ySSM6MCffDLvTCabWmx%2BsqRnYD1oKLmNNQ%40mail.gmail.com.

[Daniel Beck]

> On 26.09.2016, at 23:04, Ben Patterson <patter...@gmail.com> wrote:
>
> Yeah breaking the fork link would be under the control of the other repo fwiw so I couldn't promise that.

I can ask GitHub support to do that if that's the consensus.

[Ben Patterson]

It sounds good to me. FWIW I had submitted an issue to the 'current' parent repo; I assume GH would only make the switch if all parties agree.

FYI - https://github.com/janinko/ghprb/issues/443

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/iHBzu1sBOmI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/DB14F1A8-672F-40CE-A999-105B4BE9F70C%40beckweb.net.

[Daniel Beck]

> On 27.09.2016, at 22:09, Ben Patterson <patter...@gmail.com> wrote:
>
> It sounds good to me. FWIW I had submitted an issue to the 'current' parent repo; I assume GH would only make the switch if all parties agree.

Breaking the connection shouldn't need that -- we could delete the repo, create a new one, then push --mirror to get a similar effect.

That said, maybe inverting the link, making jenkinci's the root of the network, would be preferable? Otherwise it's disconnected from all existing forks.

[Ben Patterson]

Well, my two cents is indeed to do things by the book in GitHub-land for the reasons that you mentioned (e.g., forks are still linked, etc.) But perhaps if that's going to be a protracted or painful process, it's worth reconsidering.

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/iHBzu1sBOmI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9CCB5398-6D4E-4C60-AC9D-48604129CE27%40beckweb.net.

[Ben Patterson]

Circling back on this thread, while I've been able to make progress as the maintainer of this plugin, I don't think it will be a successfully maintained plugin without additional help. There are some bigger-than-a-breadbox improvements needed, such as removing deprecations brought about by Jenkins 2.0, etc. If anyone has keen interest, please let me/this-line know and let's get you collaborator or maintainer status.

[Daniel Beck]

> On 15.11.2016, at 14:19, Ben Patterson <patter...@gmail.com> wrote:
>
> If anyone has keen interest, please let me/this-line know and let's get you collaborator or maintainer status.

Note that you can add a comment to adopt-this-plugin in the wiki, so you can use that as a vehicle to look for co-maintainer:

https://wiki.jenkins-ci.org/display/JENKINS/Adopt+a+Plugin#AdoptaPlugin-HowcanImarkapluginforadoption%3F

[Ben Patterson]

Good point; I'll do that as well Daniel. ty

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/iHBzu1sBOmI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/BDF8BF41-700E-457A-A853-A4A85EFE6A6C%40beckweb.net.

[jph...@linuxfoundation.org]

Hi David,
I realize it's 2017, but my company (The Linux Foundation) has a vested interest in this plugin.  I'll be glad to be a maintainer.  Github Id: JPWKU
Thanks,
Jeremy

[Ben Patterson]

Hi Jeremy -

I maintain the plugin but I'd love to share that duty. I see an e-mail from you in my work account; I'll write you back there. 👍

Ben

--

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/iHBzu1sBOmI/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/09c8ed32-d738-43ab-802e-0469932dc347%40googlegroups.com.