Request to become maintainer

181 views

Skip to first unread message

Martin Weber

unread,

May 31, 2015, 12:04:17 PM5/31/15

to jenkin...@googlegroups.com

https://wiki.jenkins-ci.org/display/JENKINS/cmakebuilder+Plugin

This project doesn't have any maintainer, I contacted the original author in
December but it still looks abandoned (Daniel Beck might remember):

Github Repository: https://github.com/jenkinsci/cmakebuilder-plugin
My Clone: https://github.com/15knots/cmakebuilder-plugin
My github ID: 15knots

Thank you.

Martin

--
Cd wrttn wtht vwls s mch trsr.

Daniel Beck

unread,

May 31, 2015, 2:37:11 PM5/31/15

to jenkin...@googlegroups.com

There has been some activity on the Github side of things (wiki still links to SVN, probably because there has not been a release) since my comments in JENKINS-25807.

https://github.com/jenkinsci/cmakebuilder-plugin/commits/master

Could you ask the current maintainer again? If he doesn't really have the time to work on it, a confirmation that he's fine with adding you as (co-)maintainer would be good.

> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4357895.lj9ZKWQ9NR%40linux.
> For more options, visit https://groups.google.com/d/optout.
>

Martin Weber

unread,

Jun 7, 2015, 9:30:28 AM6/7/15

to jenkin...@googlegroups.com

Am Sonntag, 31. Mai 2015, 20:37:05 schrieb Daniel Beck:
...

> Could you ask the current maintainer again? If he doesn't really have the
> time to work on it, a confirmation that he's fine with adding you as
> (co-)maintainer would be good.

I did.
Volker want to hand over mainainership to me.
See attached mail.

Kohsuke Kawaguchi

unread,

Jun 8, 2015, 2:07:58 PM6/8/15

to jenkin...@googlegroups.com

Added you as a committer.

As a rule of thumb, I'd like to reduce us blocking people who are interested in contributing, so we should grant the commit access in parallel to suggesting to talk to the current maintainer.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5559348.fY4hpF91yM%40linux.

For more options, visit https://groups.google.com/d/optout.

---------- 転送メッセージ ----------
From: Volker Kaiser <vol...@web.de>
To: Martin Weber <fifteen...@gmail.com>
Cc:
Date: Sun, 07 Jun 2015 07:49:50 +0200
Subject: Re: Request to become maintainer (2nd try)
Hi Martin,

since I don't seem to be able to carve out any significant time out of
my schedule to do some work on cmakebuilder, it's alright for me if you
become maintainer of the plugin.

I hereby officially hand over maintainer-ship of Jenkins
cmakebuilder-plugin to you :-)

Cheers,
Volker

Am 05.06.2015 um 21:32 schrieb Martin Weber:
> Hi Volker,
>
> I requested to become maintainer of cmakebuilder-plugin at jenkinsci.
>
> What do you think about that?
>
> Regards,
> Martin
>
> BTW: Your Jenkins profile still has vol...@java.net as your email address.
>

Kohsuke Kawaguchi

Kanstantsin Shautsou

unread,

Jun 8, 2015, 3:42:54 PM6/8/15

to jenkin...@googlegroups.com

As a rule of thumb, I'd like to reduce us blocking people who are interested in contributing, so we should grant the commit access in parallel to suggesting to talk to the current maintainer.

Sorry but i don't like such idea. Plugins had not enough quality at all and initial maintainer/dev always providing feedback that enforces reworking code.

I will prefer to see and require for new plugins instructions whether such thing is allowed (or repo based doc in cause of maintainers disappearing). I don't think that everybody (50k installations?) will be happy if i commit directly and release git plugin while 2 maintainers will be unavailable.

Oleg Nenashev

unread,

Jun 8, 2015, 3:47:08 PM6/8/15

to jenkin...@googlegroups.com

@Kohsuke. I disagree with your statement as well. On-request direct push/release permissions will lead to the violation of common plugin development practices (compatibility, core dependencies, etc.).

If a person wants to contribute and get the new version ASAP, it's better to provide a review of his pull pull request and then merge and release it if everything is OK.

понедельник, 8 июня 2015 г., 22:42:54 UTC+3 пользователь Kanstantsin Shautsou написал:

Martin Weber

unread,

Jun 8, 2015, 4:18:00 PM6/8/15

to jenkin...@googlegroups.com

Am Montag, 8. Juni 2015, 11:07:54 schrieb Kohsuke Kawaguchi:
> Added you as a committer.

Thank you, Kohsuke.

>
> As a rule of thumb, I'd like to reduce us blocking people who are
> interested in contributing, so we should grant the commit access in
> parallel to suggesting to talk to the current maintainer.

From watching this list, I know that thing may take some days.

That plugin did not release any update since 2011, those few days of delay
really do not harm.

Daniel Beck

unread,

Jun 8, 2015, 4:27:52 PM6/8/15

to jenkin...@googlegroups.com

On 08.06.2015, at 20:07, Kohsuke Kawaguchi <k...@kohsuke.org> wrote:

> As a rule of thumb, I'd like to reduce us blocking people who are interested in contributing, so we should grant the commit access in parallel to suggesting to talk to the current maintainer.

I disagree as well. There's a huge difference between admitting a new plugin into the jenkinsci org, and adding new developers/maintainers to an existing plugin.

This policy will only make existing maintainers quit when they come back from a two week vacation and their plugin is completely broken by a new developer who wasn't as familiar with it as he thought, and asked for commit access instead of opening a PR.

If the plugin is actively maintained, we should ask new contributors to open PRs instead of immediately granting commit access. _That_ should be our rule of thumb.

(Not relevant to this plugin of course, as we have confirmation that the existing maintainer is okay with handing over ownership, but it needed to be mentioned.)

Baptiste Mathus

unread,

Jun 8, 2015, 4:44:26 PM6/8/15

to jenkin...@googlegroups.com

+1 with Daniel & Oleg.

For a concrete example, I recently processed a PR [1] after it lingered for 12 days (it already happened to stay a bit longer), answered and asked for some rework because I disagreed with the implementation.

After some times, I just closed "politely" the PR.

With this policy, the contributor could have been granted access and even could have made a release of the plugin.

Though I deeply support the open policy of the Jenkins project, I'm not totally sure in this case it wouldn't appear as somehow disrespectful to the current maintainers of active projects and their past work (don't get me wrong here, I'm trying to be balanced).

Cheers

[1] https://github.com/jenkinsci/buildtriggerbadge-plugin/pull/13

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5B26B418-0412-406D-9661-D61BE3379942%40beckweb.net.

For more options, visit https://groups.google.com/d/optout.

Baptiste <Batmat> MATHUS - http://batmat.net
Sauvez un arbre,
Mangez un castor !

Martin Weber

unread,

Jun 8, 2015, 4:57:36 PM6/8/15

to jenkin...@googlegroups.com

Am Montag, 8. Juni 2015, 12:47:08 schrieb Oleg Nenashev:
> @Kohsuke. I disagree with your statement as well. On-request direct
> push/release permissions will lead to the violation of common plugin
> development practices (compatibility, core dependencies, etc.).
>
> If a person wants to contribute and get the new version ASAP, it's better
> to provide a review of his pull pull request and then merge and release it
> if everything is OK.

Oleg, Kanstantsin:
Calm down, I requested maintainership, not just 'a new version ASAP'.

In general (and from my experience at work with jenkins), I agree with
Kanstantsin, who once stated 'Jenkins is full of useless plugins', Kanstantsin
well knowing of the script kiddies, who publish a plugin and never come back
(see <https://wiki.jenkins-ci.org/display/JENKINS/cmakebuilder+Plugin> Release
history).

@Oleg, @Kanstantsin:
I need tools.
Cmake is one of these tools.
Cmakeplugin is a jenkins tool to use one of these tools.
I once had tools that bite in my hand (cheap wasserpumpenzange). Hated That!

Would you become my mentors/supervisors in maintaining cmakebuilder plugin?

Kanstantsin Shautsou

unread,

Jun 8, 2015, 5:00:33 PM6/8/15

to jenkin...@googlegroups.com

> On Jun 8, 2015, at 23:57, Martin Weber <fifteen...@gmail.com> wrote:
>
> Am Montag, 8. Juni 2015, 12:47:08 schrieb Oleg Nenashev:
>> @Kohsuke. I disagree with your statement as well. On-request direct
>> push/release permissions will lead to the violation of common plugin
>> development practices (compatibility, core dependencies, etc.).
>>
>> If a person wants to contribute and get the new version ASAP, it's better
>> to provide a review of his pull pull request and then merge and release it
>> if everything is OK.
>
> Oleg, Kanstantsin:
> Calm down, I requested maintainership, not just 'a new version ASAP’.

Hi, sorry for inconvenience. Our reply was not about your situation. Kohsuke just wrote his view point and actions in your reply.
So we carefully replied only to one sentence.
If plugin not maintained from 2011, then, of course, you have a green light for enhancing it!

>
> In general (and from my experience at work with jenkins), I agree with
> Kanstantsin, who once stated 'Jenkins is full of useless plugins', Kanstantsin
> well knowing of the script kiddies, who publish a plugin and never come back
> (see <https://wiki.jenkins-ci.org/display/JENKINS/cmakebuilder+Plugin> Release
> history).
>
> @Oleg, @Kanstantsin:
> I need tools.
> Cmake is one of these tools.
> Cmakeplugin is a jenkins tool to use one of these tools.
> I once had tools that bite in my hand (cheap wasserpumpenzange). Hated That!
>
> Would you become my mentors/supervisors in maintaining cmakebuilder plugin?
>
> Martin
>
> --
> Cd wrttn wtht vwls s mch trsr.
>
>

> --
> You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
> To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/vKZBbXy1Ngs/unsubscribe.
> To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5559681.qIqKgJCd2Q%40linux.

Martin Weber

unread,

Jun 9, 2015, 2:56:10 PM6/9/15

to jenkin...@googlegroups.com

Am Montag, 8. Juni 2015, 11:07:54 schrieb Kohsuke Kawaguchi:

> Added you as a committer.
>
> As a rule of thumb, I'd like to reduce us blocking people who are
> interested in contributing, so we should grant the commit access in
> parallel to suggesting to talk to the current maintainer.
>

Just received that mail. It reads:

You've been added to the Everyone team for the Jenkins organization. Everyone
has 401 members and gives *push* access to 1193 jenkinsci repositories.

Additionally, github subscribed me to all 1193 repositories and is flooding me
with mails.
See attachment.

Can someone please revert that? I guess that happened inadvertently.
It would be very tedious for me to unsubscribe to all of these via the web UI.

Push access to just cmakebuilder-plugin is sufficient for me.

Thanks,

Daniel Beck

unread,

Jun 9, 2015, 3:00:52 PM6/9/15

to jenkin...@googlegroups.com

What happens when you go to https://github.com/orgs/jenkinsci/teams/everyone and click 'leave'?

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/1695275.yTOcPmcC68%40linux.

> For more options, visit https://groups.google.com/d/optout.
>

Martin Weber

unread,

Jun 9, 2015, 3:09:19 PM6/9/15

to jenkin...@googlegroups.com

Am Dienstag, 9. Juni 2015, 21:00:43 schrieb Daniel Beck:
> What happens when you go to https://github.com/orgs/jenkinsci/teams/everyone
> and click 'leave'?

You’ve successfully left the team.

Thanks! I wasn´t aware of that trick.

Daniel Beck

unread,

Jun 9, 2015, 3:12:03 PM6/9/15

to jenkin...@googlegroups.com

I made you a committer of just cmakebuilder-plugin now.

> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/4627796.N2uhno3vSG%40linux.

Reply all

Reply to author

Forward

0 new messages