[Test Harness - Docker Fixtures] Java Git Docker Image?

[Cyrille Le Clerc]

Dear all,

I would like to implement ATH tests for the Maven Pipeline Plugin with Remote Build Agents. I need both a JDK and Git on these agents. The existing JavaContainer of the docker-fixtures does not bundle Git.

I think that a Docker Image with Git to run ATH tests on a remote agent could not only be valuable for the Pipeline Maven Plugin but also for the Git Plugin.

What's the best way to have a Docker Image for ATH tests with a JDK and Git? Shall I propose a PR to add the Git executable in the JavaContainer? Or shall I create a JavaGitContainer that extends the JavaContainer?

Cyrille

[Mark Waite]

If you're adding git to the container, could you also add git-lfs?  That will allow more tests to use the container.

If you'd like a sample that installs git-lfs on the Jenkins docker standard container, refer to the Dockerfile in https://github.com/MarkEWaite/docker-lfs/blob/lts-with-plugins/Dockerfile

Mark Waite (who does not currently use ATH)

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/0db0a1de-ae71-4232-848c-e5fc8f2dce39%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Oliver Gondža]

On 2017-03-28 22:11, Cyrille Le Clerc wrote:
> Dear all,
>
> I would like to implement ATH tests for the Maven Pipeline Plugin with
> Remote Build Agents. I need both a JDK and Git on these agents. The
> existing JavaContainer

> <https://github.com/jenkinsci/docker-fixtures/blob/docker-fixtures-1.0/src/main/resources/org/jenkinsci/test/acceptance/docker/fixtures/JavaContainer/Dockerfile>

> of the docker-fixtures does not bundle Git.

I am fine to include something as fundamental and lightweight as git
into the JavaContainer right away. Especially since GitContainer
provides git server functionality.

--
oliver

[Cyrille Le Clerc]

> I am fine to include something as fundamental and lightweight as git into the JavaContainer right away. 

@oliver would you be OK to also add git-lfs as Mark have suggested?

Cyrille

[Cyrille Le Clerc]

I have created

• Issue: JENKINS-43189 [docker-fixtures] Add git executable to the JavaContainer
• Pull Request: jenkinsci/docker-fixtures#2 Add the git executable to the JavaContainer for ATH tests

@Mark I have not added git-lfs as the install is not as simple as "apt-get install". I am not familiar enough with git-lfs to get the PR right.

Cyrille

[Mark Waite]

The install steps in the Dockerfile I referenced are from the Git LFS team and are designed to work well with "apt-get".  They add a separate apt repository and then use that repository to fetch the latest release of git LFS.

I'm also quite fine if you choose not to include git LFS in the image. If someone needs it, they will add it.

Mark Waite

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/2f484966-8ab8-4761-a980-ecaadef26f3d%40googlegroups.com.