[Version Number Olugin] Request for review and commit-access

[Deniz Bahadir]

Hi everybody,

2 weeks ago I provided an extension for the Version-Number Plugin. [1,2]
Since then I did not get any reaction. So, I am now following the
recommended procedures [3] and ask for someone to review my pull-request.

Especially, I am curious if it could somehow get improved by using the
Token Macro Plugin. (However, I would prefer to use the current
implementation, first.)

Nevertheless, I wanted to ask for commit-access, too. (Github-user:
"Bagira80"; repository-access to: [4])

Thank you,
Deniz Bahadir

[1] https://issues.jenkins-ci.org/browse/JENKINS-29134
[2] https://github.com/jenkinsci/versionnumber-plugin/pull/7
[3] https://wiki.jenkins-ci.org/display/JENKINS/Pull+Request+to+Repositories
[4] https://github.com/jenkinsci/versionnumber-plugin

[Oleg Nenashev]

I've added some comments to the pull request. In general I'm OK with granting permissions, but it would be better if you request reviews for changes you make in order to get some advices from other Jenkins developers.

среда, 15 июля 2015 г., 12:03:57 UTC+3 пользователь Deniz Bahadir написал:

[Oleg Nenashev]

Hi,

I've granted you a committer access. You should get an invitation to jenkinsci organization soon.

If you specify your Jenkins JIRA ID, I'll also make you a default assignee.

Best regards,

Oleg Nenashev

среда, 15 июля 2015 г., 12:03:57 UTC+3 пользователь Deniz Bahadir написал:

Hi everybody,

[Oleg Nenashev]

Hi Deniz,

I've modified the ownership in JIRA.

As a plugin owner, you're eligible to merge your pull requests when you feel they're ready.

I hope to take a look on PRs tomorrow.

2015-07-16 2:27 GMT+03:00 Deniz Bahadir <deniz....@benocs.com>:

Hi Oleg,

thank you.

My Jenkins JIRA ID is my lastname in all lowercase. ("bahadir")

I hope, I will not be the only default assignee. :-)

Best regards,
Deniz

PS: Now with commit-access, shall I merge my own pull-request?
PPS: There is a second pull-request from me with cosmetic changes: https://github.com/jenkinsci/versionnumber-plugin/pull/8

--

You received this message because you are subscribed to the Google
Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to jenkinsci-de...@googlegroups.com
<mailto:jenkinsci-de...@googlegroups.com>.
To view this discussion on the web visit
https://groups.google.com/d/msgid/jenkinsci-dev/338c0854-014e-4476-b2b4-7b47ade4b719%40googlegroups.com
<https://groups.google.com/d/msgid/jenkinsci-dev/338c0854-014e-4476-b2b4-7b47ade4b719%40googlegroups.com?utm_medium=email&utm_source=footer>.
For more options, visit https://groups.google.com/d/optout.

--
BENOCS GmbH
Dipl.-Inform. Deniz Bahadir
Winterfeldtstr. 21
10781 Berlin
Germany
Phone: +49 - 30 / 577 0004-22
Email: deniz....@benocs.com
www.benocs.com

Board of Management:
  Michael Wolz, Dr.-Ing. Oliver Holschke, Dr.-Ing. Ingmar Poese
Commercial Register: Amtsgericht Bonn HRB 19378