Running ATH to validate changes on form-element-path plugin on ci.jenkins.io ?

27 views
Skip to first unread message

Vincent Latombe

unread,
Nov 3, 2016, 5:24:44 AM11/3/16
to Jenkins Dev
Following Oliver's suggestion on PR #6 [1], I have a created a Jenkinsfile running the ATH based on the changes introduced in this plugin as any regression introduced in this plugin can impact the whole ATH.

It would be nice to be able to run this pipeline on https://ci.jenkins.io/ however as far as I understood it is not set up to run the ATH currently (at least I didn't see any ATH job on this instance)

One way I used on other instances to run ATH was to use docker-based agents using the image 'cloudbees/java-build-tools'.

Oliver Gondža

unread,
Nov 22, 2016, 9:10:44 AM11/22/16
to jenkin...@googlegroups.com, R Tyler Croy
On 2016-11-03 10:24, Vincent Latombe wrote:
> Following Oliver's suggestion on PR #6 [1], I have a created a
> Jenkinsfile running the ATH based on the changes introduced in this
> plugin as any regression introduced in this plugin can impact the whole ATH.
>
> It would be nice to be able to run this pipeline
> on https://ci.jenkins.io/ however as far as I understood it is not set
> up to run the ATH currently (at least I didn't see any ATH job on this
> instance)
>
> One way I used on other instances to run ATH was to use docker-based
> agents using the image 'cloudbees/java-build-tools'.
>
> Vincent

Ping, Can I do something to get this processed?

--
oliver

R. Tyler Croy

unread,
Nov 22, 2016, 11:14:37 AM11/22/16
to jenkin...@googlegroups.com
(replies inline)
Plugins are not yet automatically accepted for builds based on their
Jenkinsfiles in ci.jenkins.io. There's still some shared library
implementation that I need to do, and further discussion on how we're going to
manage capacity planning and security.

However, I can still add specific plugins to the include list upon request, so
next time you ping me in #jenkins-infra just make sure you mention the plugin
name before disappearing ;)



That said, this[0] Jenkinsfile was clearly written for some Jenkins which is
not ci.jenkins.io or anything that the Jenkins project runs.

* The labels it binds to are not labels we support[1]
* The Xvnc plugin isn't/won't be installed
* It requires an authenticated clone of g...@github.com:jenkinsci/a-t-h which won't work in ci.jenkins.io
* The CopyArtifact plugin is being used for unclear reasons, which also won't
work
* There are no Sauce OnDemand credentials in ci.jenkins.io, so the current
invocations of Selenium won't work

There might be a few other tidbits I'm missing, but that's the gist of it. I'm
happy to participate in future code reviews for a Jenkinsfile though!


[0] https://github.com/jenkinsci/form-element-path-plugin/blob/master/Jenkinsfile
[1] https://github.com/jenkins-infra/documentation/blob/master/ci.adoc

Cheers
- R. Tyler Croy

------------------------------------------------------
Code: <https://github.com/rtyler>
Chatter: <https://twitter.com/agentdero>

% gpg --keyserver keys.gnupg.net --recv-key 1426C7DC3F51E16F
------------------------------------------------------
signature.asc

Oliver Gondža

unread,
Nov 23, 2016, 5:57:31 AM11/23/16
to jenkin...@googlegroups.com
On 2016-11-22 17:14, R. Tyler Croy wrote:

> That said, this[0] Jenkinsfile was clearly written for some Jenkins which is
> not ci.jenkins.io or anything that the Jenkins project runs.
>
> * The labels it binds to are not labels we support[1]
> * The Xvnc plugin isn't/won't be installed
> * It requires an authenticated clone of g...@github.com:jenkinsci/a-t-h which won't work in ci.jenkins.io
> * The CopyArtifact plugin is being used for unclear reasons, which also won't
> work
> * There are no Sauce OnDemand credentials in ci.jenkins.io, so the current
> invocations of Selenium won't work

Thanks. How do you propose to address these? It should be possible to
run ATH in container and run docker fixtures in sibling containers. Is
there any image/Dockerfile we can reuse or it needs to be written from
scratch?

Thanks
--
oliver

Jesse Glick

unread,
Nov 23, 2016, 10:54:58 AM11/23/16
to Jenkins Dev
On Wed, Nov 23, 2016 at 11:57 AM, Oliver Gondža <ogo...@gmail.com> wrote:
> It should be possible to run
> ATH in container and run docker fixtures in sibling containers.

For interesting plugin builds I would also need to able to run both
Docker and XVNC, to be able to run selected acceptance tests. I
suppose the XVNC plugin is not strictly necessary since you can do the
equivalent with an appropriate Docker image and a bit of extra
scripting.

Is there some document listing what facilities are expected to be
available to `Jenkinsfile`s on ci.jenkins.io? I do not really care
about `ToolInstallation`s so long as Docker is available, but at least
a list of relevant plugins (mainly publishers) would be useful, and
some information about preferred Maven mirror usage.

Daniel Beck

unread,
Nov 23, 2016, 4:27:36 PM11/23/16
to jenkin...@googlegroups.com

> On 23.11.2016, at 16:54, Jesse Glick <jgl...@cloudbees.com> wrote:
>
> Is there some document listing what facilities are expected to be
> available to `Jenkinsfile`s on ci.jenkins.io? I do not really care
> about `ToolInstallation`s so long as Docker is available, but at least
> a list of relevant plugins (mainly publishers) would be useful, and
> some information about preferred Maven mirror usage.

https://github.com/jenkins-infra/documentation/blob/master/ci.adoc#jenkins-on-jenkins

R. Tyler Croy

unread,
Nov 29, 2016, 2:12:27 PM11/29/16
to jenkin...@googlegroups.com
(replies inline)

On Wed, 23 Nov 2016, Jesse Glick wrote:
We're pretty much on the same page with regards to Docker. I want to be out of
the practice of hand-crafting and configuring Tools and assorted other plugin
configurations for varying projects, so Docker is my ideal hammer for all those
nails :)


There's no Maven mirror setup specifically in place for ci.jenkins.io agents
and no plans to do anything there right now.

As for plugins, those are managed via Puppet and can be found by artifactId
here:
<https://github.com/jenkins-infra/jenkins-infra/blob/staging/hieradata/clients/ci.yaml#L5-L32>

Obviously that doesn't include each of those plugins dependencies, but those
are the ones explicitly installed.
signature.asc
Reply all
Reply to author
Forward
0 new messages