disk-usage-plugin seems to be abandoned

201 views
Skip to first unread message

FredG

unread,
Feb 20, 2017, 7:33:08 PM2/20/17
to Jenkins Developers
Hi,

It seems like the disk-usage-plugin has been abandoned.
Last commit is from Feb 10, 2016, last release was done October 1, 2015.
The current maintainer lvotypko did not react to messages and mentions on pull request #34.

Since there are quite a few commits with fixes that people are waiting for, including an annoying UI bug (see PR #34) that causes Icons not to show up,
I'd like to propose the following:
  • let's wait for one week
  • if maintainer does not reply or react somehow, let someone else release the plugin (any volunteers?)
  • try to contact the maintainer again, if that fails, mark the plugin for adoption


Please let me know, if this should be handled somehow differently.


Regards,


Fred

Kanstantsin Shautsou

unread,
Feb 20, 2017, 7:44:13 PM2/20/17
to Jenkins Developers
Confirm. @lvotypko made refactorings and disappeared. 
I made few attempts to request release with fixes in last half year, but nobody from RedHat made release. Plugin is very useful and before lvotypko i was even ready to refactor or write new. 
Who remember @ogondza email? Please CC him. 

Oliver Gondža

unread,
Feb 21, 2017, 3:39:23 AM2/21/17
to jenkin...@googlegroups.com, Lucie Votypkova
Lucie is taking a sick leave to respond to this thread but I afraid she
is not able to devote much more of a time to maintaining this plugin.
Feel free to proceed with adoption.

--
oliver

Oleg Nenashev

unread,
Feb 21, 2017, 6:50:55 AM2/21/17
to Jenkins Developers, lvot...@redhat.com
Hi Fred,

Are you ready to take the ownership (maybe till Lucie gets back)?
I can spin the release now if it is required, but unfortunately I have no time even to maintain my current stuff :(

BR, Oleg

P.S: Get well soon, Lucie!


вторник, 21 февраля 2017 г., 9:39:23 UTC+1 пользователь ogondza написал:

Lucie Votypkova

unread,
Feb 21, 2017, 7:36:50 AM2/21/17
to Oleg Nenashev, Jenkins Developers
Hello,
I will look at it and do release. But if you want to do some changes or maintaining, you are welcome.

Lucie

FredG

unread,
Feb 21, 2017, 5:34:34 PM2/21/17
to Jenkins Developers, lvot...@redhat.com
Hi Oleg,

Unfortunately I also have too many other things going on to maintain yet another plugin.

It looks like Lucie might be able to do a release, which would be much appreciated.
Finding a new maintainer is important, but a lot less urgent.

Regards,

Fred

FredG

unread,
Apr 18, 2017, 6:42:45 PM4/18/17
to Jenkins Developers, lvot...@redhat.com
Hi,

Unfortunately Lucie did not seem to have time to do the release.

@Oleg: Could you spin a release?
(If I don't need any special permissions, I can also do it myself if that's OK).

Regards,

Fred

Oleg Nenashev

unread,
Apr 18, 2017, 7:12:39 PM4/18/17
to Jenkins Developers, lvot...@redhat.com
Created the PR with upload permissions: https://github.com/jenkins-infra/repository-permissions-updater/pull/283

среда, 19 апреля 2017 г., 0:42:45 UTC+2 пользователь FredG написал:

Oleg Nenashev

unread,
Apr 21, 2017, 7:14:05 AM4/21/17
to JenkinsCI Developers, Lucie Votypkova
Hi,

So I made an attempt to release it... and failed. There is an unstable test "JobDiskUsageCalculationThreadTest>HudsonTestCase.runBare:293->HudsonTestCase.runTest:433->testDoNotCalculateExcludedJobs:171 Disk usage for included project should be not be counted". Have no time to dig into right now. May find some time on the weekend (unlikely), but I would appreciate if somebody fixes it.

I have also posted the changelog on the plugin's Wiki page.

The problems I see (though I cannot dedicate time to fix them right now).
  • There are some major features by Lucie, which have not been reviewed (ItemGroup actions, disk usage checks for non-loaded components, etc.)
  • There are binary-incompatible changes since 0.28 from what I see
  • POM.xml is significantly updated, in the case of this plugin it really worth going after Java 7 and its Files API

So i would appreciate help from somebody with this release testing & test fixes.

BR, Oleg



--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/JO3ONqRlP3o/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/cde2fc8f-0cad-4af8-8806-d9d97a908fb3%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

FredG

unread,
Feb 23, 2018, 8:21:58 AM2/23/18
to Jenkins Developers
Hi,

Sorry for dragging this old thread to the surface again. It's been a year since I've opened it.

I was really glad to see that Lucie found some time to work on the disk-usage plugin between September and October 2017.
She fixed some issues and added tests.

Unfortunately I still have to complain, because the main issue is that the plugin has not seen a new release since October 1st, 2015. :(

I have tried to build the plugin on my machine and faced the following issues:

- Maven enforcer plugin finds a banned dependency to jdk.tools:jdk.tools:jar:1.6
  - this is caused by the test case DiskUsageBuildListenerTest.testOnLoadCauseDeadLock() that uses Oliver Gondza's dumpling tool (https://github.com/olivergondza/dumpling)
    which apparently has a dependency to maven-jdk-tools-wrapper (https://github.com/olivergondza/maven-jdk-tools-wrapper) according to maven dependency:tree:

    [INFO] +- com.github.olivergondza.dumpling:dumpling:jar:2.2:test
    [INFO] |  +- com.github.olivergondza:maven-jdk-tools-wrapper:jar:0.1:test
    [INFO] |  |  \- jdk.tools:jdk.tools:jar:1.6:system

- Test case DiskUsageProjectActionFactoryTest.testBackwardCompatibility() fails in line 35

- FindBugs errors

I stopped after that.

Hopefully Lucie can invest the minimum amount of time to fix/disable the tests and do a long overdue release.



Regards,

Fred
Reply all
Reply to author
Forward
0 new messages