--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/DC57CD9D-9A95-4E8B-AB4F-B15D067B5BE8%40beckweb.net.
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9E86865E-831C-4B5F-A4A2-77E6AB9882EB%40beckweb.net.
Easy fix: Whoever wants to merge something on a weekend is responsible for updating the changelog.
If this isn't done, and you've merged fixes a few times, you lose commit access.
> On 18. May 2020, at 20:55, Mark Waite <mark.ea...@gmail.com> wrote:
>
> I worry that creating the changelog on Friday with release on
> Monday seems like it would either preclude merge on Saturday and on Sunday
> (for those who wish to do so)
+1 on moving to Tuesday. A nice, easy solution, where nobody has expressed any downsides.
-1 to adding further complexity to the merge process and extending issues over the weekend. This is too prone to unintentional mistakes.
Jeff
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAO49JtGoZaKxZWCdwi0e%3DwPpAA25v_AyD35Wvc5xaFcsRc7cAg%40mail.gmail.com.
+1 on moving to Tuesday. A nice, easy solution, where nobody has expressed any downsides.
-1 to adding further complexity to the merge process and extending issues over the weekend. This is too prone to unintentional mistakes.
Jeff
On 5/18/20 2:02 PM, Mark Waite wrote:
On Mon, May 18, 2020 at 1:18 PM Daniel Beck <m...@beckweb.net> wrote:
Easy fix: Whoever wants to merge something on a weekend is responsible for updating the changelog.
If this isn't done, and you've merged fixes a few times, you lose commit access.
That seems like it will dissuade maintainers from merging on weekends.
The changelog won't be available for most pull request authors to submit a proposal with their pull requests because it doesn't become available until Friday. If a maintainer starts the 24 merge clock on Friday, then when the clock is finished on Saturday, the maintainers performing a weekend merge would need to update the pull request they are merging with the changelog entry.
Mark Waite
> On 18. May 2020, at 20:55, Mark Waite <mark.e...@gmail.com> wrote:
>
> I worry that creating the changelog on Friday with release on
> Monday seems like it would either preclude merge on Saturday and on Sunday
> (for those who wish to do so)
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/9E86865E-831C-4B5F-A4A2-77E6AB9882EB%40beckweb.net.
--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAH-3Bif7em3VUMjH9v_J%2BC%2B-8J4ds9AEyYtjJWORB6BgZjqMtA%40mail.gmail.com.
This should probably be automated and changelog be ready before merging. Maybe we could use some automation and auto-merging way, like the tooling would merge automatically after 24 hours of "ready-for-merge" label + some TBD check on the changelog readiness itself before merging?
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/wrdzF_ML5go/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAPyTVp3A%2BEcg7C58Zmi%2BeT5jvic5bDRyVqhKbTH8tL5uXse5Ww%40mail.gmail.com.