Cloudbees build failing due to java doc errors?

[JordanGS]

Failed to execute goal org.apache.maven.plugins:maven-javadoc-plugin:2.10.1:javadoc (default) on project zap: An error has occurred in JavaDocs report generation

See here for full log

Usage pom.xml is available here

Notice that i have the following line since i use java 8

  <build>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-javadoc-plugin</artifactId>
        <configuration>
          <additionalparam>-Xdoclint:none</additionalparam>
        </configuration>
      </plugin>
    </plugins>
  </build>

Yet for some reason the build triggers Exit code: 1 - javadoc: error - invalid flag: -Xdoclint:none

I got the pom.xml addition from the Hosting Plugins - Working Around Common Issues

Is there something i'm missing? Thank you.

[JordanGS]

1) Do i need to reconfigure everything to run with java 7?

2) Do i need to undo my 1.0.0 release because it compiled with java 7? If so, how would i undo my release?

[Arnaud Héritier]

Hi,

  By default builds on jenkins.ci.cloudbees.com are configured with Java 7 because Jenkins itself is always supposed to be compatible with J7

  We can configure the build to use J8 but in that case you'll have to correctly document that your plugin won't run on instances using J7

  Sadly there is no metadata in the update center to let users know it from the plugins manager.

  Just let us know what you prefer to do

Cheers

On Fri, Nov 18, 2016 at 8:53 AM, JordanGS <develop...@gmail.com> wrote:

1) Do i need to reconfigure everything to run with java 7?

2) Do i need to undo my 1.0.0 release because it compiled with java 7? If so, how would i undo my release?

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/050803d3-af1d-4faa-bb41-4728d47660df%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

-----

Arnaud Héritier

http://aheritier.net

Mail/GTalk: aheritier AT gmail DOT com

Twitter/Skype : aheritier

[Jesse Glick]

Not true. Builds are done by default with JDK 8, but the binaries run on 7 as well.

If you have Javadoc errors (not merely warnings), take three minutes to fix them.

[Arnaud Héritier]

We are using JDK8 by default ? I didn't check.

I hope we have animal sniffer activated on our builds

On Fri, Nov 18, 2016 at 10:33 AM, Jesse Glick <jgl...@cloudbees.com> wrote:

Not true. Builds are done by default with JDK 8, but the binaries run on 7 as well.

If you have Javadoc errors (not merely warnings), take three minutes to fix them.

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-dev+unsubscribe@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3oppX35jh1TjMvEp565rDhCvsL2ghwZi6Et8somqM5Og%40mail.gmail.com.

For more options, visit https://groups.google.com/d/optout.

[JordanGS]

@Arnaud I will changed it to J7, then it will be compatible with J7 and J8, correct? Also do i need to undo my 1.0.0 release because it compiled with J8 and NOT J7? If so, how would i undo my release?

Please see the release (https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/zap/1.0.0/)

The plugin source can be found here (https://github.com/jenkinsci/zap-plugin)

@Jesse it says JDK7 in the link i posted above, so seems 7 is the default, no? It's more like 3-6 hours or more since it's all generated javadoc which apparently is failing *sigh*. It's a todo for the future.

[Jesse Glick]

On Fri, Nov 18, 2016 at 2:40 PM, JordanGS <develop...@gmail.com> wrote:
> do i need to undo my 1.0.0 release because it compiled with J8
> and NOT J7? If so, how would i undo my release?

Not at all, it makes no difference. We recommend building with JDK 8.

[Jesse Glick]

On Fri, Nov 18, 2016 at 10:59 AM, Arnaud Héritier <aher...@gmail.com> wrote:
> I hope we have animal sniffer activated on our builds

Yes, this is built into the plugin POM—just make sure you are using a
2.x parent.

[JordanGS]

@Jesse Thank you, that clarifies a lot! In which case can you do two things please

1. Change the Build JDK from Java 7 to Java 8 on cloudbees
2. is this pom change correct https://github.com/jenkinsci/zap-plugin/blob/master/pom.xml#L18 or do i need to do anything else?

You've commented on the other post, i see that Daniel is busy but would you mind deleteing https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/zap/1.0.0/

In hindsight, i should have waited but i had already deleted the GitHub tag and release and would much rather prefer starting from 1.0.0 since it's a new release. If it's too much work tho then thank you for your time.

Is there any way for me to manage the build settings on cloudbees myself (just curious)?

[Jesse Glick]

Just edit your POM and cut a new release. We avoid suppressing existing releases unless there is no alternative.

[Jesse Glick]

And yes just set `java.level` to 6 and you should be fine.

Currently jenkins.ci.cloudbees.com jobs are not self-configurable. We are migrating plugin builds incrementally to ci.jenkins.io though I think this is still in an experimental phase.

[JordanGS]

@Jesse It's okay thank you for the explanation. I was migrated to https://ci.jenkins.io/job/Plugins/job/zap-plugin/

I love it, thing of beauty.