Should MessageExclusion be moved up to scm-api-plugin?

[Chris Kilding]

Hello,

The Git plugin has a MessageExclusion extension to skip commits matching certain message patterns eg ‘[ci-skip]’. I have seen this reimplemented in a few different places in the Jenkins pipeline stack, and it would make sense to implement it only once.

The feature should probably live:

- At a higher abstraction level (so that all SCM providers and consumers can use it)

- As close to the checkout as possible (to allow the skip test to be performed without waiting until after the checkout directive - which is what the ci-skip-plugin does)

Would it therefore make sense to move MessageExclusion from the git-plugin to the scm-api-plugin, together with its related trait?

(Coincidentally this would deal with https://issues.jenkins-ci.org/plugins/servlet/mobile#issue/JENKINS-46081)

Regards,

Chris

[Mark Waite]

Sorry for the long delay to reply. Yes,  I think the message exclusion concept is general purpose enough that our should be a trait on the scm api. 

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/12e253d8-9bff-431f-8841-086f1ae5065f%40www.fastmail.com.
For more options, visit https://groups.google.com/d/optout.

[Jesse Glick]

Note that for multibranch projects this is done via the
`BranchBuildStrategy` API, as in `scm-trait-commit-skip-plugin`.