run.setResult(Result.FAILURE) is not failing the build

[shih...@gmail.com]

Hi All,

I have a Pipeline(Recorder) class and in the perform method I am setting the run.setResult(Result.FAILURE) if any exceptions are encountered. This does not fail the Pipeline job instantly but it executes the next stage in the job. Am I missing anything here? Appreciate your thoughts on this. 

Thank you.

[Jesse Glick]

On Fri, Apr 30, 2021 at 3:31 AM shih...@gmail.com <shih...@gmail.com> wrote:

in the perform method I am setting the run.setResult(Result.FAILURE) […] This does not fail the Pipeline job instantly but it executes the next stage in the job.

Indeed. Do not call `setResult`. Throw an exception—`AbortException` if nothing in Jenkins is broken and this is just a routine build failure.

https://javadoc.jenkins.io/jenkins/tasks/SimpleBuildStep.html#perform-hudson.model.Run-hudson.FilePath-hudson.EnvVars-hudson.Launcher-hudson.model.TaskListener-

(The one case where `setResult` is sometimes used is with `UNSTABLE`, to explicitly proceed with the build while marking it as yellow. Even this is not generally a good idea; better to use https://javadoc.jenkins.io/plugin/workflow-api/org/jenkinsci/plugins/workflow/actions/WarningAction.html to be targeted. `JUnitResultsStepExecution` does both.)