Seven segment library

[vasi vasi]

Hi guys,

There is a problem with seven_segment.jal and if I remember, is not the first time I signaled this.

If you look at it, there is a missing value, you jump from 24 to 26. in both the comment section where you document the library, and in the code section.

The code from the value 25 is missing... now, not too big of a deal, as everything is functional, but, there is no really a 27 value (it will give you an error) and the 26 value will not return what you would expect to return. Hopefully, I am clearer now than back then in explaining the problem...

Not a problem for me, I had my own corrections and adds... just saying...

--

Vasi

[Rob CJ]

Hi Vasi,

Thanks for reporting is. Since you already fixed it can you give me the exact code change that you made?

Ik will upload it for the next build.

Thanks

Kind regards,

Rob

---

Van: jal...@googlegroups.com <jal...@googlegroups.com> namens vasi vasi <fun...@gmail.com>
Verzonden: zondag 5 mei 2024 06:37
Aan: jal...@googlegroups.com <jal...@googlegroups.com>
Onderwerp: [jallib] Seven segment library

 

--
You received this message because you are subscribed to the Google Groups "jallib" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jallib+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/CABsDq%3D_qxMjuhCtEM_PV2GCG1WM%2BHv0pbh5%2Bi3fF-dXs6tP75w%40mail.gmail.com.

[Rob CJ]

Hi Vasi,

I had a quick look and normally you should move 26 to 25 and 27 to 26 but that would mean that exisiting application might not work correctly  anymore.

An alternative would be to add 25 and use that for all segments off which is the same a space.

If users to not mind the move (the first option) then I can change that. 

Suggestions are welcome. 

Kind regards,

Rob

---

Van: jal...@googlegroups.com <jal...@googlegroups.com> namens Rob CJ <rob...@hotmail.com>
Verzonden: zondag 5 mei 2024 07:48
Aan: jal...@googlegroups.com <jal...@googlegroups.com>
Onderwerp: Re: [jallib] Seven segment library

 

To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/GVXP195MB1637EEB3C890A8323109E4C4E61D2%40GVXP195MB1637.EURP195.PROD.OUTLOOK.COM.

[vasi vasi]

Hi Rob

For the 25 value I used the h_small char (h)...

But the library I was working on is for gcbasic. No problem in sending it to you, is easy to read.

Anyway, it might need the validation of others... or a rearranging of  the chars...

Ah, just found the old one I corrected and with some additions... back in 2014.. but it has a different arrangement...

As I said, it needs some supervision...

To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/GVXP195MB163719F2267C9E1658855EEAE61D2%40GVXP195MB1637.EURP195.PROD.OUTLOOK.COM.

--

Vasi

[vasi vasi]

Anyway, the developer that stole the 25th char, should get in front, admit it and return the char... Just kidding.  😄

--

Vasi

[zet.weeh]

Hi Rob

When I started with JAL I sometimes get a message in the compiler: deprecated.

Then I knew something changed in the library.

I did not see it the last years but maybe a suggestion.

I think it was a good way to update a library.

Peter

To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/CABsDq%3D_2vCOh8N%2Bd7WZKhQgJgp5hAOwAapnPi8b0u%2BUXxNRMFQ%40mail.gmail.com.

[Rob CJ]

Hi Vasile,

I uploaded the updated library using your example. No breaking changes.

Thanks.

Kind regards,

Rob

---

Van: jal...@googlegroups.com <jal...@googlegroups.com> namens zet.weeh <zet....@gmail.com>
Verzonden: maandag 6 mei 2024 15:07
Aan: jal...@googlegroups.com <jal...@googlegroups.com>
Onderwerp: RE: [jallib] Seven segment library

 

To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/001101da9fb6%245d64c3c0%24182e4b40%24%40gmail.com.