Instruction shown as not covered but debugger steps into

[Simon Martinelli]

Hi,

I have a simple class and the report looks like this:

I'm 100% sure that line 13 is called why does it report that the instruction was missed?

Thanks Simon

[Marc Hoffmann]

Hi Simon,

I quickly tested you scenario and I cannot reproduce this. If you provide a executable reproducer (e.g. Github Repo with Maven build) we can analyse the problem you see.

Cheers,

-marc

[Simon Martinelli]

Hi Marc,

you can use: https://github.com/utPLSQL/utPLSQL-maven-plugin

Checkout the develop branch and run the tests with the profile "coverage"

Thanks, Simon

[Marc Hoffmann]

Hi Simon,

I can’t find a isEmpty() method in this repo on branch develop that looks like the one in your initial post:

https://github.com/utPLSQL/utPLSQL-maven-plugin/blob/develop/src/main/java/org/utplsql/maven/plugin/util/StringUtil.java

Cheers,

-marc

--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jacoco/84cc6c0c-600d-4c3a-bf35-94e49b75e6c0n%40googlegroups.com.

[Simon Martinelli]

Hi Marc,

Yes you are right, I'm sorry. This is the same but just a bit differently structured.

I've now committed the code as it is in the example. 

But the code coverage report looks the same. 

https://sonarcloud.io/component_measures?id=org.utplsql%3Autplsql-maven-plugin&metric=coverage&selected=org.utplsql%3Autplsql-maven-plugin%3Asrc%2Fmain%2Fjava%2Forg%2Futplsql%2Fmaven%2Fplugin%2Futil%2FStringUtil.java&view=list

IMHO all branches are covered by these tests: 
https://github.com/utPLSQL/utPLSQL-maven-plugin/blob/develop/src/test/java/org/utplsql/maven/plugin/util/StringUtilTest.java

Thanks for your help

Simon

[Evgeny Mandrikov]

Hi Simon,

According to https://github.com/utPLSQL/utPLSQL-maven-plugin/runs/4453733580?check_suite_focus=true#step:9:57

StringUtilTest is not executed,

the only executed test is UtPlsqlMojoTest.

Also you can observe that execution of

mvn clean verify -P coverage -DskipITs -Dtest=\*StringUtil\*

fails with message

No tests were executed!

StringUtilTest is JUnit 5 test,

whereas UtPlsqlMojoTest is JUnit 4 test.

Similarly to https://github.com/jacoco/jacoco/issues/1048#issuecomment-615490610

You're using maven-surefire-plugin version 2.12.4, however

to execute JUnit 5 tests you need at least maven-surefire-plugin version 2.22.0 - see https://issues.apache.org/jira/browse/SUREFIRE-1330

After addition to your pom.xml of

            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <version>2.22.2</version>
            </plugin>

Same command succeeds, executes StringUtilTest and produces following expected report

[Simon Martinelli]

Hi Evgeny 

Didn't spot this problem 😅

Thank you very much! 

Simon