Status of Pull Request 97 - multi module aggregration

Martijn Verburg

unread,

Aug 28, 2015, 10:03:11 AM8/28/15

to JaCoCo and EclEmma Users

Hi all,

Was wondering what the status of PR 97 was.

https://github.com/jacoco/jacoco/pull/97

Also, how does one volunteer as a committer / maintainer for jacoco?

Cheers,
Martijn

Evgeny Mandrikov

unread,

Aug 31, 2015, 1:22:10 PM8/31/15

to JaCoCo and EclEmma Users

Hi Martijn

Regarding committer rights: I would prefer Marc Hoffmann as an author and project lead to give an answer on this question. As IMO he has ultimate word in such decisions. However as I know - we don't have formal rules written somewhere. So far we were proposing to become committer based on size of contributions and internal discussions on a case by case basis.

From here IMO the best way to get in - is to solve some outstanding tasks and go thru process of review by existing committers till acceptance.

And you're right - PR 97 is a PR for one (among many) of such tasks, most awaited one. For this feature there are many unfinished PRs, which focus on particular cases, lack tests, examples, documentation. In past due to lack of free time I didn't succeeded in finishing of this work by addition of missing parts and so on (shame on me) and Marc doesn't work on integration with Maven. If you're willing to take the lead here, your help will be appreciated. We can even do a live discussion via Skype or Google Hangout.

Best regards

Marc R. Hoffmann

unread,

Aug 31, 2015, 2:51:50 PM8/31/15

to jac...@googlegroups.com

Hi Martijn,

many thanks for offering your support! I would appreciate having you as additional JaCoCo maintainer. As a first step I will invite you to our developer mailing list, so we don't spam the user's forum here.

https://groups.google.com/forum/?fromgroups=#!forum/jacoco-dev

See you over there,
-marc

--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jacoco/36704ad1-5ea1-4001-a979-08f493300e0d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Martijn Verburg

unread,

Aug 31, 2015, 6:57:35 PM8/31/15

to jac...@googlegroups.com

Cool, FYI - I've 'contacted the owner' there as the usual Google Group subscription options don't seem to be there?

Cheers,
Martijn

To view this discussion on the web visit https://groups.google.com/d/msgid/jacoco/55E4A244.5050700%40mountainminds.com.

Martijn Verburg

unread,

Aug 31, 2015, 7:01:31 PM8/31/15

to jac...@googlegroups.com

Hi Evgeny,

I'll try to continue the conversation in the -dev list (having some trouble signing up). But that sounds good although I'll confess I'll actually be trying to drag in the OP for PR 97 as he has the skillset/ideas to finish this piece off (and I can facilitate getting some short-medium term company time for that).