[PATCH v1 1/1] initramfs: correct parameter reference in hook_error function

[Rakesh Kumar]

Fixed an issue in the hook_error function where the second
parameter ($2) was incorrectly referenced in the error message output.
The correct first parameter ($1) is now used to ensure that the
specified argument to hook_error is correctly logged into the logfile.

Signed-off-by: Rakesh Kumar <kumar....@siemens.com>
---
.../initramfs-tee-supplicant-hook/files/tee-supplicant.hook | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-supplicant.hook b/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-supplicant.hook
index 3e6adbed..3e2f4016 100644
--- a/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-supplicant.hook
+++ b/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-supplicant.hook
@@ -24,7 +24,7 @@ esac
. /usr/share/initramfs-tools/hook-functions

hook_error() {
- echo "(ERROR): $2" >&2
+ echo "(ERROR): $1" >&2
exit 1
}

--
2.39.2

[Jan Kiszka]

Reviewed-by: Jan Kiszka <jan.k...@siemens.com>

Thanks,
Jan

--
Siemens AG, Technology
Linux Expert Center

[Kumar, Rakesh]

Hi all,

If there are no concerns or comments, could we proceed with merging these changes.


Regards,
Rakesh

> +++ upplicant.hook

[Uladzimir Bely]

On Tue, 2024-09-03 at 18:45 +0530, 'Rakesh Kumar' via isar-users wrote:
> Fixed an issue in the hook_error function where the second
> parameter ($2) was incorrectly referenced in the error message
> output.
> The correct first parameter ($1) is now used to ensure that the
> specified argument to hook_error is correctly logged into the
> logfile.
>
> Signed-off-by: Rakesh Kumar <kumar....@siemens.com>
> ---
>  .../initramfs-tee-supplicant-hook/files/tee-supplicant.hook     | 2
> +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

> diff --git a/meta/recipes-initramfs/initramfs-tee-supplicant-
> hook/files/tee-supplicant.hook b/meta/recipes-initramfs/initramfs-
> tee-supplicant-hook/files/tee-supplicant.hook
> index 3e6adbed..3e2f4016 100644
> --- a/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-
> supplicant.hook
> +++ b/meta/recipes-initramfs/initramfs-tee-supplicant-hook/files/tee-

> supplicant.hook
> @@ -24,7 +24,7 @@ esac
>  . /usr/share/initramfs-tools/hook-functions
>  
>  hook_error() {
> -    echo "(ERROR): $2" >&2
> +    echo "(ERROR): $1" >&2
>      exit 1
>  }
>  
> --
> 2.39.2
>

Applied to next, thanks.

--
Best regards,
Uladzimir.