Signtool always failed with exit code 1 when signing the final setup.exe

[Joke Huang]

It's only failure when using the GUI compiler.

All the other signing duration build time is good, except the final setup.exe.

Use ISCC.exe to build by command line also works well.

[Joke Huang]

Nobody know?

[Gavin Lambert]

If it fails, it should display some kind of error.

[Joke Huang]

Gavin Lambert <i...@mirality.co.nz> 于2021年8月25日周三 上午8:21写道：

--
You received this message because you are subscribed to a topic in the Google Groups "innosetup" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/innosetup/WUsSDW90sBE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to innosetup+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/653cd31e-2a9f-1747-461e-10656a84aee8%40mirality.co.nz.

[Jernej Simončič]

On Wednesday, August 25, 2021, 22:27:36, Joke Huang wrote:

What happens if you run the same command manually?

-- 
< Jernej Simončič ><><><><>< https://eternallybored.org/ >

A proliferation of new laws creates a proliferation of new loopholes.
       -- Cooper's Metalaw

[Joke Huang]

It will be a success.

Jernej Simončič <jernej|s-g....@eternallybored.org> 于2021年8月26日周四 上午5:06写道：

--

You received this message because you are subscribed to a topic in the Google Groups "innosetup" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/innosetup/WUsSDW90sBE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to innosetup+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/492298301.20210825230628%40eternallybored.org.

[Andrew Truckle]

The GUI also has Sign Configuration values. Might they be set wrong?

[Joke Huang]

No, there has been no problem a few months ago. This problem frequently appeared after the recent update to 6.2, and it was successful in rare cases.

Andrew Truckle <truc...@gmail.com> 于2021年8月29日周日 下午8:59写道：

To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/16a93998-508f-408b-a11f-181e78100615n%40googlegroups.com.

[Jernej Simončič]

On Sunday, August 29, 2021, 15:02:30, Joke Huang wrote:

No, there has been no problem a few months ago. This problem frequently appeared after the recent update to 6.2, and it was successful in rare cases.

If you use an antivirus, add exception for the directory where the installer is created.

 

-- 
< Jernej Simončič ><><><><>< https://eternallybored.org/ >

Hot glass looks the same as cold glass.
       -- Cirino's Law of Burnt Fingers

[Joke Huang]

No, just Win10 Defender.

Jernej Simončič <jernej|s-g....@eternallybored.org> 于2021年8月29日周日 下午9:17写道：

--

You received this message because you are subscribed to a topic in the Google Groups "innosetup" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/innosetup/WUsSDW90sBE/unsubscribe.
To unsubscribe from this group and all its topics, send an email to innosetup+...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/1695141106.20210829151729%40eternallybored.org.

[Andrew Truckle]

I don’t think you have shown any script? Can’t you show your script and mask the password etc.?

 

Sent from Mail for Windows

To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/CAJ02MRrTvP%2BnkYEVaZH9PvyXuBJiioFr2x1kRz7nmPqRmJ%2Bd6g%40mail.gmail.com.

 

---

This email has been checked for viruses by Avast antivirus software. www.avast.com

[Joke Huang]

If it build success by command line, that means it's not a script problem.

Andrew Truckle <truc...@gmail.com> 于2021年8月29日周日 下午9:44写道：

To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/8B474B03-4CD6-4C31-9DD5-76DFB2BB6E3B%40hxcore.ol.

[Joke Huang]

Andrew Truckle <truc...@gmail.com> 于2021年8月29日周日 下午9:44写道：

I don’t think you have shown any script? Can’t you show your script and mask the password etc.?

To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/8B474B03-4CD6-4C31-9DD5-76DFB2BB6E3B%40hxcore.ol.

[Andrew Truckle]

I might be wrong but I don’t see any quotes around your paths which have spaces in. I might be wrong. I can’t zoom into your image on my iPad. In my script I think I used $q or so thing for the quote character. I am not at home to check.

[Joke Huang]

Is the sign tools configuration sharing between GUI and Command Line (ISCC.exe)? If yes, why the command line build success but GUI failure?

Andrew Truckle <truc...@gmail.com> 于2021年8月31日周二 上午1:12写道：

To view this discussion on the web visit https://groups.google.com/d/msgid/innosetup/3fba4c5c-38d4-4302-b67b-96848c555bffn%40googlegroups.com.

[Laurent Combémorel]

Hi

I have the same issue, signing with the GUI sometimes succeeds and sometimes fails.

I found out that, in my case, it is failing when a Windows explorer is opened on the Output directory! Windows explorer detects the new file and opens it to see what's inside, so Signtool cannot get exclusive access to it for signing, and fails. When there is no Windows explorer opened on the Output directory, it succeeds...

Hope this helps!

[Joke Huang]

@Laurent Combémorel God, you solve it!!!

[Stephen Greenfield]

Holy smokes, @Laurent Combémorel -- I ran into this issue this evening, too!  I would NOT have ever been able to figure out that this was the cause of the problem!  I did notice my first attempt to sign worked perfectly, then subsequent attempts failed -- because I had in fact left open the Output directory folder!

I don't know if this is actually an Inno Setup error, however, I was going to suggest a minor feature change that would certainly eliminate the problem:

It would be nice for Inno Setup to always close the Output Folder, and then OPTIONALLY (checkbox option) open it when compilation has completed successfully.  This would also eliminate the issue of having multiple output folders open when doing a lot of compiles and copying the installer to a test VM/machine.

Thanks!